feat(server): add BASE_PATH environment variable support#2830
Open
feat(server): add BASE_PATH environment variable support#2830
Conversation
Add support for configuring the application base path via the BASE_PATH environment variable, matching the pattern used for PORT, VERBOSE, and HOST. This is useful for containerized deployments where env vars are preferred over CLI arguments. Changes: - Add BasePath property to ServerArgs record - Add --path-base CLI argument parsing - Add BASE_PATH environment variable support in Server constructor - Implement UsePathBase() middleware when BasePath is configured Closes #2829 Co-authored-by: Mikael Rinne <rorychatt@users.noreply.github.com>
…th main main already exposed ServerArgs.BasePath; the path-base feature branch added a second property with documentation. Merging both produced CS0102. Drop the redundant UsePathBase call that ran before forwarded headers; keep the single registration after UseForwardedHeaders with logging. Made-with: Cursor
Collaborator
|
Removed duplicate BasePath and UsePathBase after merge with main Drop the redundant UsePathBase call that ran before forwarded headers; keep the Tested out, it works |
Collaborator
DeployedDocs: https://ivy-staging-docs-2830.sliplane.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BasePathproperty toServerArgsrecord--path-baseCLI argument parsingBASE_PATHenvironment variable support in Server constructorUsePathBase()middleware when BasePath is configuredCloses #2829
Generated with Claude Code