Corrected fields type and cleanup

Author: Jez-A

lib/zexbox/jira_client.ex

@@ -44,11 +44,11 @@ defmodule Zexbox.JiraClient do
 
     client = build_client()
 
-    case jira_post(client, "/rest/api/3/search/jql", %{
-           "jql" => query,
-           "maxResults" => 50,
-           "fields" => ["key", "id", "self", "status", "summary"]
-         }) do
+    case jira_get(client, "/rest/api/3/issue/search",
+           jql: query,
+           maxResults: 50,
+           fields: ["key", "id", "self", "status", "summary"]
+         ) do
       {:ok, body} ->
         base_url = config(:jira_base_url, nil)
         issues = Map.get(body, "issues", [])
@@ -136,8 +136,6 @@ defmodule Zexbox.JiraClient do
     jira_post(client, "/rest/api/3/issue/#{issue_key}/comment", %{"body" => comment})
   end
 
-  # --- Private helpers ---
-
   defp find_transition(transitions, status_name) do
     case Enum.find(transitions, fn t ->
            to_name = get_in(t, ["to", "name"]) || ""

test/zexbox/jira_client_test.exs

@@ -36,7 +36,7 @@ defmodule Zexbox.JiraClientTest do
   describe "search_latest_issues/2" do
     test_with_mock "returns issues with url keys added on success", Req,
       new: fn _opts -> :mock_client end,
-      post: fn :mock_client, _opts ->
+      get: fn :mock_client, _opts ->
         {:ok,
          %{
            status: 200,
@@ -58,15 +58,15 @@ defmodule Zexbox.JiraClientTest do
 
     test_with_mock "returns empty list when no issues found", Req,
       new: fn _opts -> :mock_client end,
-      post: fn :mock_client, _opts ->
+      get: fn :mock_client, _opts ->
         {:ok, %{status: 200, body: %{"issues" => []}}}
       end do
       assert {:ok, []} = JiraClient.search_latest_issues("status = Open")
     end
 
     test_with_mock "returns error on non-2xx response", Req,
       new: fn _opts -> :mock_client end,
-      post: fn :mock_client, _opts ->
+      get: fn :mock_client, _opts ->
         {:ok, %{status: 401, body: %{"message" => "Unauthorized"}}}
       end do
       assert {:error, reason} = JiraClient.search_latest_issues("status = Open")
@@ -75,7 +75,7 @@ defmodule Zexbox.JiraClientTest do
 
     test_with_mock "returns error on request failure", Req,
       new: fn _opts -> :mock_client end,
-      post: fn :mock_client, _opts ->
+      get: fn :mock_client, _opts ->
         {:error, %{reason: :econnrefused}}
       end do
       assert {:error, _reason} = JiraClient.search_latest_issues("status = Open")