Refactor: simplify GetRepository function and remove refresh flag

Author: Graphixa

cmd/browse.go

@@ -29,8 +29,7 @@ Flags --scope (-s) and --force (-f) match fontget add (user/machine install scop
 			return err
 		}
 
-		refresh, _ := cmd.Flags().GetBool("refresh")
-		r, err := cmdutils.GetRepository(refresh, GetLogger())
+		r, err := cmdutils.GetRepository(GetLogger())
 		if err != nil {
 			return err
 		}
@@ -86,6 +85,4 @@ func init() {
 	rootCmd.AddCommand(browseCmd)
 	browseCmd.Flags().StringP("scope", "s", "", "Installation scope (user or machine)")
 	browseCmd.Flags().BoolP("force", "f", false, "Force installation even if font is already installed")
-	browseCmd.Flags().Bool("refresh", false, "Force refresh of font manifest before browse")
-	_ = browseCmd.Flags().MarkHidden("refresh")
 }

cmd/info.go

@@ -94,7 +94,7 @@ Use --license to show only license information.`,
 
 		// Get repository (using cached manifest)
 		output.GetVerbose().Info("Initializing repository for font lookup")
-		r, err := cmdutils.GetRepository(false, GetLogger())
+		r, err := cmdutils.GetRepository(GetLogger())
 		if err != nil {
 			return err
 		}

cmd/integration_test.go

@@ -121,43 +121,25 @@ func TestGetRepository_Integration(t *testing.T) {
 		t.Fatalf("Failed to initialize manifest: %v", err)
 	}
 
-	tests := []struct {
-		name    string
-		refresh bool
-	}{
-		{
-			name:    "get repository without refresh",
-			refresh: false,
-		},
-		{
-			name:    "get repository with refresh",
-			refresh: true,
-		},
-	}
+	repo, err := cmdutils.GetRepository(GetLogger())
 
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			repo, err := cmdutils.GetRepository(tt.refresh, GetLogger())
-
-			if err != nil {
-				t.Errorf("getRepository() unexpected error: %v", err)
-				return
-			}
+	if err != nil {
+		t.Errorf("getRepository() unexpected error: %v", err)
+		return
+	}
 
-			if repo == nil {
-				t.Errorf("getRepository() returned nil repository")
-				return
-			}
+	if repo == nil {
+		t.Errorf("getRepository() returned nil repository")
+		return
+	}
 
-			// Verify repository is usable
-			manifest, err := repo.GetManifest()
-			if err != nil {
-				t.Errorf("getRepository() returned repository that failed to get manifest: %v", err)
-			}
-			if manifest == nil {
-				t.Errorf("getRepository() returned repository with nil manifest")
-			}
-		})
+	// Verify repository is usable
+	manifest, err := repo.GetManifest()
+	if err != nil {
+		t.Errorf("getRepository() returned repository that failed to get manifest: %v", err)
+	}
+	if manifest == nil {
+		t.Errorf("getRepository() returned repository with nil manifest")
 	}
 }
 

cmd/search.go

@@ -194,7 +194,6 @@ Use -s without a value to list sources.`,
 		// Get arguments (already validated by Args function)
 		category, _ := cmd.Flags().GetString("category")
 		source, _ := cmd.Flags().GetString("source")
-		refresh, _ := cmd.Flags().GetBool("refresh")
 		var query string
 		if len(args) > 0 {
 			query = args[0]
@@ -207,7 +206,7 @@ Use -s without a value to list sources.`,
 		}
 
 		// Log search parameters (always log to file)
-		GetLogger().Info("Search parameters - Query: %s, Category: %s, Source: %s, Refresh: %v", query, category, source, refresh)
+		GetLogger().Info("Search parameters - Query: %s, Category: %s, Source: %s", query, category, source)
 
 		// Handle category-only mode (show all categories) - early return
 		// Check if category flag was provided but no value was given (NoOptDefVal = "list")
@@ -252,15 +251,14 @@ Use -s without a value to list sources.`,
 		}
 
 		// Verbose-level information for users - show operational details
-		output.GetVerbose().Info("Search parameters - Query: %s, Category: %s, Source: %s, Refresh: %v", query, category, source, refresh)
+		output.GetVerbose().Info("Search parameters - Query: %s, Category: %s, Source: %s", query, category, source)
 		// Verbose section ends with blank line per spacing framework (only if verbose was shown)
 		if output.IsVerboseOutputEnabled() {
 			fmt.Println()
 		}
-		output.GetDebug().State("Starting font search with parameters: query='%s', category='%s', source='%s', refresh=%v", query, category, source, refresh)
+		output.GetDebug().State("Starting font search with parameters: query='%s', category='%s', source='%s'", query, category, source)
 
-		// Get repository with optional refresh
-		r, err := cmdutils.GetRepository(refresh, GetLogger())
+		r, err := cmdutils.GetRepository(GetLogger())
 		if err != nil {
 			return err
 		}
@@ -510,10 +508,6 @@ func init() {
 	searchCmd.Flags().StringP("source", "s", "", "Filter by source (short ID like \"google\", \"nerd\", \"squirrel\" or full name like \"Google Fonts\")")
 	searchCmd.Flags().Lookup("source").NoOptDefVal = "list"
 
-	// Hidden flag for development/testing only
-	searchCmd.Flags().Bool("refresh", false, "Force refresh of font manifest before search")
-	searchCmd.Flags().MarkHidden("refresh")
-
 	// Helper function for category completion (shared by both short and long flags)
 	categoryCompletionFunc := func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 		r, err := repo.GetRepositoryForShellCompletion()

docs/development/guidelines/codebase-layout-guidelines.md

@@ -351,7 +351,7 @@ func SortSources(sources []SourceItem) {
 
 ```go
 // internal/cmdutils/repository.go
-func GetRepository(refresh bool, logger Logger) (*repo.Repository, error) {
+func GetRepository(logger Logger) (*repo.Repository, error) {
     // CLI-specific: logging, error formatting
     r, err := repo.GetRepository() // Business logic in repo package
     if err != nil {

internal/cmdutils/repository.go

@@ -7,28 +7,17 @@ import (
 	"fontget/internal/repo"
 )
 
-// GetRepository gets the font repository with optional refresh.
-// If refresh is true, forces a refresh of the font manifest.
+// GetRepository gets the font repository (standard caching/refresh policy in repo).
 // Returns standardized error handling for repository initialization.
 //
 // logger can be nil (for testing or when logging is not needed).
 //
 // NOTE: This function is tested via integration tests (see cmd/integration_test.go)
 // because it depends on package-level repo functions that are difficult to mock.
-func GetRepository(refresh bool, logger Logger) (*repo.Repository, error) {
-	var r *repo.Repository
-	var err error
-
-	if refresh {
-		// Force refresh of font manifest before use
-		output.GetVerbose().Info("Forcing refresh of font manifest")
-		output.GetDebug().State("Using GetRepositoryWithRefresh() to force source updates")
-		r, err = repo.GetRepositoryWithRefresh()
-	} else {
-		output.GetVerbose().Info("Using cached font manifest")
-		output.GetDebug().State("Using GetRepository() with cached sources")
-		r, err = repo.GetRepository()
-	}
+func GetRepository(logger Logger) (*repo.Repository, error) {
+	output.GetVerbose().Info("Loading font repository")
+	output.GetDebug().State("Calling repo.GetRepository()")
+	r, err := repo.GetRepository()
 
 	if err != nil {
 		if logger != nil {