Skip to content

Commit 8eadd43

Browse files
committed
make onClick area larger + nits
1 parent c07ad47 commit 8eadd43

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

app/src/main/java/app/attestation/auditor/AttestationActivity.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -343,15 +343,19 @@ private void refreshAuditeeList(List<String> auditees) {
343343
Collections.sort(auditees);
344344
for (final String auditee : auditees) {
345345
auditeeListLabel.setText(R.string.paired_auditees_list);
346-
final View view = getLayoutInflater().inflate(R.layout.content_auditee_fingerprint, auditeesContainer, false);
347-
final TextView fingerprintHexField = view.findViewById(R.id.auditee_fingerprint_hex);
346+
final View fingerprintEntryItem = getLayoutInflater().inflate(
347+
R.layout.content_auditee_fingerprint,
348+
auditeesContainer,
349+
false
350+
);
351+
final TextView fingerprintHexField = fingerprintEntryItem.findViewById(R.id.auditee_fingerprint_hex);
348352
fingerprintHexField.setText(auditee);
349-
fingerprintHexField.setOnClickListener(v -> {
353+
fingerprintEntryItem.setOnClickListener(v -> {
350354
final Intent inspectAuditeeIntent = new Intent(this, InspectAuditeeActivity.class);
351355
inspectAuditeeIntent.putExtra(InspectAuditeeActivity.INTENT_KEY_FINGERPRINT, auditee);
352356
startActivity(inspectAuditeeIntent);
353357
});
354-
auditeesContainer.addView(view);
358+
auditeesContainer.addView(fingerprintEntryItem);
355359
}
356360
}
357361
private void runAuditor() {

app/src/main/java/app/attestation/auditor/InspectAuditeeActivity.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class InspectAuditeeActivity extends AppCompatActivity {
1414

1515
private static final String TAG = "InspectAuditeeActivity";
1616

17-
public static final String INTENT_KEY_FINGERPRINT = "fingerprintHex";
17+
public static final String INTENT_KEY_FINGERPRINT = "fingerprint_hex";
1818

1919
private void addSummaryField(final String fieldName, final String fieldValue) {
2020
final TableLayout summaryContainer = findViewById(R.id.summary);
@@ -36,16 +36,11 @@ protected void onCreate(Bundle savedInstanceState) {
3636
Log.e(TAG, "auditee fingerprint not provided");
3737
return;
3838
}
39-
addSummaryField("fingerprint", fingerprint_hex);
40-
4139
final AttestationProtocol.AuditeeSummary summary = AttestationProtocol.getAuditorSummary(
4240
this,
4341
fingerprint_hex
4442
);
45-
if (summary == null) {
46-
Log.e(TAG,"auditee was not found");
47-
return;
48-
}
43+
addSummaryField("fingerprint", fingerprint_hex);
4944
addSummaryField("first verified", new Date(summary.verifiedTimeFirst()).toString());
5045
addSummaryField("last verified", new Date(summary.verifiedTimeLast()).toString());
5146
addSummaryField("verified boot key", summary.verifiedBootKey());

app/src/main/res/layout/content_auditee_fingerprint.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<com.google.android.material.textview.MaterialTextView
1010
style="@style/TextAppearance.Material3.LabelLarge"
1111
android:id="@+id/auditee_fingerprint_hex"
12-
android:layout_width="wrap_content"
12+
android:layout_width="match_parent"
1313
android:layout_height="wrap_content"
1414
android:layout_margin="4dp"
1515
android:maxLines="100"

0 commit comments

Comments
 (0)