fix: improve error handling in test scripts

- Show HTTP error codes and response bodies instead of silent failures
- Move token fetch outside polling loop in watch-status.sh
- Distinguish 401/403 auth errors from 404 not-found in watch-status.sh
- Document flat JSON limitation in write-firestore-doc.sh

Author: cabljac

.skills/test-extension/scripts/delete-firestore-doc.sh

@@ -14,7 +14,13 @@ ACCESS_TOKEN=$(gcloud auth application-default print-access-token 2>/dev/null ||
 BASE_URL="https://firestore.googleapis.com/v1/projects/${PROJECT_ID}/databases/(default)/documents"
 
 echo "Deleting document: ${DOC_PATH}"
-curl -sf -X DELETE "${BASE_URL}/${DOC_PATH}" \
-  -H "Authorization: Bearer ${ACCESS_TOKEN}" > /dev/null
+
+HTTP_CODE=$(curl -s -o /dev/null -w "%{http_code}" -X DELETE "${BASE_URL}/${DOC_PATH}" \
+  -H "Authorization: Bearer ${ACCESS_TOKEN}")
+
+if [ "$HTTP_CODE" -ge 400 ] 2>/dev/null; then
+  echo "ERROR: Firestore API returned HTTP ${HTTP_CODE}" >&2
+  exit 1
+fi
 
 echo "Document deleted."

.skills/test-extension/scripts/read-firestore-doc.sh

@@ -19,10 +19,20 @@ SEGMENT_COUNT=$(echo "$DOC_PATH" | tr '/' '\n' | wc -l | tr -d ' ')
 
 if [ $((SEGMENT_COUNT % 2)) -eq 1 ]; then
   echo "Listing documents in: ${DOC_PATH}"
-  curl -sf "${BASE_URL}/${DOC_PATH}" \
-    -H "Authorization: Bearer ${ACCESS_TOKEN}" | jq .
 else
   echo "Reading document: ${DOC_PATH}"
-  curl -sf "${BASE_URL}/${DOC_PATH}" \
-    -H "Authorization: Bearer ${ACCESS_TOKEN}" | jq .
 fi
+
+RESPONSE=$(curl -s -w "\n%{http_code}" "${BASE_URL}/${DOC_PATH}" \
+  -H "Authorization: Bearer ${ACCESS_TOKEN}")
+
+HTTP_CODE=$(echo "$RESPONSE" | tail -1)
+BODY=$(echo "$RESPONSE" | sed '$d')
+
+if [ "$HTTP_CODE" -ge 400 ] 2>/dev/null; then
+  echo "ERROR: Firestore API returned HTTP ${HTTP_CODE}" >&2
+  echo "$BODY" | jq . 2>/dev/null || echo "$BODY" >&2
+  exit 1
+fi
+
+echo "$BODY" | jq .

.skills/test-extension/scripts/watch-status.sh

@@ -13,28 +13,43 @@ TIMEOUT="${3:-60}"
 PROJECT_ID="${PROJECT_ID:?Set PROJECT_ID environment variable}"
 
 BASE_URL="https://firestore.googleapis.com/v1/projects/${PROJECT_ID}/databases/(default)/documents"
+ACCESS_TOKEN=$(gcloud auth application-default print-access-token 2>/dev/null || gcloud auth print-access-token)
 
 echo "Watching ${DOC_PATH} for status.state=${TARGET_STATE} (timeout: ${TIMEOUT}s)..."
 
 elapsed=0
 while [ $elapsed -lt "$TIMEOUT" ]; do
-  ACCESS_TOKEN=$(gcloud auth application-default print-access-token 2>/dev/null || gcloud auth print-access-token)
+  RESPONSE=$(curl -s -w "\n%{http_code}" "${BASE_URL}/${DOC_PATH}" \
+    -H "Authorization: Bearer ${ACCESS_TOKEN}")
 
-  RESPONSE=$(curl -sf "${BASE_URL}/${DOC_PATH}" \
-    -H "Authorization: Bearer ${ACCESS_TOKEN}" 2>/dev/null || echo "{}")
+  HTTP_CODE=$(echo "$RESPONSE" | tail -1)
+  BODY=$(echo "$RESPONSE" | sed '$d')
 
-  STATE=$(echo "$RESPONSE" | jq -r '.fields.status.mapValue.fields.state.stringValue // empty' 2>/dev/null)
+  if [ "$HTTP_CODE" = "401" ] || [ "$HTTP_CODE" = "403" ]; then
+    echo "ERROR: Authentication failed (HTTP ${HTTP_CODE}). Check gcloud auth." >&2
+    echo "$BODY" | jq . 2>/dev/null || echo "$BODY" >&2
+    exit 1
+  fi
+
+  if [ "$HTTP_CODE" = "404" ]; then
+    echo "  [${elapsed}s] Document not found yet"
+    sleep 2
+    elapsed=$((elapsed + 2))
+    continue
+  fi
+
+  STATE=$(echo "$BODY" | jq -r '.fields.status.mapValue.fields.state.stringValue // empty' 2>/dev/null)
 
   if [ "$STATE" = "$TARGET_STATE" ]; then
     echo "Status reached: ${TARGET_STATE} (after ${elapsed}s)"
-    echo "$RESPONSE" | jq .
+    echo "$BODY" | jq .
     exit 0
   fi
 
   if [ "$STATE" = "ERRORED" ] && [ "$TARGET_STATE" != "ERRORED" ]; then
-    ERROR_MSG=$(echo "$RESPONSE" | jq -r '.fields.status.mapValue.fields.error.stringValue // "unknown error"' 2>/dev/null)
+    ERROR_MSG=$(echo "$BODY" | jq -r '.fields.status.mapValue.fields.error.stringValue // "unknown error"' 2>/dev/null)
     echo "ERROR: Extension errored after ${elapsed}s: ${ERROR_MSG}"
-    echo "$RESPONSE" | jq .
+    echo "$BODY" | jq .
     exit 1
   fi
 

.skills/test-extension/scripts/write-firestore-doc.sh

@@ -6,6 +6,9 @@ set -euo pipefail
 #
 # Writes a document to Firestore in the target project. JSON values are
 # converted to Firestore field format automatically.
+# Supports flat JSON with string, number, boolean, and null values.
+# Nested objects and arrays are stringified — use the Firestore REST API
+# directly if you need complex nested structures.
 # Requires: PROJECT_ID env var, gcloud auth (application-default credentials)
 
 COLLECTION="${1:?Usage: write-firestore-doc.sh <collection> '<json>'}"
@@ -33,13 +36,22 @@ FIELDS=$(echo "$JSON_DATA" | jq '{
   }) | from_entries)
 }')
 
-RESPONSE=$(curl -sf -X POST "${BASE_URL}/${COLLECTION}" \
+RESPONSE=$(curl -s -w "\n%{http_code}" -X POST "${BASE_URL}/${COLLECTION}" \
   -H "Authorization: Bearer ${ACCESS_TOKEN}" \
   -H "Content-Type: application/json" \
   -d "$FIELDS")
 
-DOC_NAME=$(echo "$RESPONSE" | jq -r '.name')
+HTTP_CODE=$(echo "$RESPONSE" | tail -1)
+BODY=$(echo "$RESPONSE" | sed '$d')
+
+if [ "$HTTP_CODE" -ge 400 ] 2>/dev/null; then
+  echo "ERROR: Firestore API returned HTTP ${HTTP_CODE}" >&2
+  echo "$BODY" | jq . 2>/dev/null || echo "$BODY" >&2
+  exit 1
+fi
+
+DOC_NAME=$(echo "$BODY" | jq -r '.name')
 DOC_ID=$(echo "$DOC_NAME" | rev | cut -d'/' -f1 | rev)
 
 echo "Document created: ${COLLECTION}/${DOC_ID}"
-echo "$RESPONSE" | jq .
+echo "$BODY" | jq .