Skip to content

GiphyDialogFragment's list not playing all frames delays #164

Description

@perracodex

Just by chance while testing different GIFs, I've found one which has all frames with a delay at 80ms, except for the last frame which is set to 480ms.
In Giphy's web site the GIF in question plays correctly including taking into account the last frame delay, yet in the GiphyDialogFragment's list seems the last frame delay is ignored giving the impression that it animates faster.

The actual GIF is next:

https://giphy.com/gifs/imoji-laughing-3ohzdQJJ2JGvMSYvdu

Although is a minimal issue, I wanted to point it out just in case.

Update:
Found a few more GIFs where the last frame has a longer delay, but the dialog preview doesn't honor it.
This one has a 0 delay per frame and a the last with with 3000ms. The GiphyDialogFragment correctly assumes 100ms for the 0 delay frames, yet it ignores the last 3000ms frame. Giphy's webside honors the delay:

https://giphy.com/stickers/cedars-sinai-transparent-abizFdsnUSFfa5qOEm

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions