Bug fixes

- Fixed bug causing some clouds to pop out of view if startAnimation() called before view was drawn
- Refactored app activity

Author: Gerard

app/src/main/java/com/gerardbradshaw/cloudview/MainActivity.kt

@@ -33,7 +33,45 @@ class MainActivity : AppCompatActivity() {
     initViewDefaults()
     initListeners()
 
+    minSizeView.text = cloudView.minCloudSize.toString()
+    maxSizeView.text = cloudView.maxCloudSize.toString()
+
+    cloudView.startAnimation()
+  }
+
+  private fun locateViews() {
+    cloudView = findViewById(R.id.cloud_view)
+
+    cloudCountSeekBar = findViewById(R.id.cloud_count_seek_bar)
+    cloudCountView = findViewById(R.id.cloud_count_text_view)
+
+    minSizeSeekBar = findViewById(R.id.min_size_seek_bar)
+    minSizeView = findViewById(R.id.min_size_text_view)
+
+    maxSizeSeekBar = findViewById(R.id.max_size_seek_bar)
+    maxSizeView = findViewById(R.id.max_size_text_view)
+
+    passTimeEditText = findViewById(R.id.pass_time_edit_text)
+    varianceTimeEditText = findViewById(R.id.pass_variance_edit_text)
+  }
 
+  private fun initViewDefaults() {
+    cloudView.setDefaults()
+
+    cloudCountSeekBar.progress = cloudView.cloudCount
+    cloudCountView.text = "${cloudView.cloudCount}"
+
+    minSizeSeekBar.progress = cloudView.minCloudSize
+    minSizeView.text = "${cloudView.minCloudSize}"
+
+    maxSizeSeekBar.progress = cloudView.maxCloudSize
+    maxSizeView.text = "${cloudView.maxCloudSize}"
+
+    passTimeEditText.hint = "${cloudView.basePassTimeMs}"
+    varianceTimeEditText.hint = "${cloudView.passTimeVarianceMs }"
+  }
+
+  private fun initListeners() {
     cloudCountSeekBar.setOnSeekBarChangeListener(object : SeekBar.OnSeekBarChangeListener {
       override fun onProgressChanged(seekBar: SeekBar?, progress: Int, fromUser: Boolean) {
         cloudCountView.text = "$progress"
@@ -47,10 +85,6 @@ class MainActivity : AppCompatActivity() {
       }
     })
 
-
-    minSizeView.text = cloudView.minCloudSize.toString()
-    maxSizeView.text = cloudView.maxCloudSize.toString()
-
     findViewById<Button>(R.id.start_button).setOnClickListener {
       cloudView.startAnimation()
     }
@@ -115,42 +149,6 @@ class MainActivity : AppCompatActivity() {
     })
   }
 
-  private fun locateViews() {
-    cloudView = findViewById(R.id.cloud_view)
-
-    cloudCountSeekBar = findViewById(R.id.cloud_count_seek_bar)
-    cloudCountView = findViewById(R.id.cloud_count_text_view)
-
-    minSizeSeekBar = findViewById(R.id.min_size_seek_bar)
-    minSizeView = findViewById(R.id.min_size_text_view)
-
-    maxSizeSeekBar = findViewById(R.id.max_size_seek_bar)
-    maxSizeView = findViewById(R.id.max_size_text_view)
-
-    passTimeEditText = findViewById(R.id.pass_time_edit_text)
-    varianceTimeEditText = findViewById(R.id.pass_variance_edit_text)
-  }
-
-  private fun initViewDefaults() {
-    cloudView.setDefaults()
-
-    cloudCountSeekBar.progress = cloudView.cloudCount
-    cloudCountView.text = "${cloudView.cloudCount}"
-
-    minSizeSeekBar.progress = cloudView.minCloudSize
-    minSizeView.text = "${cloudView.minCloudSize}"
-
-    maxSizeSeekBar.progress = cloudView.maxCloudSize
-    maxSizeView.text = "${cloudView.maxCloudSize}"
-
-    passTimeEditText.hint = "${cloudView.basePassTimeMs}"
-    varianceTimeEditText.hint = "${cloudView.passTimeVarianceMs }"
-  }
-
-  private fun initListeners() {
-
-  }
-
   companion object {
     private const val TAG = "GGG MainActivity"
   }

app/src/main/res/layout/activity_main.xml

@@ -62,8 +62,8 @@
             <SeekBar
                 android:id="@+id/min_size_seek_bar"
                 android:layout_width="0dp"
-                android:min="25"
-                android:max="100"
+                android:min="200"
+                android:max="400"
                 android:layout_weight="1"
                 android:layout_height="wrap_content" />
 
@@ -88,7 +88,7 @@
             <SeekBar
                 android:id="@+id/max_size_seek_bar"
                 android:layout_width="0dp"
-                android:min="101"
+                android:min="400"
                 android:max="500"
                 android:layout_weight="1"
                 android:layout_height="wrap_content" />

library/build.gradle

@@ -9,7 +9,7 @@ android {
     buildToolsVersion "30.0.3"
 
     defaultConfig {
-        minSdkVersion 22
+        minSdkVersion 21
         targetSdkVersion 30
         versionCode 1
         versionName "1.0"