We inherited these Make.package files from AMReX but we always manually include all of the *.cpp and *.hpp files in each directory in them anyway so we could just remove them and automatically just include all *.cpp and *.hpp files in all of the directories we include. I think this is what we do in GRChombo.
In AMReX, there's more of a point to it as they have some bits where files are conditionally included e.g. here:
ifeq ($(USE_PARTICLES), TRUE)
CEXE_headers += AMReX_AmrParGDB.H AMReX_AmrParticles.H
endif
We don't ever do this and I don't think we will in the future. If we still want to keep Make.package files, we should enforce (in CI) that all source files are present somewhere in them and they are formatted consistently.
Thanks @SamuelBrady for the suggestion of getting rid of them.
We inherited these
Make.packagefiles from AMReX but we always manually include all of the*.cppand*.hppfiles in each directory in them anyway so we could just remove them and automatically just include all*.cppand*.hppfiles in all of the directories we include. I think this is what we do in GRChombo.In AMReX, there's more of a point to it as they have some bits where files are conditionally included e.g. here:
We don't ever do this and I don't think we will in the future. If we still want to keep
Make.packagefiles, we should enforce (in CI) that all source files are present somewhere in them and they are formatted consistently.Thanks @SamuelBrady for the suggestion of getting rid of them.