Skip to content

Commit 3082998

Browse files
Include Version Number in Release Artifacts (#168)
* Include Version Number in Release Artifacts * update the plugin to handle the change * Remove print statements --------- Co-authored-by: Nathan Lovato <12694995+NathanLovato@users.noreply.github.com>
1 parent 8429bbe commit 3082998

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

.github/workflows/release.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,22 @@ jobs:
1616
include:
1717
- target: x86_64-unknown-linux-gnu
1818
os: ubuntu-latest
19-
name: gdscript-formatter-linux-x86_64
19+
name: gdscript-formatter-${{ github.ref_name }}-linux-x86_64
2020
- target: aarch64-unknown-linux-gnu
2121
os: ubuntu-latest
22-
name: gdscript-formatter-linux-aarch64
22+
name: gdscript-formatter-${{ github.ref_name }}-linux-aarch64
2323
- target: x86_64-apple-darwin
2424
os: macos-latest
25-
name: gdscript-formatter-macos-x86_64
25+
name: gdscript-formatter-${{ github.ref_name }}-macos-x86_64
2626
- target: aarch64-apple-darwin
2727
os: macos-latest
28-
name: gdscript-formatter-macos-aarch64
28+
name: gdscript-formatter-${{ github.ref_name }}-macos-aarch64
2929
- target: x86_64-pc-windows-msvc
3030
os: windows-latest
31-
name: gdscript-formatter-windows-x86_64.exe
31+
name: gdscript-formatter-${{ github.ref_name }}-windows-x86_64.exe
3232
- target: aarch64-pc-windows-msvc
3333
os: windows-latest
34-
name: gdscript-formatter-windows-aarch64.exe
34+
name: gdscript-formatter-${{ github.ref_name }}-windows-aarch64.exe
3535

3636
runs-on: ${{ matrix.os }}
3737
permissions:
@@ -97,14 +97,14 @@ jobs:
9797

9898
- name: Create godot-addon.zip
9999
run: |
100-
zip -r godot-addon.zip addons/
100+
zip -r godot-addon-${{ github.ref_name }}.zip addons/
101101
shell: bash
102102

103103
- name: Upload artifact
104104
uses: actions/upload-artifact@v4
105105
with:
106-
name: godot-addon
107-
path: godot-addon.zip
106+
name: godot-addon-${{ github.ref_name }}
107+
path: godot-addon-${{ github.ref_name }}.zip
108108
if-no-files-found: error
109109

110110
publish-release:

addons/GDQuest_GDScript_formatter/install_and_update.gd

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ func _process_response_latest_release(body: PackedByteArray) -> void:
6969
print("GDScript Formatter release information loaded successfully")
7070

7171
var assets = json["assets"]
72-
var download_url := _find_matching_asset(assets)
72+
var tag = json["tag_name"]
73+
var download_url := _find_matching_asset(assets, tag)
7374

7475
if download_url.is_empty():
7576
var error_message := "No matching binary found for current platform"
@@ -148,12 +149,12 @@ func _get_platform_info() -> Dictionary:
148149
return platform_info
149150

150151

151-
func _find_matching_asset(assets: Array) -> String:
152+
func _find_matching_asset(assets: Array, tag: String) -> String:
152153
var platform_info := _get_platform_info()
153154
if platform_info.is_empty():
154155
return ""
155156

156-
var expected_pattern := "gdscript-formatter-%s-%s" % [platform_info["os"], platform_info["architecture"]]
157+
var expected_pattern := "gdscript-formatter-%s-%s-%s" % [tag, platform_info["os"], platform_info["architecture"]]
157158
if platform_info["os"] == "windows":
158159
expected_pattern += ".exe"
159160
expected_pattern += ".zip"

0 commit comments

Comments
 (0)