Skip to content

Build error: Collections.vala: error: use `new' operator to create new objects #467

@barracuda156

Description

@barracuda156

Describe the bug
Build with vala 0.56.19 fails.

To Reproduce
Run the build.

Expected behavior
Build should succeed.

Log

[98/146] valac --depfile src/font-manager/font-manager.depfile -C --debug -D HAVE_ADWAITA -D HAVE_LIBARCHIVE --pkg libarchive --pkg libadwaita-1 --pkg libxml-2.0 --pkg sqlite3 --pkg json-glib-1.0 --pkg gtk4 --pkg gmodule-2.0 --pkg gio-unix-2.0 --pkg gio-2.0 --pkg glib-2.0 --target-glib 2.64 --color=always --directory src/font-manager/font-manager.p --basedir ../font-manager-0.9.4/src/font-manager --gresources=../font-manager-0.9.4/src/font-manager/font-manager-gresources.xml --gresourcesdir=../font-manager-0.9.4/src/font-manager ../font-manager-0.9.4/config.vapi lib/font-manager.vapi ../font-manager-0.9.4/src/font-manager/Application.vala ../font-manager-0.9.4/src/font-manager/ArchiveManager.vala ../font-manager-0.9.4/src/font-manager/Browse.vala ../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala ../font-manager-0.9.4/src/font-manager/Cacheable.vala ../font-manager-0.9.4/src/font-manager/Categories.vala ../font-manager-0.9.4/src/font-manager/Collections.vala ../font-manager-0.9.4/src/font-manager/Compare.vala ../font-manager-0.9.4/src/font-manager/Controls.vala ../font-manager-0.9.4/src/font-manager/DatabaseProxy.vala ../font-manager-0.9.4/src/font-manager/Dialogs.vala ../font-manager-0.9.4/src/font-manager/FontList.vala ../font-manager-0.9.4/src/font-manager/FontModel.vala ../font-manager-0.9.4/src/font-manager/Library.vala ../font-manager-0.9.4/src/font-manager/MainPane.vala ../font-manager-0.9.4/src/font-manager/MainWindow.vala ../font-manager-0.9.4/src/font-manager/Orthographies.vala ../font-manager-0.9.4/src/font-manager/OrthographyList.vala ../font-manager-0.9.4/src/font-manager/Paned.vala ../font-manager-0.9.4/src/font-manager/SearchProvider.vala ../font-manager-0.9.4/src/font-manager/Sidebar.vala ../font-manager-0.9.4/src/font-manager/Utils.vala ../font-manager-0.9.4/src/font-manager/filters/Category.vala ../font-manager-0.9.4/src/font-manager/filters/Collection.vala ../font-manager-0.9.4/src/font-manager/filters/Disabled.vala ../font-manager-0.9.4/src/font-manager/filters/FontListFilter.vala ../font-manager-0.9.4/src/font-manager/filters/LanguageFilter.vala ../font-manager-0.9.4/src/font-manager/filters/Unsorted.vala ../font-manager-0.9.4/src/font-manager/filters/UserFonts.vala ../font-manager-0.9.4/src/font-manager/preferences/Desktop.vala ../font-manager-0.9.4/src/font-manager/preferences/Display.vala ../font-manager-0.9.4/src/font-manager/preferences/Preferences.vala ../font-manager-0.9.4/src/font-manager/preferences/Rendering.vala ../font-manager-0.9.4/src/font-manager/preferences/Substitutions.vala ../font-manager-0.9.4/src/font-manager/preferences/UserActions.vala ../font-manager-0.9.4/src/font-manager/preferences/UserInterface.vala ../font-manager-0.9.4/src/font-manager/preferences/UserSources.vala ../font-manager-0.9.4/src/font-manager/web/google/FontList.vala ../font-manager-0.9.4/src/font-manager/web/google/GoogleFonts.vala ../font-manager-0.9.4/src/font-manager/web/google/LanguageData.vala ../font-manager-0.9.4/src/font-manager/web/google/PreviewPage.vala ../font-manager-0.9.4/src/font-manager/web/google/Sidebar.vala ../font-manager-0.9.4/src/font-manager/web/google/WebFont.vala src/common/vala-common.vapi
FAILED: [code=1] src/font-manager/font-manager.p/Application.c src/font-manager/font-manager.p/ArchiveManager.c src/font-manager/font-manager.p/Browse.c src/font-manager/font-manager.p/BrowseTreeView.c src/font-manager/font-manager.p/Cacheable.c src/font-manager/font-manager.p/Categories.c src/font-manager/font-manager.p/Collections.c src/font-manager/font-manager.p/Compare.c src/font-manager/font-manager.p/Controls.c src/font-manager/font-manager.p/DatabaseProxy.c src/font-manager/font-manager.p/Dialogs.c src/font-manager/font-manager.p/FontList.c src/font-manager/font-manager.p/FontModel.c src/font-manager/font-manager.p/Library.c src/font-manager/font-manager.p/MainPane.c src/font-manager/font-manager.p/MainWindow.c src/font-manager/font-manager.p/Orthographies.c src/font-manager/font-manager.p/OrthographyList.c src/font-manager/font-manager.p/Paned.c src/font-manager/font-manager.p/SearchProvider.c src/font-manager/font-manager.p/Sidebar.c src/font-manager/font-manager.p/Utils.c src/font-manager/font-manager.p/filters/Category.c src/font-manager/font-manager.p/filters/Collection.c src/font-manager/font-manager.p/filters/Disabled.c src/font-manager/font-manager.p/filters/FontListFilter.c src/font-manager/font-manager.p/filters/LanguageFilter.c src/font-manager/font-manager.p/filters/Unsorted.c src/font-manager/font-manager.p/filters/UserFonts.c src/font-manager/font-manager.p/preferences/Desktop.c src/font-manager/font-manager.p/preferences/Display.c src/font-manager/font-manager.p/preferences/Preferences.c src/font-manager/font-manager.p/preferences/Rendering.c src/font-manager/font-manager.p/preferences/Substitutions.c src/font-manager/font-manager.p/preferences/UserActions.c src/font-manager/font-manager.p/preferences/UserInterface.c src/font-manager/font-manager.p/preferences/UserSources.c src/font-manager/font-manager.p/web/google/FontList.c src/font-manager/font-manager.p/web/google/GoogleFonts.c src/font-manager/font-manager.p/web/google/LanguageData.c src/font-manager/font-manager.p/web/google/PreviewPage.c src/font-manager/font-manager.p/web/google/Sidebar.c src/font-manager/font-manager.p/web/google/WebFont.c 
valac --depfile src/font-manager/font-manager.depfile -C --debug -D HAVE_ADWAITA -D HAVE_LIBARCHIVE --pkg libarchive --pkg libadwaita-1 --pkg libxml-2.0 --pkg sqlite3 --pkg json-glib-1.0 --pkg gtk4 --pkg gmodule-2.0 --pkg gio-unix-2.0 --pkg gio-2.0 --pkg glib-2.0 --target-glib 2.64 --color=always --directory src/font-manager/font-manager.p --basedir ../font-manager-0.9.4/src/font-manager --gresources=../font-manager-0.9.4/src/font-manager/font-manager-gresources.xml --gresourcesdir=../font-manager-0.9.4/src/font-manager ../font-manager-0.9.4/config.vapi lib/font-manager.vapi ../font-manager-0.9.4/src/font-manager/Application.vala ../font-manager-0.9.4/src/font-manager/ArchiveManager.vala ../font-manager-0.9.4/src/font-manager/Browse.vala ../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala ../font-manager-0.9.4/src/font-manager/Cacheable.vala ../font-manager-0.9.4/src/font-manager/Categories.vala ../font-manager-0.9.4/src/font-manager/Collections.vala ../font-manager-0.9.4/src/font-manager/Compare.vala ../font-manager-0.9.4/src/font-manager/Controls.vala ../font-manager-0.9.4/src/font-manager/DatabaseProxy.vala ../font-manager-0.9.4/src/font-manager/Dialogs.vala ../font-manager-0.9.4/src/font-manager/FontList.vala ../font-manager-0.9.4/src/font-manager/FontModel.vala ../font-manager-0.9.4/src/font-manager/Library.vala ../font-manager-0.9.4/src/font-manager/MainPane.vala ../font-manager-0.9.4/src/font-manager/MainWindow.vala ../font-manager-0.9.4/src/font-manager/Orthographies.vala ../font-manager-0.9.4/src/font-manager/OrthographyList.vala ../font-manager-0.9.4/src/font-manager/Paned.vala ../font-manager-0.9.4/src/font-manager/SearchProvider.vala ../font-manager-0.9.4/src/font-manager/Sidebar.vala ../font-manager-0.9.4/src/font-manager/Utils.vala ../font-manager-0.9.4/src/font-manager/filters/Category.vala ../font-manager-0.9.4/src/font-manager/filters/Collection.vala ../font-manager-0.9.4/src/font-manager/filters/Disabled.vala ../font-manager-0.9.4/src/font-manager/filters/FontListFilter.vala ../font-manager-0.9.4/src/font-manager/filters/LanguageFilter.vala ../font-manager-0.9.4/src/font-manager/filters/Unsorted.vala ../font-manager-0.9.4/src/font-manager/filters/UserFonts.vala ../font-manager-0.9.4/src/font-manager/preferences/Desktop.vala ../font-manager-0.9.4/src/font-manager/preferences/Display.vala ../font-manager-0.9.4/src/font-manager/preferences/Preferences.vala ../font-manager-0.9.4/src/font-manager/preferences/Rendering.vala ../font-manager-0.9.4/src/font-manager/preferences/Substitutions.vala ../font-manager-0.9.4/src/font-manager/preferences/UserActions.vala ../font-manager-0.9.4/src/font-manager/preferences/UserInterface.vala ../font-manager-0.9.4/src/font-manager/preferences/UserSources.vala ../font-manager-0.9.4/src/font-manager/web/google/FontList.vala ../font-manager-0.9.4/src/font-manager/web/google/GoogleFonts.vala ../font-manager-0.9.4/src/font-manager/web/google/LanguageData.vala ../font-manager-0.9.4/src/font-manager/web/google/PreviewPage.vala ../font-manager-0.9.4/src/font-manager/web/google/Sidebar.vala ../font-manager-0.9.4/src/font-manager/web/google/WebFont.vala src/common/vala-common.vapi
../font-manager-0.9.4/src/font-manager/Collections.vala:543.48-543.78: error: use `new' operator to create new objects
  543 |             var gtk_drag_icon = (Gtk.DragIcon) Gtk.DragIcon.get_for_drag(drag);
      |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
../font-manager-0.9.4/src/font-manager/FontList.vala:672.48-672.78: error: use `new' operator to create new objects
  672 |             var gtk_drag_icon = (Gtk.DragIcon) Gtk.DragIcon.get_for_drag(drag);
      |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:80.9-80.28: warning: `Gtk.TreeStore' has been deprecated since 4.10
   80 |         Gtk.TreeStore? store = null;
      |         ^~~~~~~~~~~~~~~~~~~~        
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:123.25-123.37: warning: `Gtk.TreeStore' has been deprecated since 4.10
  123 |             store = new Gtk.TreeStore(1, typeof(Json.Object));
      |                         ^~~~~~~~~~~~~                         
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:130.30-130.33: warning: `Gtk.TreeIter' has been deprecated since 4.10
  130 |                 Gtk.TreeIter iter;
      |                              ^~~~ 
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:140.34-140.43: warning: `Gtk.TreeIter' has been deprecated since 4.10
  140 |                     Gtk.TreeIter child_iter;
      |                                  ^~~~~~~~~~ 
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:151.30-151.54: warning: `Gtk.TreeViewColumn' has been deprecated since 4.10
  151 |         void cell_data_func (Gtk.TreeViewColumn layout,
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~ 
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:152.30-152.50: warning: `Gtk.CellRenderer' has been deprecated since 4.10
  152 |                              Gtk.CellRenderer cell,
      |                              ^~~~~~~~~~~~~~~~~~~~~ 
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:153.30-153.48: warning: `Gtk.TreeModel' has been deprecated since 4.10
  153 |                              Gtk.TreeModel model,
      |                              ^~~~~~~~~~~~~~~~~~~ 
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:154.30-154.50: warning: `Gtk.TreeIter' has been deprecated since 4.10
  154 |                              Gtk.TreeIter treeiter) {
      |                              ^~~~~~~~~~~~~~~~~~~~~   
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:42.40-42.63: warning: `Gtk.Widget.get_style_context' has been deprecated since 4.10
   42 |                 Gtk.StyleContext ctx = widget.get_style_context();
      |                                        ^~~~~~~~~~~~~~~~~~~~~~~~   
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:42.34-42.36: warning: `Gtk.StyleContext' has been deprecated since 4.10
   42 |                 Gtk.StyleContext ctx = widget.get_style_context();
      |                                  ^~~                              
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:52.17-52.42: warning: `Gtk.Snapshot.render_background' has been deprecated since 4.10
   52 |                 snapshot.render_background(ctx, a.x, a.y, a.width, a.height);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~                                   
../font-manager-0.9.4/src/font-manager/BrowseTreeView.vala:53.17-53.37: warning: `Gtk.Snapshot.render_frame' has been deprecated since 4.10
   53 |                 snapshot.render_frame(ctx, a.x, a.y, a.width, a.height);
      |                 ^~~~~~~~~~~~~~~~~~~~~                                   
../font-manager-0.9.4/src/font-manager/Browse.vala:427.45-427.48: warning: Argument 1: Cannot pass null to non-null parameter type
  427 |             var builder = new StringBuilder(null);
      |                                             ^~~~  
../font-manager-0.9.4/src/font-manager/preferences/Substitutions.vala:101.13-101.32: warning: `Gtk.Entry.set_completion' has been deprecated since 4.10
  101 |             entry.set_completion(get_family_completion());
      |             ^~~~~~~~~~~~~~~~~~~~                          
../font-manager-0.9.4/src/font-manager/preferences/Substitutions.vala:41.53-41.71: warning: `Gtk.EntryCompletion' has been deprecated since 4.10
   41 |         Gtk.EntryCompletion family_completion = new Gtk.EntryCompletion();
      |                                                     ^~~~~~~~~~~~~~~~~~~   
../font-manager-0.9.4/src/font-manager/preferences/Substitutions.vala:41.29-41.45: warning: `Gtk.EntryCompletion' has been deprecated since 4.10
   41 |         Gtk.EntryCompletion family_completion = new Gtk.EntryCompletion();
      |                             ^~~~~~~~~~~~~~~~~                             
../font-manager-0.9.4/src/font-manager/preferences/Substitutions.vala:24.5-24.51: warning: `Gtk.ListStore' has been deprecated since 4.10
   24 |     internal Gtk.ListStore? family_completion_model = null;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~        
../font-manager-0.9.4/src/font-manager/preferences/Substitutions.vala:28.43-28.55: warning: `Gtk.ListStore' has been deprecated since 4.10
   28 |             family_completion_model = new Gtk.ListStore(1, typeof(string));
      |                                           ^~~~~~~~~~~~~                    
../font-manager-0.9.4/src/font-manager/preferences/Substitutions.vala:32.30-32.33: warning: `Gtk.TreeIter' has been deprecated since 4.10
   32 |                 Gtk.TreeIter iter;
      |                              ^~~~ 
../font-manager-0.9.4/src/font-manager/preferences/Substitutions.vala:66.13-66.33: warning: `Gtk.Entry.set_completion' has been deprecated since 4.10
   66 |             target.set_completion(get_family_completion());
      |             ^~~~~~~~~~~~~~~~~~~~~                          
Compilation failed: 2 error(s), 20 warning(s)

System Information

  • OS: macOS 10.6.8
  • Font Manager version: 0.9.4
  • Font Manager installation method: MacPorts

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions