fix: Fix generateIdentitiesCacheKey

Author: fgiova

.github/workflows/pull-requests.yml

@@ -35,7 +35,7 @@ jobs:
         run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
 
       - name: Cache dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
           key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}

src/Utils/IdentitiesGenerator.php

@@ -37,6 +37,6 @@ public static function generateIdentitiesCacheKey(string $identifier, ?object $t
     {
         $hashedTraits = $traits !== null ? '.'.sha1(serialize($traits)) : '';
         $hashedIdentifier = sha1($identifier);
-        return 'Identity.'.$transient ? 'Transient' : ''.$hashedIdentifier.$hashedTraits;
+        return 'Identity.'.($transient ? 'Transient' : '').$hashedIdentifier.$hashedTraits;
     }
 }

tests/Engine/Unit/Utils/IdentitiesGeneratorTest.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types=1);
+
+namespace Engine\Unit\Utils;
+
+use Flagsmith\Utils\IdentitiesGenerator;
+use PHPUnit\Framework\TestCase;
+
+class IdentitiesGeneratorTest extends TestCase
+{
+
+    public function testGenerateIdentitiesCacheKey(): void
+    {
+        $identityId = 'test-identity-id';
+        $traits = (object) ['key' => 'value'];
+        $cacheKey = IdentitiesGenerator::generateIdentitiesCacheKey($identityId, $traits, null);
+
+        $this->assertStringContainsString('Identity.', $cacheKey);
+        $this->assertStringContainsString(sha1($identityId), $cacheKey);
+    }
+
+    public function testGenerateIdentitiesTransientCacheKey(): void
+    {
+        $identityId = 'test-identity-id';
+        $traits = (object) ['key' => 'value'];
+        $cacheKey = IdentitiesGenerator::generateIdentitiesCacheKey($identityId, $traits, true);
+
+        $this->assertStringContainsString('Identity.Transient', $cacheKey);
+        $this->assertStringContainsString(sha1($identityId), $cacheKey);
+    }
+}