Remove deviceToken if it’s too long

Author: Finb

database/bbolt.go

@@ -92,6 +92,15 @@ func (d *BboltDB) SaveDeviceTokenByKey(key, deviceToken string) (string, error)
 	return key, nil
 }
 
+// DeleteDeviceByKey delete device of specified key
+func (d *BboltDB) DeleteDeviceByKey(key string) error {
+	err := db.Update(func(tx *bbolt.Tx) error {
+		bucket := tx.Bucket([]byte(bucketName))
+		return bucket.Delete([]byte(key))
+	})
+	return err
+}
+
 // bboltSetup setup the bbolt database
 func bboltSetup(dataDir string) {
 	dbOnce.Do(func() {

database/database.go

@@ -5,5 +5,6 @@ type Database interface {
 	CountAll() (int, error)                                 //Get db records count
 	DeviceTokenByKey(key string) (string, error)            //Get specified device's token
 	SaveDeviceTokenByKey(key, token string) (string, error) //Create or update specified devices's token
+	DeleteDeviceByKey(key string) error                     //Delete specified device
 	Close() error                                           //Close the database
 }

database/envbase.go

@@ -30,6 +30,10 @@ func (d *EnvBase) SaveDeviceTokenByKey(key, token string) (string, error) {
 	return "nil", fmt.Errorf("device token is invalid")
 }
 
+func (d *EnvBase) DeleteDeviceByKey(key string) error {
+	return fmt.Errorf("not supported")
+}
+
 func (d *EnvBase) Close() error {
 	return nil
 }

database/membase.go

@@ -37,6 +37,14 @@ func (d *MemBase) SaveDeviceTokenByKey(key, token string) (string, error) {
 	return key, nil
 }
 
+func (d *MemBase) DeleteDeviceByKey(key string) error {
+	if key != "" && key != cacheKey {
+		return fmt.Errorf("key not found")
+	}
+	cacheDeviceToken = ""
+	return nil
+}
+
 func (d *MemBase) Close() error {
 	return nil
 }

database/mysql.go

@@ -73,6 +73,11 @@ func (d *MySQL) SaveDeviceTokenByKey(key, token string) (string, error) {
 	return key, nil
 }
 
+func (d *MySQL) DeleteDeviceByKey(key string) error {
+	_, err := mysqlDB.Exec("DELETE FROM `devices` WHERE `key`=?", key)
+	return err
+}
+
 func (d *MySQL) Close() error {
 	return mysqlDB.Close()
 }

route_push.go

@@ -260,6 +260,12 @@ func push(params map[string]interface{}) (int, error) {
 	if err != nil {
 		return 400, fmt.Errorf("failed to get device token: %v", err)
 	}
+
+	// Remove deviceToken if it’s too long, to clean up junk data.
+	if len(deviceToken) > 128 {
+		_ = db.DeleteDeviceByKey(msg.DeviceKey)
+	}
+
 	msg.DeviceToken = deviceToken
 
 	code, err := apns.Push(&msg)