Use atomic.Uint64 for test upload counter

Copilot · FiloSottile · Copilot · commit 2e9baeb61889 · 2026-03-18T18:29:04.000Z
Co-authored-by: FiloSottile &lt;1225294+FiloSottile@users.noreply.github.com&gt;
diff --git a/internal/ctlog/ctlog_test.go b/internal/ctlog/ctlog_test.go
@@ -125,7 +125,7 @@ func TestSequenceUploadCount(t *testing.T) {
 
 	var old uint64
 	uploads := func() uint64 {
-		new := tl.Config.Backend.(*MemoryBackend).uploads
+		new := tl.Config.Backend.(*MemoryBackend).uploads.Load()
 		n := new - old
 		old = new
 		return n
diff --git a/internal/ctlog/testlog_test.go b/internal/ctlog/testlog_test.go
@@ -440,7 +440,7 @@ type MemoryBackend struct {
 	imm map[string]bool
 	del map[string]bool
 
-	uploads uint64
+	uploads atomic.Uint64
 
 	UploadCallback func(key string, data []byte) (apply bool, err error)
 }
@@ -452,7 +452,7 @@ func NewMemoryBackend(t testing.TB) *MemoryBackend {
 }
 
 func (b *MemoryBackend) Upload(ctx context.Context, key string, data []byte, opts *ctlog.UploadOptions) error {
-	atomic.AddUint64(&b.uploads, 1)
+	b.uploads.Add(1)
 	// TODO: check key format is expected.
 	if len(data) == 0 && key != "_roots.pem" {
 		b.t.Errorf("uploaded key %q with empty data", key)

Original file line number	Diff line number	Diff line change
`@@ -440,7 +440,7 @@ type MemoryBackend struct {`
`440`	`440`	`imm map[string]bool`
`441`	`441`	`del map[string]bool`
`442`	`442`
`443`		`- uploads uint64`
	`443`	`+ uploads atomic.Uint64`
`444`	`444`
`445`	`445`	`UploadCallback func(key string, data []byte) (apply bool, err error)`
`446`	`446`	`}`
`@@ -452,7 +452,7 @@ func NewMemoryBackend(t testing.TB) *MemoryBackend {`
`452`	`452`	`}`
`453`	`453`
`454`	`454`	`func (b MemoryBackend) Upload(ctx context.Context, key string, data []byte, opts ctlog.UploadOptions) error {`
`455`		`- atomic.AddUint64(&b.uploads, 1)`
	`455`	`+ b.uploads.Add(1)`
`456`	`456`	`// TODO: check key format is expected.`
`457`	`457`	`if len(data) == 0 && key != "_roots.pem" {`
`458`	`458`	`b.t.Errorf("uploaded key %q with empty data", key)`