Fix plate pickup shaped reward in Overcooked - #195
Open
amacrutherford wants to merge 1 commit into
Open
Conversation
The plate pickup shaping reward never fired. Two bugs, both reported in #167: The "no plates on counters" check compared the entire 3D maze_map against OBJECT_TO_INDEX["plate"] (5) instead of isolating the object channel. That index is also COLOR_TO_INDEX["grey"], the colour of a wall, so every wall in every layout counted as a plate on a counter and the guard was always False. The "is this pickup useful" check counted plates in the acting agent's own inventory rather than across all agents, so one cooking pot would reward both agents for grabbing a plate. OvercookedV2 counts across all agents. Bob now also sees Alice's post-interact inventory, matching the fact that he already acts on the map she left behind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #167