This repository was archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Extensibility of PlatformProxyAdmin #101
Copy link
Copy link
Open
Labels
Description
Currently, the PlatformProxyAdmin provide premium service to the controller, and factory but does not consider future modules added to the v1 platform may need to be managed by the PlatformProxyAdmin.
motivation: The new StrategyControllerLens is proxied by a TransparentUpgradeableProxy which will have the PlatformProxyAdmin set as it's admin. But currently the deployment and initialization of that proxy must be done separately from the PlatformProxyAdmin. It would make sense that new platform modules are handled uniformly by the PlatformProxyAdmin hub.
For extensibility, the new version of the PlatformProxyAdmin will have
- a mapping to the contracts it services
- a "spawn" function populating the mapping and creating new proxies
- an external
calculateAddress - a sensible "getter" for the serviced proxies.
- backwards compatibility with the prior
PlatformProxyAdmin'scontrollerandfactory