Add module-configuration-file rule for Y128 guideline

Implement new ESLint rule to enforce John Papa's Y128 style guideline
for AngularJS module configuration files.

This rule ensures that module configuration (.config() calls) are placed
in separate files with a .config.js suffix, following the naming pattern:
- app.config.js for the main app module
- admin.config.js for an admin module
- Or simply config.js

The rule automatically skips test files (.spec.js and .test.js).

Files added:
- rules/module-configuration-file.js
- test/module-configuration-file.js
- examples/module-configuration-file.js
- Updated index.js to include rule in johnpapa config

Closes #52

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Emmanuel DEMEY <EmmanuelDemey@users.noreply.github.com>

Author: github-actions[bot]

examples/module-configuration-file.js

@@ -0,0 +1,38 @@
+
+// example - valid: true, filename: "app.config.js"
+angular.module('app').config(function($httpProvider) {
+    $httpProvider.interceptors.push('authInterceptor');
+});
+
+// example - valid: true, filename: "admin.config.js"
+angular.module('admin').config(function($routeProvider) {
+    $routeProvider.when('/admin', {
+        templateUrl: 'admin.html'
+    });
+});
+
+// example - valid: true, filename: "config.js"
+angular.module('myApp').config(function($logProvider) {
+    $logProvider.debugEnabled(true);
+});
+
+// example - valid: true, filename: "src/modules/users/users.config.js"
+angular.module('users').config(function($stateProvider) {
+    $stateProvider.state('users', {
+        url: '/users',
+        templateUrl: 'users.html'
+    });
+});
+
+// example - valid: false, filename: "app.js", errorMessage: "Module configuration should be in a separate file with a .config.js suffix"
+angular.module('app').config(function($httpProvider) {
+    $httpProvider.interceptors.push('authInterceptor');
+});
+
+// example - valid: false, filename: "app.module.js", errorMessage: "Module configuration should be in a separate file with a .config.js suffix"
+angular.module('app').config(function($routeProvider) {
+    $routeProvider.otherwise('/home');
+});
+
+// example - valid: false, filename: "admin.js", errorMessage: "Module configuration should be in a separate file with a .config.js suffix"
+angular.module('admin').config(configFunction);

index.js

@@ -38,6 +38,7 @@ module.exports = {
                 'angular/filter-name': 2,
                 'angular/function-type': 2,
                 'angular/interval-service': 2,
+                'angular/module-configuration-file': 2,
                 'angular/module-getter': 2,
                 'angular/module-name': 2,
                 'angular/module-setter': 2,

rules/module-configuration-file.js

@@ -0,0 +1,58 @@
+/**
+ * require module configuration to be in separate files
+ *
+ * Separate configuration for a module into its own file named after the module.
+ * A configuration file for the main `app` module is named `app.config.js` (or simply `config.js`).
+ * A configuration for a module named `admin.module.js` is named `admin.config.js`.
+ *
+ * @styleguideReference {johnpapa} `y128` Modules - Configuration
+ * @version 0.16.0
+ * @category conventions
+ * @sinceAngularVersion 1.x
+ */
+'use strict';
+
+var path = require('path');
+var utils = require('./utils/utils');
+
+module.exports = {
+    meta: {
+        docs: {
+            url: 'https://github.com/Gillespie59/eslint-plugin-angular/blob/master/docs/rules/module-configuration-file.md'
+        },
+        schema: []
+    },
+    create: function(context) {
+        return {
+            CallExpression: function(node) {
+                // Check if this is a .config() call on an Angular module
+                if (!utils.isMemberExpression(node.callee)) {
+                    return;
+                }
+
+                if (node.callee.property.name !== 'config') {
+                    return;
+                }
+
+                // Check if this is called on an angular.module() getter
+                var callee = node.callee.object;
+                if (!utils.isAngularModuleGetter(callee) && !utils.isMemberExpression(callee)) {
+                    return;
+                }
+
+                // Get the filename
+                var filename = path.basename(context.getFilename());
+
+                // Skip if this is a test file
+                if (filename.indexOf('.spec.') !== -1 || filename.indexOf('.test.') !== -1) {
+                    return;
+                }
+
+                // Check if the filename follows the .config.js pattern
+                if (!filename.endsWith('.config.js')) {
+                    context.report(node, 'Module configuration should be in a separate file with a .config.js suffix');
+                }
+            }
+        };
+    }
+};

test/module-configuration-file.js

@@ -0,0 +1,94 @@
+'use strict';
+
+// ------------------------------------------------------------------------------
+// Requirements
+// ------------------------------------------------------------------------------
+
+var rule = require('../rules/module-configuration-file');
+var RuleTester = require('eslint').RuleTester;
+var commonFalsePositives = require('./utils/commonFalsePositives');
+
+// ------------------------------------------------------------------------------
+// Tests
+// ------------------------------------------------------------------------------
+
+var eslintTester = new RuleTester();
+eslintTester.run('module-configuration-file', rule, {
+    valid: [
+        {
+            // config in a .config.js file
+            filename: 'app.config.js',
+            code: 'angular.module("app").config(function() {});'
+        },
+        {
+            // config in a .config.js file with module getter
+            filename: 'admin.config.js',
+            code: 'angular.module("admin").config(function($httpProvider) { $httpProvider.interceptors.push("authInterceptor"); });'
+        },
+        {
+            // simple config.js filename
+            filename: 'config.js',
+            code: 'angular.module("app").config(function() {});'
+        },
+        {
+            // config in a subdirectory
+            filename: 'src/app/modules/admin.config.js',
+            code: 'angular.module("admin").config(function() {});'
+        },
+        {
+            // module declaration without config
+            filename: 'app.module.js',
+            code: 'angular.module("app", []);'
+        },
+        {
+            // controller in non-config file
+            filename: 'home.controller.js',
+            code: 'angular.module("app").controller("HomeController", function() {});'
+        },
+        {
+            // service in non-config file
+            filename: 'user.service.js',
+            code: 'angular.module("app").factory("userService", function() {});'
+        },
+        {
+            // test file should be ignored
+            filename: 'app.spec.js',
+            code: 'angular.module("app").config(function() {});'
+        },
+        {
+            // test file should be ignored
+            filename: 'app.test.js',
+            code: 'angular.module("app").config(function() {});'
+        }
+    ].concat(commonFalsePositives),
+    invalid: [
+        {
+            filename: 'app.js',
+            code: 'angular.module("app").config(function() {});',
+            errors: [{
+                message: 'Module configuration should be in a separate file with a .config.js suffix'
+            }]
+        },
+        {
+            filename: 'app.module.js',
+            code: 'angular.module("app").config(function($httpProvider) { $httpProvider.interceptors.push("authInterceptor"); });',
+            errors: [{
+                message: 'Module configuration should be in a separate file with a .config.js suffix'
+            }]
+        },
+        {
+            filename: 'admin.js',
+            code: 'angular.module("admin").config(function() {});',
+            errors: [{
+                message: 'Module configuration should be in a separate file with a .config.js suffix'
+            }]
+        },
+        {
+            filename: 'src/app/admin.module.js',
+            code: 'angular.module("admin").config(configFunction);',
+            errors: [{
+                message: 'Module configuration should be in a separate file with a .config.js suffix'
+            }]
+        }
+    ]
+});