Skip to content

Commit ed60f67

Browse files
committed
Fix InputNumber
Fix Select
1 parent 5d65447 commit ed60f67

File tree

5 files changed

+86
-55
lines changed

5 files changed

+86
-55
lines changed

package-lock.json

Lines changed: 71 additions & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "element-react",
3-
"version": "1.1.3",
3+
"version": "1.1.4",
44
"description": "Element UI for React",
55
"private": false,
66
"main": "dist/npm/es5/index.js",
@@ -32,7 +32,7 @@
3232
},
3333
"homepage": "https://github.com/eleme/element-react",
3434
"devDependencies": {
35-
"@types/react": "^15.0.39",
35+
"@types/react": "^15.6.0",
3636
"babel-cli": "^6.24.1",
3737
"babel-eslint": "^7.2.3",
3838
"babel-jest": "^20.0.3",
@@ -44,7 +44,7 @@
4444
"codemirror": "^5.28.0",
4545
"core-js": "^2.4.1",
4646
"css-loader": "^0.28.4",
47-
"element-theme-default": "^1.4.0",
47+
"element-theme-default": "^1.4.1",
4848
"enzyme": "^2.9.1",
4949
"eslint": "^3.19.0",
5050
"eslint-config-airbnb": "^15.0.1",
@@ -54,8 +54,8 @@
5454
"eslint-plugin-react": "^7.0.1",
5555
"extract-text-webpack-plugin": "^3.0.0",
5656
"file-loader": "^0.11.2",
57-
"flow-bin": "^0.51.0",
58-
"html-webpack-plugin": "^2.29.0",
57+
"flow-bin": "^0.51.1",
58+
"html-webpack-plugin": "^2.30.1",
5959
"jest": "^20.0.4",
6060
"marked": "^0.3.6",
6161
"mock-raf": "^1.0.0",
@@ -67,11 +67,11 @@
6767
"react-test-renderer": "^15.5.4",
6868
"regenerator-runtime": "^0.10.5",
6969
"sass-loader": "^6.0.5",
70-
"sinon": "^2.3.8",
70+
"sinon": "^2.4.1",
7171
"style-loader": "^0.18.2",
7272
"typescript": "^2.4.2",
7373
"url-loader": "^0.5.8",
74-
"webpack": "^3.4.0",
74+
"webpack": "^3.4.1",
7575
"webpack-dev-server": "^2.6.1"
7676
},
7777
"dependencies": {

src/input-number/InputNumber.jsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export default class InputNumber extends Component {
2525

2626
componentWillReceiveProps(props: Object) {
2727
if (props.value != this.props.value) {
28-
this.setState({ value: Number(props.value) });
28+
this.setState({ value: props.value });
2929
}
3030
}
3131

@@ -56,7 +56,7 @@ export default class InputNumber extends Component {
5656
value = Number(this.props.min);
5757
}
5858
} else {
59-
value = '';
59+
value = undefined;
6060
}
6161

6262
this.setState({ value }, this.onChange);
@@ -83,11 +83,11 @@ export default class InputNumber extends Component {
8383
}
8484

8585
get minDisabled(): boolean {
86-
return (this.state.value - Number(this.props.step) < this.props.min);
86+
return !this.isValid || (this.state.value - Number(this.props.step) < this.props.min);
8787
}
8888

8989
get maxDisabled(): boolean {
90-
return (this.state.value + Number(this.props.step) > this.props.max);
90+
return !this.isValid || (this.state.value + Number(this.props.step) > this.props.max);
9191
}
9292

9393
increase(): void {
@@ -99,6 +99,7 @@ export default class InputNumber extends Component {
9999
} else {
100100
if (value + Number(step) > max || disabled) return;
101101
if (value + Number(step) < min ) value = min - Number(step);
102+
102103
value = accAdd(step, value);
103104
}
104105

src/select/Select.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ class Select extends Component {
202202
})[0];
203203

204204
if (selected) {
205-
this.state.selectedLabel = selected.props.label;
205+
this.state.selectedLabel = selected.props.label || selected.props.value;
206206
}
207207
}
208208
}

src/slider/Slider.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,8 @@ export default class Slider extends Component {
185185

186186
onInputValueChanged(e: number): void {
187187
this.setState({
188-
inputValue: e,
189-
firstValue: e
188+
inputValue: e || 0,
189+
firstValue: e || 0
190190
}, () => {
191191
this.setValues();
192192
});

0 commit comments

Comments
 (0)