Skip to content

Commit 0340a9e

Browse files
authored
chore: swap makefile for justfile (#84)
# Description <!-- Please provide a general summary of your PR changes and link any related issues or other pull requests. --> # Testing <!-- Please provide details on how you tested this code. See below. - All pull requests must be tested (unit tests where possible with accompanying cassettes, or provide a screenshot of end-to-end testing when unit tests are not possible) - New features must get a new unit test - Bug fixes/refactors must re-record existing cassettes --> # Pull Request Type Please select the option(s) that are relevant to this PR. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Improvement (fixing a typo, updating readme, renaming a variable name, etc)
1 parent 97de01c commit 0340a9e

File tree

4 files changed

+154
-188
lines changed

4 files changed

+154
-188
lines changed

.github/workflows/ci.yml

Lines changed: 44 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -10,69 +10,65 @@ jobs:
1010
lint:
1111
runs-on: windows-latest
1212
steps:
13-
- uses: actions/checkout@v5
14-
15-
- name: Install .NET SDK
16-
uses: actions/setup-dotnet@v5
13+
- uses: actions/checkout@v6
14+
- uses: extractions/setup-just@v3
15+
- uses: actions/setup-dotnet@v5
1716
with:
1817
dotnet-version: 10.x.x
1918

2019
- name: Set up dotnet tools
21-
run: make install-tools
20+
run: just install-tools
2221

2322
- name: Check style with dotnet-format
24-
run: make lint
23+
run: just lint
2524
Security_Code_Scan:
2625
runs-on: windows-latest
2726
steps:
28-
- uses: actions/checkout@v5
29-
30-
- name: Install .NET SDK
31-
uses: actions/setup-dotnet@v5
27+
- uses: actions/checkout@v6
28+
- uses: extractions/setup-just@v3
29+
- uses: actions/setup-dotnet@v5
3230
with:
3331
# v6 is needed for the tool to run
3432
dotnet-version: |
3533
10.x.x
3634
6.x.x
3735
3836
- name: Set up dotnet tools and dependencies
39-
run: make install
37+
run: just install
4038

4139
- name: Run security analysis
42-
run: make scan
40+
run: just scan
4341

4442
Coverage_Requirements:
4543
runs-on: ubuntu-latest
4644
steps:
47-
- uses: actions/checkout@v5
48-
49-
- name: Install .NET SDK
50-
uses: actions/setup-dotnet@v5
45+
- uses: actions/checkout@v6
46+
- uses: extractions/setup-just@v3
47+
- uses: actions/setup-dotnet@v5
5148
with:
5249
dotnet-version: 10.x.x
5350

5451
- name: Set up dotnet tools and dependencies
55-
run: make install
52+
run: just install
5653

5754
- name: Check if test suite coverage meets requirements
58-
run: make coverage-check
55+
run: just coverage-check
5956

6057
Upload_Coverage_Report:
6158
if: github.ref == 'refs/heads/master'
6259
runs-on: ubuntu-latest
6360
steps:
64-
- uses: actions/checkout@v5
65-
66-
- name: Install .NET SDK
67-
uses: actions/setup-dotnet@v5
61+
- uses: actions/checkout@v6
62+
- uses: extractions/setup-just@v3
63+
- uses: actions/setup-dotnet@v5
6864
with:
6965
dotnet-version: 10.x.x
7066

7167
- name: Set up dotnet tools and dependencies
72-
run: make install
68+
run: just install
7369

7470
- name: Generate coverage report
75-
run: make coverage
71+
run: just coverage
7672

7773
- name: Upload lcov coverage report to Coveralls
7874
uses: coverallsapp/github-action@master
@@ -103,12 +99,11 @@ jobs:
10399
framework: net10.0
104100
dotnet-version: 10.x.x
105101
steps:
106-
- uses: actions/checkout@v5
102+
- uses: actions/checkout@v6
107103
with:
108104
submodules: true
109-
110-
- name: Install .NET SDK
111-
uses: actions/setup-dotnet@v5
105+
- uses: extractions/setup-just@v3
106+
- uses: actions/setup-dotnet@v5
112107
with:
113108
dotnet-version: |
114109
10.x.x
@@ -133,15 +128,15 @@ jobs:
133128
${{ runner.os }}-nuget-
134129
135130
- name: Restore NuGet Packages
136-
run: make restore
131+
run: just restore
137132

138133
# Pull in fixtures submodule
139134
- name: Set up dotnet tools and dependencies
140-
run: make install
135+
run: just install
141136

142137
# Run the unit tests in a specific framework (verify that the library works in that framework)
143138
- name: Run Tests
144-
run: make unit-test FW=${{ matrix.framework }}
139+
run: just unit-test ${{ matrix.framework }}
145140

146141
# .NET Standard notes:
147142
# - NET Standard 2.0 is compatible with minimum .NET Framework 4.6.1: https://docs.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0
@@ -156,12 +151,11 @@ jobs:
156151
# Need windows-2022 for .NET Framework 4.7.2 support
157152
runs-on: windows-2022
158153
steps:
159-
- uses: actions/checkout@v5
154+
- uses: actions/checkout@v6
160155
with:
161156
submodules: true
162-
163-
- name: Install .NET SDK
164-
uses: actions/setup-dotnet@v5
157+
- uses: extractions/setup-just@v3
158+
- uses: actions/setup-dotnet@v5
165159
id: setupid
166160
with:
167161
dotnet-version: 10.x.x
@@ -181,24 +175,23 @@ jobs:
181175

182176
# Pull in fixtures submodule
183177
- name: Set up dotnet tools and dependencies
184-
run: make install
178+
run: just install
185179

186180
- name: Restore NuGet Packages
187-
run: make restore build
181+
run: just restore build
188182

189183
# Run the compatibility tests
190184
- name: Run Tests
191-
run: make netstandard-compat-test FW=net472
185+
run: just netstandard-compat-test net472
192186

193187
FSharp_Compatibility_Tests:
194188
runs-on: windows-latest
195189
steps:
196-
- uses: actions/checkout@v5
190+
- uses: actions/checkout@v6
197191
with:
198192
submodules: true
199-
200-
- name: Install .NET SDK
201-
uses: actions/setup-dotnet@v5
193+
- uses: extractions/setup-just@v3
194+
- uses: actions/setup-dotnet@v5
202195
id: setupid
203196
with:
204197
dotnet-version: 10.x.x
@@ -217,25 +210,24 @@ jobs:
217210
uses: darenm/Setup-VSTest@v1.3
218211

219212
- name: Restore NuGet Packages
220-
run: make restore
213+
run: just restore
221214

222215
# Pull in fixtures submodule
223216
- name: Set up dotnet tools and dependencies
224-
run: make install
217+
run: just install
225218

226219
# Run the compatibility tests
227220
- name: Run Tests
228-
run: make fs-compat-test
221+
run: just fs-compat-test
229222

230223
Visual_Basic_Compatibility_Test:
231224
runs-on: windows-latest
232225
steps:
233-
- uses: actions/checkout@v5
226+
- uses: actions/checkout@v6
234227
with:
235228
submodules: true
236-
237-
- name: Install .NET SDK
238-
uses: actions/setup-dotnet@v5
229+
- uses: extractions/setup-just@v3
230+
- uses: actions/setup-dotnet@v5
239231
id: setupid
240232
with:
241233
dotnet-version: 10.x.x
@@ -254,12 +246,12 @@ jobs:
254246
uses: darenm/Setup-VSTest@v1.3
255247

256248
- name: Restore NuGet Packages
257-
run: make restore
249+
run: just restore
258250

259251
# Pull in fixtures submodule
260252
- name: Set up dotnet tools and dependencies
261-
run: make install
253+
run: just install
262254

263255
# Run the compatibility tests
264256
- name: Run Tests
265-
run: make vb-compat-test
257+
run: just vb-compat-test

.github/workflows/release.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,9 @@ jobs:
1010
name: Publish to NuGet
1111
runs-on: windows-latest
1212
steps:
13-
- name: Checkout repository
14-
uses: actions/checkout@v5
15-
16-
- name: Install .NET SDK
17-
uses: actions/setup-dotnet@v5
13+
- uses: actions/checkout@v6
14+
- uses: extractions/setup-just@v3
15+
- uses: actions/setup-dotnet@v5
1816
with:
1917
dotnet-version: |
2018
6.x.x
@@ -27,10 +25,10 @@ jobs:
2725
uses: NuGet/setup-nuget@v2
2826

2927
- name: Restore NuGet Packages
30-
run: make restore
28+
run: just restore
3129

3230
- name: Set up dotnet tools and dependencies
33-
run: make install
31+
run: just install
3432

3533
- name: Set up authenticity certificate
3634
run: |
@@ -69,7 +67,7 @@ jobs:
6967
shell: cmd
7068

7169
- name: Publish to NuGet
72-
run: make publish key=${{ secrets.NUGET_API_KEY }}
70+
run: just publish ${{ secrets.NUGET_API_KEY }}
7371

7472
- name: Upload NuGet package to release
7573
uses: AButler/upload-release-assets@v3.0.1

Makefile

Lines changed: 0 additions & 128 deletions
This file was deleted.

0 commit comments

Comments
 (0)