Merge pull request #6 from DizzyMii/fix/landlord-maxretries-validation

fix(landlord): validate maxRetries as a positive integer

Author: DizzyMii

.changeset/fix-landlord-maxretries.md

@@ -0,0 +1,5 @@
+---
+"landlord": patch
+---
+
+Validate `maxRetries` on a contract as a positive integer. It was previously an unconstrained `z.number()`, so negative or zero values silently caused a tenant to escalate without ever running, and fractional values produced an unexpected extra attempt in the `attempt < maxRetries` loop. The schema now enforces `int().min(1)`.

packages/landlord/src/contract.ts

@@ -16,7 +16,7 @@ export const ContractSchema = z.object({
   toolsAllowed: z.array(z.string()).optional(),
   toolsDenied: z.array(z.string()).optional(),
   dependsOn: z.array(z.string()).default([]),
-  maxRetries: z.number().default(3),
+  maxRetries: z.number().int().min(1).default(3),
 });
 
 export type Checkpoint = z.infer<typeof CheckpointSchema>;

packages/landlord/test/contract.test.ts

@@ -63,4 +63,19 @@ describe('ContractSchema', () => {
     });
     expect(result.success).toBe(false);
   });
+
+  it('rejects non-positive, non-integer, and fractional maxRetries', () => {
+    const base = {
+      role: 'r',
+      objective: 'x',
+      subPrompt: 'x',
+      checkpoints: [],
+      outputSchema: {},
+    };
+    for (const maxRetries of [0, -1, 2.5]) {
+      const result = ContractSchema.safeParse({ ...base, maxRetries });
+      expect(result.success).toBe(false);
+    }
+    expect(ContractSchema.safeParse({ ...base, maxRetries: 1 }).success).toBe(true);
+  });
 });