Skip to content

Commit 5ddc989

Browse files
committed
fix sorting of service urls
1 parent e3e18df commit 5ddc989

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

internal/api/v1/nomad_service.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ func (s *NomadService) ExtractURLs() ([]generated.GetUrls200ResponseInner, error
115115
s.mu.Lock()
116116
defer s.mu.Unlock()
117117

118-
serviceUrls = append(makeUnique(serviceUrls), standardURLs...)
118+
serviceUrls = append(serviceUrls, standardURLs...)
119119

120-
return serviceUrls, nil
120+
return makeUnique(serviceUrls), nil
121121
}
122122

123123
func (s *NomadService) ExtractHostPorts() ([]generated.GetUrls200ResponseInner, error) {
@@ -373,8 +373,10 @@ func makeUnique(urls []generated.GetUrls200ResponseInner) []generated.GetUrls200
373373
result = append(result, url)
374374
}
375375

376-
sort.Slice(result, func(i, j int) bool {
377-
return result[i].Service < result[j].Service
376+
// sort the result by service name alphabetically
377+
slices.SortFunc(result, func(a, b generated.GetUrls200ResponseInner) int {
378+
return strings.Compare(a.Service, b.Service)
378379
})
380+
379381
return result
380382
}

0 commit comments

Comments
 (0)