Fix startup crash

Author: Dimencia

LuteBot/PartitionsForm.cs

@@ -656,7 +656,7 @@ public async void saveMultipleSongsToolStripMenuItem_Click(object sender, EventA
         public async void trainToolStripMenuItem_Click(object sender, EventArgs e)
         {
             var trainingForm = new NeuralNetworkForm(tsm, this);
-            trainingForm.ShowDialog(this);
+            trainingForm.Show(this);
 
         }
 

LuteBot/UI/LuteBotForm.cs

@@ -334,6 +334,17 @@ public async Task CheckUpdates(bool ignoreSettings = false)
 
         public bool IsLuteModInstalled()
         {
+            var inputIniPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), "Mordhau", "Saved", "Config", "WindowsClient", "Input.ini");
+            if (File.Exists(inputIniPath) && string.IsNullOrEmpty(ConfigManager.GetProperty(PropertyItem.MordhauInputIniLocation)))
+            {
+                Config.ConfigManager.SetProperty(Config.PropertyItem.MordhauInputIniLocation, inputIniPath);
+                Config.ConfigManager.SaveConfig();
+            }
+            else
+                inputIniPath = ConfigManager.GetProperty(PropertyItem.MordhauInputIniLocation);
+            // If the file exists, save it into config... this doesn't really go here... oh well.
+            
+
             if (string.IsNullOrWhiteSpace(MordhauPakPath))
             {
                 return true; // They have disabled installs or otherwise didn't input the path correctly, so don't check
@@ -348,13 +359,13 @@ public bool IsLuteModInstalled()
             }
             // Just check for the lutemod pak in CustomPaks, if they messed it up beyond that they can click the install button themselves, this is just to prompt them to install if necessary
             var pakPath = Path.Combine(MordhauPakPath, lutemodPakName);
-            if (File.Exists(pakPath))
+            if (File.Exists(pakPath) && !string.IsNullOrWhiteSpace(inputIniPath))
             {
-                // Actually.  If they have it, we should check engine.ini for the bad line, and if it's there, recommend install
-                string engineIniPath = Path.Combine(Path.GetDirectoryName(ConfigManager.GetProperty(PropertyItem.MordhauInputIniLocation)), "Engine.ini");
-
                 try
                 {
+                    // Actually.  If they have it, we should check engine.ini for the bad line, and if it's there, recommend install
+                    string engineIniPath = Path.Combine(Path.GetDirectoryName(inputIniPath), "Engine.ini");
+
                     var content = File.ReadAllText(engineIniPath);
                     return !content.Contains(removeFromEngine);
                 }

LuteBot/UI/NeuralNetworkForm.cs

@@ -355,7 +355,7 @@ private async Task TrainNetwork(int numPerfect, float percentForSuccess, int par
                                 if (tsm.MidiTracks.All(t => t.Value.Active))
                                 {
                                     // Actually, I think the flute track may not have the appropriate data...
-                                    var tempNeuralCandidates = tsm.MidiChannels.Values.Where(c => c.Id != 9).ToArray();
+                                    var tempNeuralCandidates = tsm.MidiChannels.Values.ToArray();
                                     foreach (var ca in tempNeuralCandidates)
                                     {
                                         ca.Active = tsm.DataDictionary[1].MidiChannels.Where(c => c.Id == ca.Id).Single().Active;
@@ -414,8 +414,8 @@ private async Task TrainNetwork(int numPerfect, float percentForSuccess, int par
 
                 var orderedCandidates = neuralCandidates.OrderBy(c => random.Next());
                 var numTestCandidates = (int)(orderedCandidates.Count() * 0.3f);
-                var neuralTrainingCandidates = orderedCandidates.Skip(numTestCandidates);
-                var neuralTestCandidates = orderedCandidates.Take(numTestCandidates);
+                var neuralTrainingCandidates = orderedCandidates.Skip(numTestCandidates).ToArray();
+                var neuralTestCandidates = orderedCandidates.Take(numTestCandidates).ToArray();
 
                 int numTestsCorrect = 0;
                 int numActualTestsCorrect = 0;
@@ -632,9 +632,14 @@ private async Task TrainNetwork(int numPerfect, float percentForSuccess, int par
                             //await Task.Delay(0); // Let the form live between iterations
                         }
                     });
+                    float invokeTotal = costTotal;
+                    int numTestCorrect = numActualTestsCorrect;
+                    int numTrainingCorrect = numTestsCorrect;
+                    Interlocked.Increment(ref i);
+                    int trainingNum = i;
                     BeginInvoke((MethodInvoker)delegate
                     {
-                        richTextBox1.AppendText($"\n{numActualTestsCorrect}/{neuralTestCandidates.Count()} ({(float)numActualTestsCorrect / neuralTestCandidates.Count() * 100}%) tests correct; {percentForSuccess}% {numPerfect} times in a row to finish.  Training Set: {numTestsCorrect}/{neuralCandidates.Count()}\nTraining #{i++} - TotalCost: {costTotal} (This number should go down eventually)");
+                        richTextBox1.AppendText($"\n{numTestCorrect}/{neuralTestCandidates.Length} ({(float)numTestCorrect / neuralTestCandidates.Length * 100}%) tests correct; {percentForSuccess}% {numPerfect} times in a row to finish.  Training Set: {numTrainingCorrect}/{neuralTrainingCandidates.Length}\nTraining #{trainingNum} - TotalCost: {invokeTotal} (This number should go down eventually)");
                         richTextBox1.ScrollToCaret();
                         progressBarTraining.Value = numActualTestsCorrect;
                     });

ReleaseNotes.txt

@@ -1,44 +1,17 @@
 Version 3.6.1
 
-- Maybe fix startup crashes for Epic users
+- Fixed startup crash for new users
+- Fixed incorrect numbers and percentages being displayed in Neural Network training
+- Added Neural Network pause/resume during training; it saves when paused
+- Added crash reporting back
 - LuteMod 2.61
 	- Re-enabled loading of voice config settings
 	- Fixed issue where playing sometimes pauses itself immediately
 
 Version 3.6.0
 
 - Major rework of LuteBot and LuteMod note handling and configuration
-	- LuteMod now sounds much better on most songs; it now respects note durations and the order of Tracks, which you can set in LuteBot by clicking and dragging tracks (not channels)
-	- LuteBot now uses a different library for loading midis, to hopefully have fewer midis that fail
-	- 'Notes Per Chord' was removed because it is obsolete; LuteMod now plays midis well even when all tracks are enabled for all instruments, trimming is not necessary
-	- LuteMod now forces a server update when playing each note, so should sound better across the network
-	- Added keybindings menu to LuteMod, accessible by entering "~Keybinds" in chat
+See previous release notes for more information
 
-- Warning: Old partitions will no longer play correctly on flute.  Select all your partitions (select the first one, scroll to the bottom, hold shift, click the last one) and use the new 'Resave' button to reload them all with note durations
-
-Details: 
-
-- Added default path for Epic Mordhau install
-- Revamped LuteBot UI (More revamp later)
-- Added validation that Mordhau is closed before installing LuteMod
-- Simplified MIDI loading process to save directly to LuteMod as soon as they're loaded, with options to edit afterward
-- Added note duration and track ordering to LuteBot/LuteMod Partitions
-	- Use Track Selection and click+drag tracks up or down; tracks at the top have priority
-	- Higher priority tracks can interrupt lower priority tracks
-	- Lower priority tracks can't play until the higher priority notes are done playing
-	- Lutes ignore these restrictions but still play the highest priority tracks first
-	- Track priority is ordered by the flute-estimation AI by default
-- LuteMod updated to 2.6 to handle this new system
-	- LuteMod now also forces server update to help ensure all your notes are heard, and has improved timing
-	- Cleans up most songs by prioritizing track order (on lute and flute), and playing multiple flute tracks no longer sounds like a trainwreck
-- Added keybindings menu to LuteMod; Enter "~Keybinds" in the chat to open it
-- Removed unused/broken functionality; LuteBot no longer supports Rust, Scrap Mechanic, Time Sync, Playlists, Soundboards, or Midi playback
-	- Use older versions if necessary (use a real Midi player for Midi playback)
-- Removed LuteBot's ability to play through Mordhau Console (and its related hotkeys and settings) to prevent confusion.  LuteMod should be used instead, check the Help button for more information
-- Swapped MIDI parsing engine to use DryWetMidi (should be more consistent and with less lockups and failures)
-- Track Filtering now scales based on tempo to show 30s by default
-- Maybe fixed concurrency issue when training the AI with more than one CPU Core
-- Fixed many potential memory leaks in LuteBot
-- Partitions are loaded in Track Selection when a single one is selected
-- Guild library form now supports adding multiple songs at once
-- Guild library form has better error reporting
+**NOTE** You need to Re-save your partitions (with the new button) for them to play correctly in the new version
+**NOTE** Use "~Keybinds" in chat to set keybindings, they are no longer tied to Mordhau bindings