Don't collect nix-expr-test crashes

Author: grahamc

dist/index.d.ts

@@ -15,20 +15,30 @@ const START_SLOP_SECONDS = 5;
 
 export async function collectBacktraces(
   prefixes: string[],
+  programNameDenyList: string[],
   startTimestampMs: number,
 ): Promise<Map<string, string>> {
   if (isMacOS) {
-    return await collectBacktracesMacOS(prefixes, startTimestampMs);
+    return await collectBacktracesMacOS(
+      prefixes,
+      programNameDenyList,
+      startTimestampMs,
+    );
   }
   if (isLinux) {
-    return await collectBacktracesSystemd(prefixes, startTimestampMs);
+    return await collectBacktracesSystemd(
+      prefixes,
+      programNameDenyList,
+      startTimestampMs,
+    );
   }
 
   return new Map();
 }
 
 export async function collectBacktracesMacOS(
   prefixes: string[],
+  programNameDenyList: string[],
   startTimestampMs: number,
 ): Promise<Map<string, string>> {
   const backtraces: Map<string, string> = new Map();
@@ -80,6 +90,11 @@ export async function collectBacktracesMacOS(
       .filter((fileName) => {
         return prefixes.some((prefix) => fileName.startsWith(prefix));
       })
+      .filter((fileName) => {
+        return !programNameDenyList.some((programName) =>
+          fileName.startsWith(`${programName}_${new Date().getFullYear()}`),
+        );
+      })
       .filter((fileName) => {
         // macOS creates .diag files periodically, which are called "microstackshots".
         // We don't necessarily want those, and they're definitely not crashes.
@@ -117,6 +132,7 @@ type SystemdCoreDumpInfo = {
 
 export async function collectBacktracesSystemd(
   prefixes: string[],
+  programNameDenyList: string[],
   startTimestampMs: number,
 ): Promise<Map<string, string>> {
   const sinceSeconds =
@@ -150,7 +166,10 @@ export async function collectBacktracesSystemd(
           const execParts = sussyObject.exe.split("/");
           const binaryName = execParts[execParts.length - 1];
 
-          if (prefixes.some((prefix) => binaryName.startsWith(prefix))) {
+          if (
+            prefixes.some((prefix) => binaryName.startsWith(prefix)) &&
+            !programNameDenyList.includes(binaryName)
+          ) {
             coredumps.push({
               exe: sussyObject.exe,
               pid: sussyObject.pid,

dist/index.js

@@ -130,6 +130,11 @@ export type ActionOptions = {
   //
   // Default: `[ "nix", "determinate-nixd", ActionOptions.name ]`.
   binaryNamePrefixes?: string[];
+
+  // Do NOT collect backtraces from segfaults and other failures from binaries with exact these names.
+  //
+  // Default: `[ "nix-expr-tests" ]`.
+  binaryNamesDenyList?: string[];
 };
 
 /**
@@ -144,6 +149,7 @@ export type ConfidentActionOptions = {
   requireNix: NixRequirementHandling;
   providedDiagnosticsUrl?: URL;
   binaryNamePrefixes: string[];
+  binaryNamesDenyList: string[];
 };
 
 /**
@@ -893,6 +899,7 @@ export abstract class DetSysAction {
 
       const backtraces = await collectBacktraces(
         this.actionOptions.binaryNamePrefixes,
+        this.actionOptions.binaryNamesDenyList,
         parseInt(actionsCore.getState(STATE_BACKTRACE_START_TIMESTAMP)),
       );
       actionsCore.debug(`Backtraces identified: ${backtraces.size}`);
@@ -1066,6 +1073,7 @@ function makeOptionsConfident(
       "determinate-nixd",
       actionOptions.name,
     ],
+    binaryNamesDenyList: actionOptions.binaryNamePrefixes ?? ["nix-expr-tests"],
   };
 
   actionsCore.debug("idslib options:");