diff --git a/src/dbup-firebird/FirebirdConnectionManager.cs b/src/dbup-firebird/FirebirdConnectionManager.cs index 39f51fc..f5dec36 100644 --- a/src/dbup-firebird/FirebirdConnectionManager.cs +++ b/src/dbup-firebird/FirebirdConnectionManager.cs @@ -1,4 +1,4 @@ -using System.Collections.Generic; +using System.Collections.Generic; using System.Linq; using System.Text.RegularExpressions; using DbUp.Engine.Transactions; @@ -19,10 +19,7 @@ public class FirebirdConnectionManager : DatabaseConnectionManager { } - /// - /// Splits the statements in the script using the ";" character. - /// - /// The contents of the script to split. + /// public override IEnumerable SplitScriptIntoCommands(string scriptContents) { // TODO: Possible Change - this is the PostGres version @@ -35,6 +32,7 @@ public override IEnumerable SplitScriptIntoCommands(string scriptContent return scriptStatements; } + /// protected override AllowedTransactionMode AllowedTransactionModes => AllowedTransactionMode.TransactionPerScript; } } diff --git a/src/dbup-firebird/FirebirdObjectParser.cs b/src/dbup-firebird/FirebirdObjectParser.cs index 42e0ba5..f6f7c8d 100644 --- a/src/dbup-firebird/FirebirdObjectParser.cs +++ b/src/dbup-firebird/FirebirdObjectParser.cs @@ -1,4 +1,4 @@ -using DbUp.Support; +using DbUp.Support; namespace DbUp.Firebird { @@ -7,6 +7,9 @@ namespace DbUp.Firebird /// public class FirebirdObjectParser : SqlObjectParser { + /// + /// Initializes a new instance of the class. + /// public FirebirdObjectParser() : base("\"", "\"") { } diff --git a/src/dbup-firebird/FirebirdScriptExecutor.cs b/src/dbup-firebird/FirebirdScriptExecutor.cs index f8c01d3..3d61d68 100644 --- a/src/dbup-firebird/FirebirdScriptExecutor.cs +++ b/src/dbup-firebird/FirebirdScriptExecutor.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Generic; using DbUp.Engine; using DbUp.Engine.Output; @@ -21,13 +21,14 @@ public class FirebirdScriptExecutor : ScriptExecutor /// The schema that contains the table. /// Function that returns true if variables should be replaced, false otherwise. /// Script Preprocessors in addition to variable substitution - /// Database journal + /// Database journal public FirebirdScriptExecutor(Func connectionManagerFactory, Func log, string schema, Func variablesEnabled, IEnumerable scriptPreprocessors, Func journal) : base(connectionManagerFactory, new FirebirdObjectParser(), log, schema, variablesEnabled, scriptPreprocessors, journal) { } + /// protected override string GetVerifySchemaSql(string schema) { throw new NotSupportedException(); @@ -39,6 +40,7 @@ protected override string GetVerifySchemaSql(string schema) /// protected override bool UseTheSameTransactionForJournalTableAndScripts => false; + /// protected override void ExecuteCommandsWithinExceptionHandler(int index, SqlScript script, Action executeCommand) { try diff --git a/src/dbup-firebird/FirebirdTableJournal.cs b/src/dbup-firebird/FirebirdTableJournal.cs index 8172e26..3699b6a 100644 --- a/src/dbup-firebird/FirebirdTableJournal.cs +++ b/src/dbup-firebird/FirebirdTableJournal.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Data; using DbUp.Engine; using DbUp.Engine.Output; @@ -51,6 +51,7 @@ void ExecuteCommand(Func dbCommandFactory, string sql) } } + /// protected override void OnTableCreated(Func dbCommandFactory) { var unquotedTableName = UnquoteSqlObjectName(FqSchemaTableName); @@ -60,21 +61,25 @@ protected override void OnTableCreated(Func dbCommandFactory) Log().LogInformation($"The {TriggerName(unquotedTableName)} trigger has been created"); } + /// protected override string DoesTableExistSql() { return $"select 1 from RDB$RELATIONS where RDB$SYSTEM_FLAG = 0 and RDB$RELATION_NAME = '{UnquotedSchemaTableName}'"; } + /// protected override string GetInsertJournalEntrySql(string @scriptName, string @applied) { return $"insert into {FqSchemaTableName} (ScriptName, Applied) values ({scriptName}, {applied})"; } + /// protected override string GetJournalEntriesSql() { return $"select ScriptName from {FqSchemaTableName} order by ScriptName"; } + /// protected override string CreateSchemaTableSql(string quotedPrimaryKeyName) { return diff --git a/src/dbup-firebird/dbup-firebird.csproj b/src/dbup-firebird/dbup-firebird.csproj index 4c4c46c..4d545c2 100644 --- a/src/dbup-firebird/dbup-firebird.csproj +++ b/src/dbup-firebird/dbup-firebird.csproj @@ -1,4 +1,4 @@ - + DbUp makes it easy to deploy and upgrade SQL Server databases. This package adds Firebird support. @@ -15,6 +15,7 @@ https://github.com/DbUp/dbup-firebird.git dbup-icon.png true + true