Skip to content

Commit d26f968

Browse files
Merge pull request #2596 from DataDog/bplasovska/fix/tests-dark-mode
Fix: Some session Replay tests fails when using dark mode Co-authored-by: barboraplasovska <barbora.plasovska@datadoghq.com>
2 parents bacf7a4 + 4c81ca7 commit d26f968

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

DatadogSessionReplay/Tests/Recorder/ViewTreeSnapshotProducer/ViewTreeSnapshot/NodeRecorders/UIHostingViewRecorderTests.swift

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ class UIHostingViewRecorderTests: XCTestCase {
1717
private enum Constants {
1818
static let bundledImageName = "dd_logo"
1919
static let nonBundledImageName = "flower"
20+
static let colorFormatPredicate = NSPredicate(format: "SELF MATCHES %@", "^#[0-9A-Fa-f]{8}$")
2021
}
2122

2223
// MARK: Text
@@ -25,7 +26,8 @@ class UIHostingViewRecorderTests: XCTestCase {
2526
XCTAssertEqual(wireframes.count, 1)
2627
let wireframe = try XCTUnwrap(wireframes.first?.textWireframe)
2728
XCTAssertEqual(wireframe.text, "Hello, World!")
28-
XCTAssertEqual(wireframe.textStyle.color, "#000000FF")
29+
// Check color format is valid
30+
XCTAssertTrue(Constants.colorFormatPredicate.evaluate(with: wireframe.textStyle.color))
2931
XCTAssertEqual(wireframe.textStyle.family, "-apple-system, BlinkMacSystemFont, \'Roboto\', sans-serif")
3032
XCTAssertEqual(wireframe.textStyle.size, 28)
3133
XCTAssertEqual(wireframe.x, 74, accuracy: 5)
@@ -47,7 +49,8 @@ class UIHostingViewRecorderTests: XCTestCase {
4749
XCTAssertEqual(wireframes.count, 1)
4850
let wireframe = try XCTUnwrap(wireframes.first?.textWireframe)
4951
XCTAssertEqual(wireframe.text, "xxxxxx xxxxxx")
50-
XCTAssertEqual(wireframe.textStyle.color, "#000000FF")
52+
// Check color format is valid
53+
XCTAssertTrue(Constants.colorFormatPredicate.evaluate(with: wireframe.textStyle.color))
5154
XCTAssertEqual(wireframe.textStyle.family, "-apple-system, BlinkMacSystemFont, \'Roboto\', sans-serif")
5255
XCTAssertEqual(wireframe.textStyle.size, 28)
5356
XCTAssertEqual(wireframe.x, 74, accuracy: 5)

0 commit comments

Comments
 (0)