Skip to content

Commit 893e43f

Browse files
committed
PANA-5681: Move isValidTapTarget to better location
1 parent 200cd05 commit 893e43f

7 files changed

Lines changed: 10 additions & 10 deletions

File tree

dd-sdk-android-internal/api/apiSurface

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ data class com.datadog.android.heatmaps.CrossPlatformHeatmapActionData
33
interface com.datadog.android.heatmaps.HeatmapIdentifierRegistryProvider
44
val heatmapIdentifierRegistry: com.datadog.android.internal.heatmaps.HeatmapIdentifierRegistry
55
fun heatmapViewKey(android.view.View): Long
6-
fun android.view.View.isValidTapTarget(): Boolean
76
interface com.datadog.android.internal.attributes.LocalAttribute
87
enum Key
98
constructor(String)
@@ -285,6 +284,7 @@ fun StringBuilder.appendIfNotEmpty(String)
285284
fun StringBuilder.appendIfNotEmpty(Char)
286285
fun String.toBase64(): String
287286
fun String.fromBase64(): String?
287+
fun android.view.View.isValidTapTarget(): Boolean
288288
fun Thread.safeGetThreadId(): Long
289289
fun Thread.State.asString(): String
290290
fun Array<StackTraceElement>.loggableStackTrace(): String

dd-sdk-android-internal/api/dd-sdk-android-internal.api

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ public final class com/datadog/android/heatmaps/HeatmapViewKeyKt {
2727
public static final fun heatmapViewKey (Landroid/view/View;)J
2828
}
2929

30-
public final class com/datadog/android/heatmaps/TapTargetUtilsKt {
31-
public static final fun isValidTapTarget (Landroid/view/View;)Z
32-
}
33-
3430
public abstract interface class com/datadog/android/internal/attributes/LocalAttribute {
3531
}
3632

@@ -674,6 +670,10 @@ public final class com/datadog/android/internal/utils/StringExtKt {
674670
public static final fun toBase64 (Ljava/lang/String;)Ljava/lang/String;
675671
}
676672

673+
public final class com/datadog/android/internal/utils/TapTargetUtilsKt {
674+
public static final fun isValidTapTarget (Landroid/view/View;)Z
675+
}
676+
677677
public final class com/datadog/android/internal/utils/ThreadExtKt {
678678
public static final fun asString (Ljava/lang/Thread$State;)Ljava/lang/String;
679679
public static final fun loggableStackTrace ([Ljava/lang/StackTraceElement;)Ljava/lang/String;

dd-sdk-android-internal/src/main/java/com/datadog/android/heatmaps/TapTargetUtils.kt renamed to dd-sdk-android-internal/src/main/java/com/datadog/android/internal/utils/TapTargetUtils.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* Copyright 2016-Present Datadog, Inc.
55
*/
66

7-
package com.datadog.android.heatmaps
7+
package com.datadog.android.internal.utils
88

99
import android.view.View
1010

dd-sdk-android-internal/src/test/java/com/datadog/android/heatmaps/TapTargetUtilsTest.kt renamed to dd-sdk-android-internal/src/test/java/com/datadog/android/internal/utils/TapTargetUtilsTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* Copyright 2016-Present Datadog, Inc.
55
*/
66

7-
package com.datadog.android.heatmaps
7+
package com.datadog.android.internal.utils
88

99
import android.view.View
1010
import com.datadog.android.internal.forge.Configurator

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/instrumentation/gestures/AndroidActionTrackingStrategy.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import android.widget.AbsListView
1212
import android.widget.ScrollView
1313
import androidx.core.view.ScrollingView
1414
import com.datadog.android.api.SdkCore
15-
import com.datadog.android.heatmaps.isValidTapTarget
15+
import com.datadog.android.internal.utils.isValidTapTarget
1616
import com.datadog.android.rum.tracking.ActionTrackingStrategy
1717
import com.datadog.android.rum.tracking.ViewTarget
1818
import java.lang.ref.WeakReference

features/dd-sdk-android-session-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/recorder/HeatmapIdentifierResolver.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ import androidx.annotation.UiThread
1313
import androidx.annotation.VisibleForTesting
1414
import com.datadog.android.api.InternalLogger
1515
import com.datadog.android.heatmaps.heatmapViewKey
16-
import com.datadog.android.heatmaps.isValidTapTarget
1716
import com.datadog.android.internal.heatmaps.HeatmapIdentifier
1817
import com.datadog.android.internal.heatmaps.HeatmapIdentifierRegistry
18+
import com.datadog.android.internal.utils.isValidTapTarget
1919

2020
internal class HeatmapIdentifierResolver(
2121
private val appPackageName: String,

features/dd-sdk-android-session-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/recorder/SnapshotProducer.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import android.view.View
1010
import android.view.ViewGroup
1111
import androidx.annotation.UiThread
1212
import com.datadog.android.api.InternalLogger
13-
import com.datadog.android.heatmaps.isValidTapTarget
13+
import com.datadog.android.internal.utils.isValidTapTarget
1414
import com.datadog.android.sessionreplay.ImagePrivacy
1515
import com.datadog.android.sessionreplay.R
1616
import com.datadog.android.sessionreplay.TextAndInputPrivacy

0 commit comments

Comments
 (0)