Skip to content

Prop mutation #64

@johnpuddephatt

Description

@johnpuddephatt

Currently blocks are mutating props directly, e.g:

@blur="props.block.details.value=content?.innerText"

My understanding is that props are readonly and shouldn't be mutated, instead an event should be emitted back up to the parent, which should then reassign the new value at the top level (which then cascades back down to the component). This is Evan You's advice and it came up on Twitter in response to the announcement.

I'm happy to submit a PR showing this in practice if it's helpful but wanted to first ask in case there was something I'm missing.

(amazing work by the way, I'm really excited about Lotion's potential!)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions