Remove unused parameters from internal functions

Signed-off-by: Steven Bellock <sbellock@nvidia.com>

Author: steven-bellock

include/internal/libspdm_common_lib.h

@@ -778,7 +778,7 @@ void libspdm_internal_dump_hex(const uint8_t *data, size_t size);
  */
 #if LIBSPDM_ENABLE_CAPABILITY_CHUNK_CAP
 /* first section */
-uint32_t libspdm_get_scratch_buffer_secure_message_offset(libspdm_context_t *spdm_context);
+uint32_t libspdm_get_scratch_buffer_secure_message_offset(void);
 uint32_t libspdm_get_scratch_buffer_secure_message_capacity(libspdm_context_t *spdm_context);
 
 /* second section */
@@ -1411,10 +1411,9 @@ void libspdm_reset_message_k(libspdm_context_t *spdm_context, void *spdm_session
 /**
  * Reset message EncapD cache in SPDM context.
  *
- * @param  spdm_context       A pointer to the SPDM context.
  * @param  spdm_session_info  A pointer to the SPDM session context.
  **/
-void libspdm_reset_message_encap_d(libspdm_context_t *spdm_context, void *spdm_session_info);
+void libspdm_reset_message_encap_d(void *spdm_session_info);
 
 /**
  * Reset message F cache in SPDM context.
@@ -1559,18 +1558,15 @@ libspdm_return_t libspdm_append_message_k(libspdm_context_t *spdm_context,
 /**
  * Append message EncapD cache in SPDM context.
  *
- * @param  spdm_context       A pointer to the SPDM context.
  * @param  spdm_session_info  A pointer to the SPDM session context.
- * @param  is_requester       Indicate of the key generation for a requester or a responder.
  * @param  message            Message buffer.
  * @param  message_size       Size in bytes of message buffer.
  *
  * @retval RETURN_SUCCESS          message is appended.
  * @retval RETURN_OUT_OF_RESOURCES message is not appended because the internal cache is full.
  **/
-libspdm_return_t libspdm_append_message_encap_d(libspdm_context_t *spdm_context,
-                                                void *spdm_session_info,
-                                                bool is_requester, const void *message,
+libspdm_return_t libspdm_append_message_encap_d(void *spdm_session_info,
+                                                const void *message,
                                                 size_t message_size);
 
 /**
@@ -1961,8 +1957,7 @@ uint32_t libspdm_mask_measurement_hash_algo(libspdm_context_t *spdm_context,
  *
  * @return The masked MeasurementSpecification.
  */
-uint8_t libspdm_mask_measurement_specification(libspdm_context_t *spdm_context,
-                                               uint8_t measurement_specification);
+uint8_t libspdm_mask_measurement_specification(uint8_t measurement_specification);
 
 /**
  * Return MELspecification that is masked by the negotiated SPDM version.

include/internal/libspdm_responder_lib.h

@@ -1,6 +1,6 @@
 /**
  *  Copyright Notice:
- *  Copyright 2021-2025 DMTF. All rights reserved.
+ *  Copyright 2021-2026 DMTF. All rights reserved.
  *  License: BSD 3-Clause License. For full text see link: https://github.com/DMTF/libspdm/blob/main/LICENSE.md
  **/
 
@@ -694,13 +694,11 @@ void libspdm_init_basic_mut_auth_encap_state(libspdm_context_t *spdm_context);
 /**
  * This function handles the encap error response.
  *
- * @param  spdm_context                  A pointer to the SPDM context.
  * @param  error_code                    Indicate the error code.
  *
  * @retval RETURN_DEVICE_ERROR          A device error occurs when communicates with the device.
  **/
-libspdm_return_t libspdm_handle_encap_error_response_main(
-    libspdm_context_t *spdm_context, uint8_t error_code);
+libspdm_return_t libspdm_handle_encap_error_response_main(uint8_t error_code);
 
 /**
  * Set session_state to an SPDM secured message context and trigger callback.

library/spdm_common_lib/libspdm_com_context_data.c

@@ -10,7 +10,7 @@
 
 #if LIBSPDM_ENABLE_CAPABILITY_CHUNK_CAP
 /* first section */
-uint32_t libspdm_get_scratch_buffer_secure_message_offset(libspdm_context_t *spdm_context) {
+uint32_t libspdm_get_scratch_buffer_secure_message_offset(void) {
     return 0;
 }
 
@@ -1359,7 +1359,7 @@ void libspdm_reset_message_k(libspdm_context_t *spdm_context, void *session_info
 #endif
 }
 
-void libspdm_reset_message_encap_d(libspdm_context_t *spdm_context, void *session_info)
+void libspdm_reset_message_encap_d(void *session_info)
 {
     libspdm_session_info_t *spdm_session_info;
 
@@ -2000,9 +2000,8 @@ libspdm_return_t libspdm_append_message_k(libspdm_context_t *spdm_context,
 #endif
 }
 
-libspdm_return_t libspdm_append_message_encap_d(libspdm_context_t *spdm_context,
-                                                void *session_info,
-                                                bool is_requester, const void *message,
+libspdm_return_t libspdm_append_message_encap_d(void *session_info,
+                                                const void *message,
                                                 size_t message_size)
 {
     libspdm_session_info_t *spdm_session_info;
@@ -3038,7 +3037,7 @@ void libspdm_deinit_context(void *spdm_context)
         libspdm_reset_message_m(context, session_info);
         libspdm_reset_message_e(context, session_info);
         libspdm_reset_message_encap_e(context, session_info);
-        libspdm_reset_message_encap_d(context, session_info);
+        libspdm_reset_message_encap_d(session_info);
         libspdm_reset_message_k(context, session_info);
         libspdm_reset_message_f(context, session_info);
     }

library/spdm_common_lib/libspdm_com_support.c

@@ -372,8 +372,7 @@ uint32_t libspdm_mask_measurement_hash_algo(libspdm_context_t *spdm_context,
     }
 }
 
-uint8_t libspdm_mask_measurement_specification(libspdm_context_t *spdm_context,
-                                               uint8_t measurement_specification)
+uint8_t libspdm_mask_measurement_specification(uint8_t measurement_specification)
 {
     return (measurement_specification & SPDM_MEASUREMENT_SPECIFICATION_10_MASK);
 }

library/spdm_crypt_lib/libspdm_crypt_asym.c

@@ -36,7 +36,6 @@ static const libspdm_signing_context_str_t m_libspdm_signing_context_str_table[]
 
 #if LIBSPDM_RSA_SSA_SUPPORT
 static bool libspdm_rsa_pkcs1_sign_with_nid_wrap (void *context, size_t hash_nid,
-                                                  const uint8_t *param, size_t param_size,
                                                   const uint8_t *message,
                                                   size_t message_size, uint8_t *signature,
                                                   size_t *sig_size)
@@ -48,7 +47,6 @@ static bool libspdm_rsa_pkcs1_sign_with_nid_wrap (void *context, size_t hash_nid
 
 #if LIBSPDM_RSA_PSS_SUPPORT
 static bool libspdm_rsa_pss_sign_wrap (void *context, size_t hash_nid,
-                                       const uint8_t *param, size_t param_size,
                                        const uint8_t *message,
                                        size_t message_size, uint8_t *signature,
                                        size_t *sig_size)
@@ -60,7 +58,6 @@ static bool libspdm_rsa_pss_sign_wrap (void *context, size_t hash_nid,
 
 #if LIBSPDM_ECDSA_SUPPORT
 static bool libspdm_ecdsa_sign_wrap (void *context, size_t hash_nid,
-                                     const uint8_t *param, size_t param_size,
                                      const uint8_t *message,
                                      size_t message_size, uint8_t *signature,
                                      size_t *sig_size)
@@ -260,7 +257,6 @@ static bool libspdm_asym_sign_wrap (void *context, size_t hash_nid, uint32_t bas
         LIBSPDM_ASSERT(base_asym_algo!= SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_RSASSA_4096);
 #endif
         return libspdm_rsa_pkcs1_sign_with_nid_wrap(context, hash_nid,
-                                                    param, param_size,
                                                     message, message_size,
                                                     signature, sig_size);
 #else
@@ -281,7 +277,6 @@ static bool libspdm_asym_sign_wrap (void *context, size_t hash_nid, uint32_t bas
         LIBSPDM_ASSERT(base_asym_algo!= SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_RSAPSS_4096);
 #endif
         return libspdm_rsa_pss_sign_wrap(context, hash_nid,
-                                         param, param_size,
                                          message, message_size,
                                          signature, sig_size);
 #else
@@ -302,7 +297,6 @@ static bool libspdm_asym_sign_wrap (void *context, size_t hash_nid, uint32_t bas
         LIBSPDM_ASSERT(base_asym_algo!= SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_ECDSA_ECC_NIST_P521);
 #endif
         return libspdm_ecdsa_sign_wrap(context, hash_nid,
-                                       param, param_size,
                                        message, message_size,
                                        signature, sig_size);
 #else
@@ -738,7 +732,6 @@ bool libspdm_is_signature_buffer_palindrome(
 
 #if LIBSPDM_RSA_SSA_SUPPORT
 static bool libspdm_rsa_pkcs1_verify_with_nid_wrap (void *context, size_t hash_nid,
-                                                    const uint8_t *param, size_t param_size,
                                                     const uint8_t *message,
                                                     size_t message_size,
                                                     const uint8_t *signature,
@@ -751,7 +744,6 @@ static bool libspdm_rsa_pkcs1_verify_with_nid_wrap (void *context, size_t hash_n
 
 #if LIBSPDM_RSA_PSS_SUPPORT
 static bool libspdm_rsa_pss_verify_wrap (void *context, size_t hash_nid,
-                                         const uint8_t *param, size_t param_size,
                                          const uint8_t *message,
                                          size_t message_size,
                                          const uint8_t *signature,
@@ -763,7 +755,6 @@ static bool libspdm_rsa_pss_verify_wrap (void *context, size_t hash_nid,
 
 #if LIBSPDM_ECDSA_SUPPORT
 static bool libspdm_ecdsa_verify_wrap (void *context, size_t hash_nid,
-                                       const uint8_t *param, size_t param_size,
                                        const uint8_t *message,
                                        size_t message_size,
                                        const uint8_t *signature,
@@ -820,7 +811,6 @@ static bool libspdm_asym_verify_wrap(
         LIBSPDM_ASSERT(base_asym_algo!= SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_RSASSA_4096);
 #endif
         return libspdm_rsa_pkcs1_verify_with_nid_wrap(context, hash_nid,
-                                                      param, param_size,
                                                       message, message_size,
                                                       signature, sig_size);
 #else
@@ -841,7 +831,6 @@ static bool libspdm_asym_verify_wrap(
         LIBSPDM_ASSERT(base_asym_algo!= SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_RSAPSS_4096);
 #endif
         return libspdm_rsa_pss_verify_wrap(context, hash_nid,
-                                           param, param_size,
                                            message, message_size,
                                            signature, sig_size);
 #else
@@ -862,7 +851,6 @@ static bool libspdm_asym_verify_wrap(
         LIBSPDM_ASSERT(base_asym_algo!= SPDM_ALGORITHMS_BASE_ASYM_ALGO_TPM_ALG_ECDSA_ECC_NIST_P521);
 #endif
         return libspdm_ecdsa_verify_wrap(context, hash_nid,
-                                         param, param_size,
                                          message, message_size,
                                          signature, sig_size);
 #else

library/spdm_crypt_lib/libspdm_crypt_cert.c

@@ -1393,7 +1393,6 @@ static bool libspdm_verify_leaf_cert_spdm_extension(const uint8_t *cert, size_t
  * @param[in]  cert                  Pointer to the DER-encoded certificate data.
  * @param[in]  cert_size             The size of certificate data in bytes.
  * @param[in]  base_asym_algo        SPDM base_asym_algo
- * @param[in]  base_hash_algo        SPDM base_hash_algo
  * @param[in]  is_requester_cert     Is the function verifying requester or responder cert.
  * @param[in]  cert_model            One of the SPDM_CERTIFICATE_INFO_CERT_MODEL_* macros.
  * @param[in]  set_cert              Is the function verifying a set certificate operation.
@@ -1403,7 +1402,7 @@ static bool libspdm_verify_leaf_cert_spdm_extension(const uint8_t *cert, size_t
  **/
 static bool libspdm_x509_common_certificate_check(
     const uint8_t *cert, size_t cert_size,
-    uint32_t base_asym_algo, uint32_t pqc_asym_algo, uint32_t base_hash_algo,
+    uint32_t base_asym_algo, uint32_t pqc_asym_algo,
     bool is_requester_cert, uint8_t cert_model,
     bool set_cert)
 {
@@ -1626,9 +1625,7 @@ bool libspdm_x509_certificate_check(
     bool need_basic_constraints;
 
     status = libspdm_x509_common_certificate_check(
-        cert, cert_size, base_asym_algo, pqc_asym_algo,
-        base_hash_algo, is_requester,
-        cert_model, false);
+        cert, cert_size, base_asym_algo, pqc_asym_algo, is_requester, cert_model, false);
     if (!status) {
         return false;
     }
@@ -1655,9 +1652,7 @@ bool libspdm_x509_set_cert_certificate_check(
     bool need_basic_constraints;
 
     status = libspdm_x509_common_certificate_check(
-        cert, cert_size, base_asym_algo, pqc_asym_algo,
-        base_hash_algo, is_requester,
-        cert_model, true);
+        cert, cert_size, base_asym_algo, pqc_asym_algo, is_requester, cert_model, true);
     if (!status) {
         return false;
     }

library/spdm_requester_lib/libspdm_req_encap_digests.c

@@ -1,6 +1,6 @@
 /**
  *  Copyright Notice:
- *  Copyright 2021-2025 DMTF. All rights reserved.
+ *  Copyright 2021-2026 DMTF. All rights reserved.
  *  License: BSD 3-Clause License. For full text see link: https://github.com/DMTF/libspdm/blob/main/LICENSE.md
  **/
 
@@ -151,8 +151,7 @@ libspdm_return_t libspdm_get_encap_response_digest(void *spdm_context,
     }
     if (session_info != NULL) {
         if (context->connection_info.multi_key_conn_req) {
-            status = libspdm_append_message_encap_d(context, session_info, true,
-                                                    spdm_response, *response_size);
+            status = libspdm_append_message_encap_d(session_info, spdm_response, *response_size);
             if (LIBSPDM_STATUS_IS_ERROR(status)) {
                 return libspdm_generate_encap_error_response(
                     context, SPDM_ERROR_CODE_UNSPECIFIED, 0,

library/spdm_requester_lib/libspdm_req_send_receive.c

@@ -185,7 +185,7 @@ libspdm_return_t libspdm_receive_response(void *spdm_context, const uint32_t *se
     transport_header_size = context->local_context.capability.transport_header_size;
     libspdm_get_scratch_buffer (context, (void **)&scratch_buffer, &scratch_buffer_size);
     #if LIBSPDM_ENABLE_CAPABILITY_CHUNK_CAP
-    *response = scratch_buffer + libspdm_get_scratch_buffer_secure_message_offset(context) +
+    *response = scratch_buffer + libspdm_get_scratch_buffer_secure_message_offset() +
                 transport_header_size;
     *response_size = libspdm_get_scratch_buffer_secure_message_capacity(context) -
                      transport_header_size;

library/spdm_responder_lib/libspdm_rsp_encap_challenge.c

@@ -104,8 +104,7 @@ libspdm_return_t libspdm_process_encap_response_challenge_auth(
         return LIBSPDM_STATUS_INVALID_MSG_FIELD;
     }
     if (spdm_response->header.request_response_code == SPDM_ERROR) {
-        status = libspdm_handle_encap_error_response_main(
-            spdm_context, spdm_response->header.param1);
+        status = libspdm_handle_encap_error_response_main(spdm_response->header.param1);
         if (LIBSPDM_STATUS_IS_ERROR(status)) {
             return status;
         }

library/spdm_responder_lib/libspdm_rsp_encap_get_certificate.c

@@ -1,6 +1,6 @@
 /**
  *  Copyright Notice:
- *  Copyright 2021-2025 DMTF. All rights reserved.
+ *  Copyright 2021-2026 DMTF. All rights reserved.
  *  License: BSD 3-Clause License. For full text see link: https://github.com/DMTF/libspdm/blob/main/LICENSE.md
  **/
 
@@ -133,8 +133,7 @@ libspdm_return_t libspdm_process_encap_response_certificate(
         return LIBSPDM_STATUS_INVALID_MSG_FIELD;
     }
     if (spdm_response->header.request_response_code == SPDM_ERROR) {
-        status = libspdm_handle_encap_error_response_main(
-            spdm_context, spdm_response->header.param1);
+        status = libspdm_handle_encap_error_response_main(spdm_response->header.param1);
         if (LIBSPDM_STATUS_IS_ERROR(status)) {
             return status;
         }