Fix build with -fsingle-precision-constant, add CI test

Signed-off-by: falkTX <falktx@falktx.com>

Author: falkTX

.github/workflows/build.yml

@@ -44,6 +44,14 @@ jobs:
       run: |
         make clean >/dev/null
         make -j ${{ env.JOBS }}
+    - name: Without any warnings + -fsingle-precision-constant
+      if: ${{ runner.os == 'Linux' }}
+      env:
+        CFLAGS: -Werror -fsingle-precision-constant
+        CXXFLAGS: -Werror -fsingle-precision-constant
+      run: |
+        make clean >/dev/null
+        make -j ${{ env.JOBS }}
     - name: Run tests
       if: ${{ runner.os == 'Linux' }}
       run: |

dgl/src/Window.cpp

@@ -276,7 +276,7 @@ void Window::setSize(uint width, uint height)
     {
         PuglArea area = puglGetSizeHint(pData->view, PUGL_FIXED_ASPECT);
 
-        if (pData->autoScaling && d_isNotEqual(scaleFactor, 1.0))
+        if (pData->autoScaling && d_isNotEqual<double>(scaleFactor, 1.0))
         {
             area.width = d_roundToUnsignedInt(area.width * scaleFactor);
             area.height = d_roundToUnsignedInt(area.height * scaleFactor);
@@ -311,7 +311,7 @@ void Window::setSize(uint width, uint height)
     }
     else
     {
-        if (pData->autoScaling && d_isNotEqual(scaleFactor, 1.0))
+        if (pData->autoScaling && d_isNotEqual<double>(scaleFactor, 1.0))
         {
             width = d_roundToUnsignedInt(width * scaleFactor);
             height = d_roundToUnsignedInt(height * scaleFactor);
@@ -441,7 +441,7 @@ void Window::enableInternalScalingWithSize(uint baseWidth, uint baseHeight, cons
 
     const double scaleFactor = pData->scaleFactor;
 
-    if (d_isNotEqual(scaleFactor, 1.0))
+    if (d_isNotEqual<double>(scaleFactor, 1.0))
     {
         baseWidth = d_roundToUnsignedInt(baseWidth * scaleFactor);
         baseHeight = d_roundToUnsignedInt(baseHeight * scaleFactor);

dgl/src/WindowPrivateData.cpp

@@ -62,7 +62,7 @@ static double getScaleFactor(const PuglView* const view)
 {
     // allow custom scale for testing
     if (const char* const scale = getenv("DPF_SCALE_FACTOR"))
-        return std::max(1.0, std::atof(scale));
+        return std::max<double>(1.0, std::atof(scale));
 
     if (view != nullptr)
         return puglGetScaleFactor(view);

distrho/src/DistrhoUI.cpp

@@ -94,7 +94,7 @@ static double getDesktopScaleFactor(const uintptr_t parentWindowHandle)
 {
     // allow custom scale for testing
     if (const char* const scale = getenv("DPF_SCALE_FACTOR"))
-        return std::max(1.0, std::atof(scale));
+        return std::max<double>(1.0, std::atof(scale));
 
    #if defined(DISTRHO_OS_WASM)
     return emscripten_get_device_pixel_ratio();
@@ -180,7 +180,7 @@ PluginWindow& UI::PrivateData::createNextWindow(UI* const ui, uint width, uint h
     UI::PrivateData* const uiData = s_nextPrivateData;
     const double scaleFactor = d_isNotZero(uiData->scaleFactor) ? uiData->scaleFactor : getDesktopScaleFactor(uiData->winId);
 
-    if (d_isNotEqual(scaleFactor, 1.0))
+    if (d_isNotEqual<double>(scaleFactor, 1.0))
     {
         width *= scaleFactor;
         height *= scaleFactor;

examples/EmbedExternalUI/EmbedExternalExampleUI.cpp

@@ -38,9 +38,6 @@ class EmbedExternalExampleUI : public UI
 
         setGeometryConstraints(width, height);
 
-        if (d_isNotEqual(scaleFactor, 1.0))
-            setSize(width, height);
-
         webview = webViewCreate("https://distrho.github.io/DPF/",
                                 getWindow().getNativeWindowHandle(),
                                 width, height, scaleFactor);