Use a custom WARNING() macro instead of relying on #warning

Signed-off-by: falkTX <falktx@falktx.com>

Author: falkTX

distrho/DistrhoUIMain.cpp

@@ -38,7 +38,7 @@
 #elif defined(DISTRHO_PLUGIN_TARGET_LV2)
 # if defined(DISTRHO_PLUGIN_AND_UI_IN_SINGLE_OBJECT)
 #  if ! DISTRHO_PLUGIN_WANT_DIRECT_ACCESS
-#   warning Using single/monolithic LV2 target while DISTRHO_PLUGIN_WANT_DIRECT_ACCESS is 0
+WARNING("Using single/monolithic LV2 target while DISTRHO_PLUGIN_WANT_DIRECT_ACCESS is 0")
 #  endif
 # else
 #  define DISTRHO_PLUGIN_AND_UI_IN_SINGLE_OBJECT DISTRHO_PLUGIN_WANT_DIRECT_ACCESS

distrho/extra/Mutex.hpp

@@ -30,7 +30,7 @@
 // FIXME make Mutex stop relying on pthread
 #ifdef _MSC_VER
 #define DISTRHO_OS_WINDOWS__TODO
-#pragma NOTE(DPF Mutex implementation is TODO on MSVC)
+WARNING("DPF Mutex implementation is TODO on MSVC")
 #else
 #include <pthread.h>
 #endif

distrho/src/DistrhoDefines.h

@@ -86,7 +86,7 @@
 #if defined(__GNUC__) && (__GNUC__ * 100 + __GNUC_MINOR__) >= 480
 # define DISTRHO_DEPRECATED __attribute__((deprecated))
 #elif defined(_MSC_VER)
-# define DISTRHO_DEPRECATED [[deprecated]] /* Note: __declspec(deprecated) it not applicable to enum members */
+# define DISTRHO_DEPRECATED [[deprecated]] /* Note: __declspec(deprecated) is not applicable to enum members */
 #else
 # define DISTRHO_DEPRECATED
 #endif
@@ -221,6 +221,13 @@ private:                                         \
 #define CPP_AGGREGATE_INIT(ClassName) (ClassName)
 #endif
 
+#define _PRAGMA_HELPER(x) _Pragma(#x)
+#if defined(_MSC_VER)
+#define WARNING(msg) _PRAGMA_HELPER(message(__FILE__ ": warning: " msg))
+#elif defined(__GNUC__)
+#define WARNING(msg) _PRAGMA_HELPER(GCC warning msg)
+#endif
+
 /* Useful typedefs */
 typedef unsigned char uchar;
 typedef unsigned short int ushort;

distrho/src/DistrhoPluginChecks.h

@@ -148,7 +148,7 @@
 // Test for wrong compiler macros
 
 #if defined(DISTRHO_PLUGIN_HAS_EMBED_UI)
-# warning DISTRHO_PLUGIN_HAS_EMBED_UI has been removed, it is now always on
+WARNING("DISTRHO_PLUGIN_HAS_EMBED_UI has been removed, it is now always on")
 #endif
 
 #if defined(DISTRHO_PLUGIN_HAS_EXTERNAL_UI)
@@ -202,7 +202,7 @@
 // Enable state if plugin wants state files (deprecated)
 
 #ifdef DISTRHO_PLUGIN_WANT_STATEFILES
-# warning DISTRHO_PLUGIN_WANT_STATEFILES is deprecated
+WARNING("DISTRHO_PLUGIN_WANT_STATEFILES is deprecated")
 # undef DISTRHO_PLUGIN_WANT_STATEFILES
 # if ! DISTRHO_PLUGIN_WANT_STATE
 #  undef DISTRHO_PLUGIN_WANT_STATE
@@ -214,7 +214,7 @@
 // Enable full state if plugin exports presets
 
 #if DISTRHO_PLUGIN_WANT_PROGRAMS && DISTRHO_PLUGIN_WANT_STATE && defined(DISTRHO_PLUGIN_WANT_FULL_STATE_WAS_NOT_SET)
-# warning Plugins with programs and state should implement full state API too
+WARNING("Plugins with programs and state should implement full state API too")
 # undef DISTRHO_PLUGIN_WANT_FULL_STATE
 # define DISTRHO_PLUGIN_WANT_FULL_STATE 1
 #endif

distrho/src/DistrhoPluginLADSPA+DSSI.cpp

@@ -27,7 +27,7 @@
 #endif
 
 #if DISTRHO_PLUGIN_WANT_TIMEPOS && !defined(DISTRHO_NO_WARNINGS)
-# warning LADSPA/DSSI does not support TimePos
+WARNING("LADSPA/DSSI does not support TimePos")
 #endif
 
 #ifdef DISTRHO_PLUGIN_TARGET_DSSI
@@ -38,7 +38,7 @@
 #  error Cannot use MIDI with LADSPA
 # endif
 # if DISTRHO_PLUGIN_WANT_STATE && !defined(DISTRHO_NO_WARNINGS)
-#  warning LADSPA cannot handle states
+WARNING("LADSPA cannot handle states")
 # endif
 #endif
 

distrho/src/DistrhoPluginVST2.cpp

@@ -426,7 +426,7 @@ class PluginVst : public ParameterAndNotesHelper
         fUsingNsView = true;
        #else
         #ifndef DISTRHO_NO_WARNINGS
-         #warning 32bit VST UIs on macOS only work if the host supports "hasCockosViewAsConfig"
+         WARNING("32bit VST UIs on macOS only work if the host supports 'hasCockosViewAsConfig'")
         #endif
         fUsingNsView = false;
        #endif