Builds fail

[IzzySoft]

I have no idea how you build the APK: v4.0.0 built fine here but was not RB, v4.1.0 I cannot even build anymore. It was definitely not built from the tagged commit (embedded commit hash says f13a5d6 while the tag points to 4b5ccdb), and running gradle assembleRelease, build crashes before it even starts:

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* Where:
Build file '/build/repo/app/build.gradle' line: 2

* What went wrong:
An exception occurred applying plugin request [id: 'com.android.application']
> Failed to apply plugin 'com.android.internal.version-check'.
   > 
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

Could you please build release APKs from the commit the tag points to? And I have no clue why this one doesn't even start to build…

[CrazyMarvin]

Oh no. 🙈
Sorry for the trouble.
I hope the next release will run smoothly.

[IzzySoft]

🤞

[IzzySoft]

I've played with 4.1.0 once more, taking a closer look:

* What went wrong:
An exception occurred applying plugin request [id: 'com.android.application']
> Failed to apply plugin 'com.android.internal.version-check'.
   > Minimum supported Gradle version is 8.10.2. Current version is 8.9. If using the gradle wrapper, try editing the distributionUrl in /build/repo/gradle/wrapper/gradle-wrapper.properties to gradle-8.10.2-all.zip

Looks like you forgot to update your gradle-wrapper.properties here. Further, it seems that APK wasn't built from the tagged commit, but from f13a5d6 (at least that's what the embedded vcsInfo says). Fixing both here, the build runs now – but finally fails with:

> Task :app:lintVitalReportRelease

> Task :app:lintVitalRelease FAILED
/build/repo/app/src/main/res/values-iw/strings.xml:86: Error: "toast_light" is translated here but not found in default locale [ExtraTranslation]
    <string name="toast_light">לא נמצא עכשיו בצד הקל.</string>
            ~~~~~~~~~~~~~~~~~~
/build/repo/app/src/main/res/values-pt-rBR/strings.xml:86: Error: "toast_light" is translated here but not found in default locale [ExtraTranslation]
    <string name="toast_light">To Don\'t está no modo claro agora.</string>
            ~~~~~~~~~~~~~~~~~~
/build/repo/app/src/main/res/values-iw/strings.xml:87: Error: "toast_dark" is translated here but not found in default locale [ExtraTranslation]
    <string name="toast_dark">לא נמצא עכשיו בצד האפל.</string>
            ~~~~~~~~~~~~~~~~~
/build/repo/app/src/main/res/values-pt-rBR/strings.xml:87: Error: "toast_dark" is translated here but not found in default locale [ExtraTranslation]
    <string name="toast_dark">To Don\'t está no modo escuro agora.</string>
            ~~~~~~~~~~~~~~~~~

As that's "just" a linter error, I dared telling gradle to ignore it (running with assembleRelease -x :app:lintVitalRelease). That way, the build succeeded – but again, wasn't RB. The diff told me multiple things. First, you didn't "pin" the versions of the libraries you're using:

  -rw----     2.4 fat     1738 b-      782 defN 1981-01-01 01:01:02 d5ac4dc2 DebugProbesKt.bin
- -rw----     2.4 fat        7 b-        7 stor 1981-01-01 01:01:02 d6eff90f META-INF/androidx.activity_activity-ktx.version
- -rw----     2.4 fat        7 b-        7 stor 1981-01-01 01:01:02 d6eff90f META-INF/androidx.activity_activity.version
- -rw----     2.4 fat        6 b-        6 stor 1981-01-01 01:01:02 6b070e7e META-INF/androidx.annotation_annotation-experimental.version
+ -rw----     2.4 fat        7 b-        7 stor 1981-01-01 01:01:02 cff4c84e META-INF/androidx.activity_activity.version
+ -rw----     2.4 fat        6 b-        6 stor 1981-01-01 01:01:02 721c3f3f META-INF/androidx.annotation_annotation-experimental.version
  -rw----     2.4 fat        6 b-        6 stor 1981-01-01 01:01:02 60a990d1 META-INF/androidx.appcompat_appcompat-resources.version

The first marked file does not exist in my build, which suggests your build did not even happen from the indicated commit, but from a "dirty tree" with local changes – e.g. the versionName was changed after that commit. The second one has a version mismatch: 8.10.0 in your build, 8.10.1 in mine. A bunch of resource files differ, as well as the classes.dex – but with the fact of a "dirty tree" already established, it makes no sense to dig into those.

May I point you to our hints on reproducible builds? What's called the "first basic rule" there, would have taken care for half of what was mentioned above 😉

Please don't misread this as a rant. It's rather intended to give some pointers on what to take care for with your next release. If you want to, you can provide me with an APK (and name the commit you've built that from) before your next release, so we can check if all is fine then.

[IzzySoft]

@CrazyMarvin any news on this?

[CrazyMarvin]

We will try a new v4.2.0 release next month.
FYI @theftzoku

[IzzySoft]

Err… which calendar are we using? Just asking for a friend 🙈

[CrazyMarvin]

Err… which calendar are we using? Just asking for a friend 🙈

😅

[CrazyMarvin]

Are you able to build 8f5b216, @IzzySoft?

[IzzySoft]

Do we have an APK built by you from that commit to compare against?

[IzzySoft]

Deadlock? 🙈

[CrazyMarvin]

Deadlock? 🙈

Sorry for the delay, @IzzySoft.
I will update you later.

[linsui]

Any update? :)

[CrazyMarvin]

Sorry for the delay. We are working on a new release.

[CrazyMarvin]

Does v4.2.0 build finally, @linsui & @IzzySoft? 😅

[IzzySoft]

It builds now, but not RB. Not sure where you built this, but probably not from inside the repo – so we cannot tell from which commit:

  -rw-r--r--  0.0 unx       56 b-       51 defN 1981-01-01 01:01:02 f9e152b4 META-INF/com/android/build/gradle/app-metadata.properties
- -rw-r--r--  0.0 unx       46 b-       48 defN 1981-01-01 01:01:02 b8ff6554 META-INF/version-control-info.textproto
- -rw-r--r--  0.0 unx     4173 b-     4173 stor 1981-01-01 01:01:02 befce73c assets/dexopt/baseline.prof
+ -rw-r--r--  0.0 unx      120 b-      118 defN 1981-01-01 01:01:02 7bff95bf META-INF/version-control-info.textproto
+ -rw-r--r--  0.0 unx     4174 b-     4174 stor 1981-01-01 01:01:02 50fc6215 assets/dexopt/baseline.prof
  -rw-r--r--  0.0 unx      288 b-      288 stor 1981-01-01 01:01:02 8d501b27 assets/dexopt/baseline.profm
  -rw-r--r--  0.0 unx  7278212 b-  2881010 defN 1981-01-01 01:01:02 c5400740 classes.dex
- -rw-r--r--  0.0 unx  6603388 b-  2341977 defN 1981-01-01 01:01:02 4a6526b5 classes2.dex
+ -rw-r--r--  0.0 unx  6603380 b-  2341872 defN 1981-01-01 01:01:02 ec5f7fcc classes2.dex
  -rw-r--r--  0.0 unx    16832 b-    16832 stor 1981-01-01 01:01:02 7d358e29 lib/arm64-v8a/libsentry-android.so
  -rw-r--r--  0.0 unx   704344 b-   704344 stor 1981-01-01 01:01:02 c17f88f3 lib/arm64-v8a/libsentry.so
  -rw-r--r--  0.0 unx    12080 b-    12080 stor 1981-01-01 01:01:02 53c2cd5e lib/armeabi-v7a/libsentry-android.so
@@ -14,7 +14,7 @@
  -rw-r--r--  0.0 unx   721100 b-   721100 stor 1981-01-01 01:01:02 95f532dc lib/x86/libsentry.so
  -rw-r--r--  0.0 unx    16384 b-    16384 stor 1981-01-01 01:01:02 498948b3 lib/x86_64/libsentry-android.so
  -rw-r--r--  0.0 unx   690848 b-   690848 stor 1981-01-01 01:01:02 a73763ad lib/x86_64/libsentry.so
- -rw-r--r--  0.0 unx      101 b-       94 defN 1981-01-01 01:01:02 b837c8b2 assets/sentry-debug-meta.properties
+ -rw-r--r--  0.0 unx      101 b-       95 defN 1981-01-01 01:01:02 5d42b99d assets/sentry-debug-meta.properties
  -rw-r--r--  0.0 unx     4065 b-     1118 defN 1981-01-01 01:01:02 704e134a assets/sentry-external-modules.txt

Your META-INF/version-control-info.textproto states: generate_error_reason: NO_SUPPORTED_VCS_FOUND, while ours has the commit hash it was built from 🤷‍♂️ Cannot RB if we don't know from what commit.

As for assets/sentry-debug-meta.properties: another RB killer, as that contains a build timestamp. Diff of classes2.dex is 300 KB – do you really use JDK-17 to build?