Use valgrind during CI + force GCC compilation as clang generates unsupported symbols

Author: Coloquinte

.github/workflows/build.yml

@@ -12,6 +12,7 @@ jobs:
     strategy:
       matrix:
         mode: ["Release", "Debug"]
+        compiler: ["gcc"]
 
     runs-on: ubuntu-latest
 
@@ -22,13 +23,17 @@ jobs:
         submodules: recursive
 
     - name: Install dependencies
-      run: sudo apt-get install tcl-dev libreadline-dev libffi-dev pkg-config python3 libboost-system-dev libboost-python-dev libboost-filesystem-dev zlib1g-dev xz-utils
+      run: sudo apt-get install tcl-dev libreadline-dev libffi-dev pkg-config python3 libboost-system-dev libboost-python-dev libboost-filesystem-dev zlib1g-dev xz-utils valgrind
 
     - name: ccache
       uses: hendrikmuhs/ccache-action@v1.2
 
     - name: Install yosys
-      run: git clone https://github.com/YosysHQ/yosys; cd yosys; make -j2 ENABLE_CCACHE=1 ${{ matrix.mode == 'Release' && 'ENABLE_NDEBUG=1' || '' }}; sudo make install; cd ..
+      run: |
+        git clone https://github.com/YosysHQ/yosys; \
+        cd yosys; make config-${{ matrix.compiler }}; \
+        make -j2 ENABLE_CCACHE=1 ${{ matrix.mode == 'Release' && 'ENABLE_NDEBUG=1' || '' }}; \
+        sudo make install; cd ..
 
     - name: Build
       run: make -j2 ENABLE_WERROR=1; sudo make install
@@ -37,7 +42,7 @@ jobs:
       run: bash test/download_benchmarks.sh
 
     - name: Test
-      run: bash test/test_commands.sh
+      run: ${{ matrix.compiler == 'gcc' && 'ENABLE_VALGRIND=1' || '' }} bash test/test_commands.sh
 
     - name: Run
       if: ${{ matrix.mode == 'Release' }}

test/test_commands.sh

@@ -2,32 +2,38 @@
 
 set -e
 
+cmd=""
+if [ "$ENABLE_VALGRIND" == "1" ]
+then
+	cmd="valgrind --error-exitcode=11 "
+fi
+
 # Basic corruption
-yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -target corruption"
+$cmd yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -target corruption"
 
 # Basic pairwise
-yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -target pairwise"
+$cmd yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -target pairwise"
 
 # Basic hybrid
-yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -target hybrid"
+$cmd yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -target hybrid"
 
 # Basic pairwise without deduplication
-yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -target pairwise-no-dedup"
+$cmd yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -target pairwise-no-dedup"
 
 # Set key percent and key
-yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -key-percent 5 -key 0a239e"
+$cmd yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -key-percent 5 -key 0a239e"
 
 # Set key bits and key
-yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -key-bits 10 -key 0a239e"
+$cmd yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -key-bits 10 -key 0a239e"
 
 # Set number of test vectors and keys
-yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -nb-test-vectors 99 -nb-analysis-keys 95 -nb-analysis-vectors 1079"
+$cmd yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -nb-test-vectors 99 -nb-analysis-keys 95 -nb-analysis-vectors 1079"
 
 # Explore
-yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -explore -output-dir logs"
+$cmd yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -explore -output-dir logs"
 
 # No analysis
-yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -nb-analysis-keys 0"
+$cmd yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -nb-analysis-keys 0"
 
 # Change port name
-yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -port-name test_port"
+$cmd yosys -m moosic -p "read_blif benchmarks/blif/c1355.blif; flatten; synth; logic_locking -port-name test_port"