Upgrade CYF ESLint config and fix violations

Author: textbook

eslint.config.js

@@ -14,7 +14,7 @@ export default [
 			reportUnusedDisableDirectives: "error",
 		},
 	},
-	cyfConfig,
+	...cyfConfig.configs.standard,
 	...tsEslint.configs.strict,
 	...tsEslint.configs.stylistic,
 	...typeScriptOnly(

package-lock.json

@@ -33,7 +33,7 @@
   },
   "homepage": "https://github.com/CodeYourFuture/gitbot#readme",
   "devDependencies": {
-    "@codeyourfuture/eslint-config-standard": "^5.1.0",
+    "@codeyourfuture/eslint-config-standard": "^7.0.0",
     "@netlify/functions": "^3.0.4",
     "@octokit/webhooks-types": "^7.6.1",
     "@types/eslint": "^9.6.1",

package.json

@@ -43,8 +43,8 @@ describe("repo event handler", () => {
 			blocks: [
 				{
 					text: {
-						"text": "A new repository <https://github.com/Foo/Bar|`Foo/Bar`> was just created by <https://github.com/octocat|Monalisa Octocat>.",
-						"type": "mrkdwn",
+						text: "A new repository <https://github.com/Foo/Bar|`Foo/Bar`> was just created by <https://github.com/octocat|Monalisa Octocat>.",
+						type: "mrkdwn",
 					},
 					type: "section",
 				},
@@ -191,7 +191,7 @@ describe("repo event handler", () => {
 		});
 	});
 
-	const createPayload = async (secret: string, event: PingEvent | RepositoryEvent): Promise<{ body: string, signature: string }> => {
+	const createPayload = async (secret: string, event: PingEvent | RepositoryEvent): Promise<{ body: string; signature: string }> => {
 		const body = JSON.stringify(event);
 		const signature = await sign(secret, body);
 		return { body, signature };

src/netlify/repo_event.test.ts

@@ -9,7 +9,7 @@ const enum HttpStatus {
 	BAD_REQUEST = 400,
 }
 
-type Event = Pick<HandlerEvent, "body" | "headers">
+type Event = Pick<HandlerEvent, "body" | "headers">;
 
 const handler = (async (event: Event): Promise<HandlerResponse> => {
 	let payload: Maybe<Repository>;

src/netlify/repo_event.ts

@@ -81,8 +81,8 @@ describe("slack interaction handler", () => {
 		expect(getBody(await updateRequest!.text())).toEqual({
 			blocks: [{
 				text: {
-					"text": "A new repository <repoUrl|`owner/repo`> was just created by <userUrl|userName>.",
-					"type": "mrkdwn",
+					text: "A new repository <repoUrl|`owner/repo`> was just created by <userUrl|userName>.",
+					type: "mrkdwn",
 				},
 				type: "section",
 			}],
@@ -154,8 +154,8 @@ describe("slack interaction handler", () => {
 		expect(getBody(await updateRequest!.text())).toEqual({
 			blocks: [{
 				text: {
-					"text": "A new repository <repoUrl|`owner/repo`> was just created by <userUrl|userName>.",
-					"type": "mrkdwn",
+					text: "A new repository <repoUrl|`owner/repo`> was just created by <userUrl|userName>.",
+					type: "mrkdwn",
 				},
 				type: "section",
 			}],
@@ -165,7 +165,7 @@ describe("slack interaction handler", () => {
 		});
 	});
 
-	const createPayload = (secret: string, payload: Record<string, string>): { body: string, signature: string, timestamp: number } => {
+	const createPayload = (secret: string, payload: Record<string, string>): { body: string; signature: string; timestamp: number } => {
 		const timestamp = Math.floor(Date.now() / 1_000);
 		const body = new URLSearchParams(payload).toString();
 		const hmac = createHmac("sha256", secret);

src/netlify/slack_interaction.test.ts

@@ -106,12 +106,12 @@ describe("validatePayload", () => {
 		body = "",
 		signature = "",
 		timestamp = 0,
-	}: { body?: string, signature?: string, timestamp?: number } = {}): Maybe<MessageRef> => {
+	}: { body?: string; signature?: string; timestamp?: number } = {}): Maybe<MessageRef> => {
 		return validatePayload(body, signature, timestamp);
 	};
 });
 
-const sign = (payload: string, secret: string): { signature: string, timestamp: number } => {
+const sign = (payload: string, secret: string): { signature: string; timestamp: number } => {
 	const timestamp = Math.floor(Date.now() / 1_000);
 	const hmac = createHmac("sha256", secret);
 	hmac.update(`v0:${timestamp.toFixed(0)}:${payload}`);

src/slack.test.ts

@@ -2,7 +2,7 @@ import type { Maybe } from "./types.js";
 
 export function getConfig(name: string, required?: true): string;
 export function getConfig(name: string, required: false): Maybe<string>;
-export function getConfig (name: string, required = true): Maybe<string> {
+export function getConfig(name: string, required = true): Maybe<string> {
 	const value = process.env[name];
 	if (required && !value) {
 		throw new Error(`missing configuration ${name}`);