fix failing tests and address comments

Author: akaladarshi

src/rpc/mod.rs

@@ -41,6 +41,7 @@ pub use methods::*;
 /// Protocol or transport-specific error
 pub use jsonrpsee::core::ClientError;
 
+/// Sentinel value, indicating no limit on how far back to search in the chain (all the way to genesis epoch).
 pub const LOOKBACK_NO_LIMIT: ChainEpoch = -1;
 
 /// The macro `callback` will be passed in each type that implements

src/state_manager/mod.rs

@@ -1046,7 +1046,7 @@ where
         &self,
         mut current: Tipset,
         message: &ChainMessage,
-        min_epoch: ChainEpoch,
+        lookback_max_epoch: ChainEpoch,
         allow_replaced: bool,
     ) -> Result<Option<(Tipset, Receipt)>, Error> {
         let message_from_address = message.from();
@@ -1056,7 +1056,7 @@ where
             .map_err(Error::state)?;
         let message_from_id = self.lookup_required_id(&message_from_address, &current)?;
 
-        while current.epoch() >= min_epoch {
+        while current.epoch() >= lookback_max_epoch {
             let parent_tipset = self
                 .chain_index()
                 .load_required_tipset(current.parents())
@@ -1092,16 +1092,6 @@ where
     }
 
     /// Searches backwards through the chain for a message receipt.
-    ///
-    /// # Arguments
-    /// * `current` - The tipset to start searching from
-    /// * `message` - The message to search for
-    /// * `look_back_limit` - Maximum number of epochs to search backwards:
-    ///   - `None` or `Some(-1)` (LOOKBACK_NO_LIMIT): Search all the way to genesis
-    ///   - `Some(0)`: No search performed, returns `None` immediately
-    ///   - `Some(N)` where `N > 0`: Search back at most N epochs
-    ///   - `Some(N)` where `N >= current.epoch()`: Same as unlimited (to genesis)
-    /// * `allow_replaced` - Whether to accept replacement messages (same nonce, different CID)
     fn search_back_for_message(
         &self,
         current: Tipset,
@@ -1112,8 +1102,8 @@ where
         let current_epoch = current.epoch();
         let allow_replaced = allow_replaced.unwrap_or(true);
 
-        // Calculate the minimum epoch (inclusive lower bound) for the search.
-        let min_epoch = match look_back_limit {
+        // Calculate the max lookback epoch (inclusive lower bound) for the search.
+        let lookback_max_epoch = match look_back_limit {
             // No search: limit = 0 means search 0 epochs
             Some(0) => return Ok(None),
             // Limited search: calculate the inclusive lower bound
@@ -1123,7 +1113,7 @@ where
             _ => 0,
         };
 
-        self.check_search(current, message, min_epoch, allow_replaced)
+        self.check_search(current, message, lookback_max_epoch, allow_replaced)
     }
 
     /// Returns a message receipt from a given tipset and message CID.

src/tool/subcommands/api_cmd/test_snapshots.txt

@@ -286,8 +286,8 @@ filecoin_statereadstate_1748444218790447.rpcsnap.json.zst
 filecoin_statereadstate_1748444218790807.rpcsnap.json.zst
 filecoin_statereadstate_1749657617007020.rpcsnap.json.zst
 filecoin_statereplay_1743504051038215.rpcsnap.json.zst
-filecoin_statesearchmsg_1741784596636715.rpcsnap.json.zst
-filecoin_statesearchmsglimited_1741784596704877.rpcsnap.json.zst
+filecoin_statesearchmsg_1767947430707712.rpcsnap.json.zst
+filecoin_statesearchmsglimited_1767936905056090.rpcsnap.json.zst
 filecoin_statesectorexpiration_1741784727996672.rpcsnap.json.zst
 filecoin_statesectorgetinfo_1743098602783105.rpcsnap.json.zst
 filecoin_statesectorpartition_1737546933391247.rpcsnap.json.zst