update POI as well as regions?

[timriker]

When trimming worlds, the regions/* files are removed for cleaned regions, but the poi/* files remain for regions that used to exist.

My understanding is that this causes POIs to not get recreated correctly if chunks and regions are later regenerated.

What is the impact of leaving the poi/* files? Is there a way to force them to be cleaned?

[Brettflan]

Hmm, I had no idea. I just checked briefly and see that the "poi" folder was added in 1.14. According to the MC wiki, those files are for "villager identified beds, job sites, and bells in the world".

I wouldn't think that leaving them would cause problems later down the line if the generation methods remain the same, but if something changes in world generation (from plugins, MC updates, or whatever), it might have some impact. I could be wrong and it could also cause problems as you describe, though.

Probably best to remove those for trimmed regions even if just to be on the safe side then, yes. I'll try to make some time soon to implement that.

[timriker]

The old .dat files probably had villages and other items in the now-freed regions that should be deleted. I've not looked into the formats and contents for those. The new poi/* items seem to have the same names as the regions they cover. That's convenient. :)

[timriker]

In the past, regenerating a region when the village.dat was there I think is the cause of the partial village bugs. Half houses and such. A lot has changed since then, so no idea if it makes a difference now. It seems cleaner to clean them up and have them get rebuilt if/when the region is rebuilt.