From eebbe5023021ccfb83c2f76e68bf49ed4418a00d Mon Sep 17 00:00:00 2001 From: Thomas Jakobi Date: Mon, 4 May 2026 11:43:25 +0200 Subject: [PATCH] Fix exception handling Only the first catch will be triggered explicit by Guzzle, the second one can be triggered by othere errors. If the second error tries to get a Guzzle response, a non catched error occurs. --- .../upgrademodx/model/upgrademodx/upgrademodx.class.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/components/upgrademodx/model/upgrademodx/upgrademodx.class.php b/core/components/upgrademodx/model/upgrademodx/upgrademodx.class.php index 8a49063..e70c3b9 100644 --- a/core/components/upgrademodx/model/upgrademodx/upgrademodx.class.php +++ b/core/components/upgrademodx/model/upgrademodx/upgrademodx.class.php @@ -674,12 +674,12 @@ public function getRawVersions( // } catch (\Exception $e) { } catch (RequestException $e) { + /** @var $e \GuzzleHttp\Exception\RequestException */ $msg = $this->parseException($e, $verbose); echo $msg; $retVal = false; } catch (\Exception $e) { - /** @var $e \GuzzleHttp\Exception\RequestException */ - $msg = $this->parseException($e, $verbose); + $msg = $e->getMessage(); echo $msg; $retVal = false; }