|
1 | 1 | # frozen_string_literal: true |
2 | 2 |
|
3 | 3 | module Journaled |
4 | | - # Sends batches of events to Kinesis using the PutRecord single-event API |
| 4 | + # Sends batches of events to Kinesis using the PutRecords batch API |
5 | 5 | # |
6 | 6 | # This class handles: |
7 | | - # - Sending events individually to support guaranteed ordering |
| 7 | + # - Sending events in batches to improve throughput |
8 | 8 | # - Handling failures on a per-event basis |
9 | 9 | # - Classifying errors as transient vs permanent |
10 | 10 | # |
11 | 11 | # Returns structured results for the caller to handle event state management. |
12 | 12 | class KinesisBatchSender |
13 | | - FailedEvent = Struct.new(:event, :error_code, :error_message, :transient, keyword_init: true) do |
14 | | - def transient? |
15 | | - transient |
16 | | - end |
17 | | - |
18 | | - def permanent? |
19 | | - !transient |
20 | | - end |
21 | | - end |
22 | | - |
23 | | - PERMANENT_ERROR_CLASSES = [ |
24 | | - Aws::Kinesis::Errors::ValidationException, |
| 13 | + # Per-record error codes that indicate permanent failures (bad event data) |
| 14 | + PERMANENT_ERROR_CODES = [ |
| 15 | + 'ValidationException', |
25 | 16 | ].freeze |
26 | 17 |
|
27 | 18 | # Send a batch of database events to Kinesis |
28 | 19 | # |
29 | | - # Sends events one at a time to guarantee ordering. Stops on first transient failure. |
| 20 | + # Uses put_records batch API. Groups events by stream and sends each group as a batch. |
30 | 21 | # |
31 | 22 | # @param events [Array<Journaled::Outbox::Event>] Events to send |
32 | 23 | # @return [Hash] Result with: |
33 | 24 | # - succeeded: Array of successfully sent events |
34 | | - # - failed: Array of FailedEvent structs (only permanent failures) |
| 25 | + # - failed: Array of FailedEvent structs (both transient and permanent failures) |
35 | 26 | def send_batch(events) |
36 | | - result = { succeeded: [], failed: [] } |
| 27 | + # Group events by stream since put_records requires all records to go to the same stream |
| 28 | + events.group_by(&:stream_name).each_with_object({ succeeded: [], failed: [] }) do |(stream_name, stream_events), result| |
| 29 | + batch_result = send_stream_batch(stream_name, stream_events) |
| 30 | + result[:succeeded].concat(batch_result[:succeeded]) |
| 31 | + result[:failed].concat(batch_result[:failed]) |
| 32 | + end |
| 33 | + end |
37 | 34 |
|
38 | | - events.each do |event| |
39 | | - event_result = send_event(event) |
40 | | - if event_result.is_a?(FailedEvent) |
41 | | - if event_result.transient? |
42 | | - emit_transient_failure_metric |
43 | | - break |
44 | | - else |
45 | | - result[:failed] << event_result |
46 | | - end |
47 | | - else |
48 | | - result[:succeeded] << event_result |
49 | | - end |
| 35 | + private |
| 36 | + |
| 37 | + def send_stream_batch(stream_name, stream_events) |
| 38 | + records = build_records(stream_events) |
| 39 | + |
| 40 | + begin |
| 41 | + response = kinesis_client.put_records(stream_name:, records:) |
| 42 | + process_response(response, stream_events) |
| 43 | + rescue Aws::Kinesis::Errors::ValidationException |
| 44 | + # Re-raise batch-level validation errors (configuration issues) |
| 45 | + # These indicate invalid stream name, batch too large, etc. |
| 46 | + # Not event data problems - requires manual intervention |
| 47 | + raise |
| 48 | + rescue StandardError => e |
| 49 | + # Handle transient errors (throttling, network issues, service unavailable) |
| 50 | + handle_transient_batch_error(e, stream_events) |
50 | 51 | end |
| 52 | + end |
51 | 53 |
|
52 | | - result |
| 54 | + def build_records(stream_events) |
| 55 | + stream_events.map do |event| |
| 56 | + { |
| 57 | + data: event.event_data.merge(id: event.id).to_json, |
| 58 | + partition_key: event.partition_key, |
| 59 | + } |
| 60 | + end |
53 | 61 | end |
54 | 62 |
|
55 | | - private |
| 63 | + def process_response(response, stream_events) |
| 64 | + succeeded = [] |
| 65 | + failed = [] |
56 | 66 |
|
57 | | - # Send a single event to Kinesis |
58 | | - # |
59 | | - # @param event [Journaled::Outbox::Event] Event to send |
60 | | - # @return [Journaled::Outbox::Event, FailedEvent] The event on success, or FailedEvent on failure |
61 | | - def send_event(event) |
62 | | - # Merge the DB-generated ID into the event data before sending to Kinesis |
63 | | - event_data_with_id = event.event_data.merge(id: event.id) |
| 67 | + response.records.each_with_index do |record_result, index| |
| 68 | + event = stream_events[index] |
64 | 69 |
|
65 | | - kinesis_client.put_record( |
66 | | - stream_name: event.stream_name, |
67 | | - data: event_data_with_id.to_json, |
68 | | - partition_key: event.partition_key, |
69 | | - ) |
| 70 | + if record_result.error_code |
| 71 | + failed << create_failed_event(event, record_result) |
| 72 | + else |
| 73 | + succeeded << event |
| 74 | + end |
| 75 | + end |
70 | 76 |
|
71 | | - event |
72 | | - rescue *PERMANENT_ERROR_CLASSES => e |
73 | | - Rails.logger.error("Kinesis event send failed (permanent): #{e.class} - #{e.message}") |
74 | | - FailedEvent.new( |
75 | | - event:, |
76 | | - error_code: e.class.to_s, |
77 | | - error_message: e.message, |
78 | | - transient: false, |
79 | | - ) |
80 | | - rescue StandardError => e |
81 | | - Rails.logger.error("Kinesis event send failed (transient): #{e.class} - #{e.message}") |
82 | | - FailedEvent.new( |
| 77 | + { succeeded:, failed: } |
| 78 | + end |
| 79 | + |
| 80 | + def create_failed_event(event, record_result) |
| 81 | + Journaled::KinesisFailedEvent.new( |
83 | 82 | event:, |
84 | | - error_code: e.class.to_s, |
85 | | - error_message: e.message, |
86 | | - transient: true, |
| 83 | + error_code: record_result.error_code, |
| 84 | + error_message: record_result.error_message, |
| 85 | + transient: PERMANENT_ERROR_CODES.exclude?(record_result.error_code), |
87 | 86 | ) |
88 | 87 | end |
89 | 88 |
|
90 | | - def kinesis_client |
91 | | - @kinesis_client ||= KinesisClientFactory.build |
| 89 | + def handle_transient_batch_error(error, stream_events) |
| 90 | + Rails.logger.error("Kinesis batch send failed (transient): #{error.class} - #{error.message}") |
| 91 | + |
| 92 | + failed = stream_events.map do |event| |
| 93 | + Journaled::KinesisFailedEvent.new( |
| 94 | + event:, |
| 95 | + error_code: error.class.to_s, |
| 96 | + error_message: error.message, |
| 97 | + transient: true, |
| 98 | + ) |
| 99 | + end |
| 100 | + |
| 101 | + { succeeded: [], failed: } |
92 | 102 | end |
93 | 103 |
|
94 | | - def emit_transient_failure_metric |
95 | | - ActiveSupport::Notifications.instrument('journaled.kinesis_batch_sender.transient_failure') |
| 104 | + def kinesis_client |
| 105 | + @kinesis_client ||= KinesisClientFactory.build |
96 | 106 | end |
97 | 107 | end |
98 | 108 | end |
0 commit comments