Enable rubocop-rspec and rubocop-rake

Author: dmolesUC

rakelib/.rubocop.yml

@@ -0,0 +1,4 @@
+inherit_from: ../.rubocop.yml
+
+require:
+  - rubocop-rake

spec/.rubocop.yml

@@ -1,5 +1,8 @@
 inherit_from: ../.rubocop.yml
 
+require:
+  - rubocop-rspec
+
 AllCops:
   # Exclude generated files
   Exclude:
@@ -35,3 +38,89 @@ Metrics/MethodLength:
 # Sometimes we're testing the operator
 Lint/BinaryOperatorWithIdenticalOperands:
   Enabled: false
+
+############################################################
+# rubocop-rspec
+
+# believe me, it wasn't by choice
+RSpec/AnyInstance:
+  Enabled: false
+
+# we meant to do that
+RSpec/BeforeAfterAll:
+  Enabled: false
+
+# more words != more readable
+RSpec/ContextWording:
+  Enabled: false
+
+# explicit >>> implicit
+RSpec/DescribedClass:
+  Enabled: false
+
+# more punctuation != more readable
+RSpec/DescribeSymbol:
+  Enabled: false
+
+# setup cost / time >>> failure granularity
+RSpec/ExampleLength:
+  Max: 15
+  CountAsOne:
+    - array
+    - hash
+    - heredoc
+
+# we meant to do that
+RSpec/ExpectInHook:
+  Enabled: false
+
+# your naming scheme is not in possession of all the facts
+RSpec/FilePath:
+  Enabled: false
+
+# explicit >>> implicit
+RSpec/InstanceVariable:
+  Enabled: false
+
+# maybe when 'all' has a corresponding 'none' matcher
+RSpec/IteratedExpectation:
+  Enabled: false
+
+# we meant to do that
+RSpec/MessageSpies:
+  Enabled: false
+
+# too late now
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
+# setup cost / time >>> failure granularity
+RSpec/MultipleExpectations:
+  Enabled: false
+
+# cure is worse than the disease
+RSpec/NestedGroups:
+  Enabled: false
+
+# more quotation marks != more readable
+RSpec/SharedExamples:
+  Enabled: false
+
+# we meant to do that
+RSpec/StubbedMock:
+  Enabled: false
+
+# we meant to do that
+RSpec/VerifiedDoubles:
+  Enabled: false
+
+############################################################
+# rubocop-rspec
+
+# enable newer rubocop-rspec cops
+
+RSpec/IdenticalEqualityAssertion: # new in 2.4
+  Enabled: true
+
+RSpec/Rails/AvoidSetupHook: # new in 2.4
+  Enabled: true

spec/lib/berkeley_library/alma/barcode_spec.rb

@@ -3,7 +3,7 @@
 module BerkeleyLibrary
   module Alma
     describe BarCode do
-      before(:each) do
+      before do
         BerkeleyLibrary::Alma.configure do
           Config.alma_sru_host = 'berkeley.alma.exlibrisgroup.com'
           Config.alma_institution_code = '01UCS_BER'
@@ -12,7 +12,7 @@ module Alma
         end
       end
 
-      after(:each) do
+      after do
         BerkeleyLibrary::Alma::Config.send(:clear!)
       end
 

spec/lib/berkeley_library/alma/bib_number_spec.rb

@@ -3,7 +3,7 @@
 module BerkeleyLibrary
   module Alma
     describe BibNumber do
-      before(:each) do
+      before do
         BerkeleyLibrary::Alma.configure do
           Config.alma_sru_host = 'berkeley.alma.exlibrisgroup.com'
           Config.alma_institution_code = '01UCS_BER'
@@ -12,7 +12,7 @@ module Alma
         end
       end
 
-      after(:each) do
+      after do
         BerkeleyLibrary::Alma::Config.send(:clear!)
       end
 

spec/lib/berkeley_library/alma/config_spec.rb

@@ -6,7 +6,7 @@ module BerkeleyLibrary
   module Alma
     describe Config do
 
-      after(:each) do
+      after do
         Config.send(:clear!)
       end
 
@@ -52,7 +52,7 @@ module Alma
       describe 'with Rails config' do
         attr_reader :rails_config
 
-        before(:each) do
+        before do
           @rails_config = Class.new do
             attr_accessor :alma_sru_host, :alma_institution_code
           end.new
@@ -66,7 +66,7 @@ module Alma
           Object.const_set(:Rails, rails)
         end
 
-        after(:each) do
+        after do
           Object.send(:remove_const, :Rails)
         end
 

spec/lib/berkeley_library/alma/mms_id_spec.rb

@@ -3,7 +3,7 @@
 module BerkeleyLibrary
   module Alma
     describe MMSID do
-      before(:each) do
+      before do
         BerkeleyLibrary::Alma.configure do
           Config.alma_sru_host = 'berkeley.alma.exlibrisgroup.com'
           Config.alma_institution_code = '01UCS_BER'
@@ -12,7 +12,7 @@ module Alma
         end
       end
 
-      after(:each) do
+      after do
         BerkeleyLibrary::Alma::Config.send(:clear!)
       end
 

spec/lib/berkeley_library/alma/record_id_spec.rb

@@ -39,6 +39,7 @@ module Alma
 
       describe 'SRU methods' do
         before { Config.default! }
+
         after { Config.send(:clear!) }
 
         describe :get_marc_xml do

spec/lib/berkeley_library/alma/sru/sru_spec.rb

@@ -4,6 +4,7 @@ module BerkeleyLibrary
   module Alma
     describe SRU do
       before { Config.default! }
+
       after { Config.send(:clear!) }
 
       describe :get_marc_records do

spec/spec_helper.rb

@@ -15,8 +15,8 @@
   config.color = true
   config.tty = true
   config.formatter = :documentation
-  config.before(:each) { WebMock.disable_net_connect!(allow_localhost: true) }
-  config.after(:each) { WebMock.allow_net_connect! }
+  config.before { WebMock.disable_net_connect!(allow_localhost: true) }
+  config.after { WebMock.allow_net_connect! }
   config.mock_with :rspec do |mocks|
     mocks.verify_partial_doubles = true
   end