Make the library more 'robust'

[loevgaard]

Hi @BenjaminFavre

Thank you for your great library. It does its job perfectly!

I would love to make the library more robust by

• adding types (you already require PHP8)
• adding Psalm for static analysis
• adding tests
• adding coding standard
• and adding a github actions workflow for verifying the above

Wdyt?

Have a great day 👋

[BenjaminFavre]

Hi @loevgaard

The lib already fits my personal needs so I don't spend more time on it, but I would definitely welcome your contribution.
Feel free to make the library more robust, I will merge any PR in this sense, your 4 suggestions are relevant!

Thanks!

[loevgaard]

Good morning, @BenjaminFavre

I have added a few PRs. Let me know what you think :)

[BenjaminFavre]

Let me know when you're done working on the lib so I create a new tag ;)
I can also create an intermediary tag if you need one for your personal use.

[loevgaard]

My plan is to add some tests at some point to this library, Benjamin, but I am not sure when. Inspired by your decorator I created another decorator that you might find useful in debugging scenarios: https://github.com/Setono/request-aware-http-client.

Again, thanks for creating this library 🤜 🤛

[BenjaminFavre]

Nice ! I used to write all this painful logging around HTTP calls in each and every project that required it, next time I'll try to go with your decorator !

Thanks again for contribution, I created a tag containing all your work so far 🙏

[loevgaard]

Nice, thanks :)