Refresh PHPStan

Author: mbabker

phpstan-baseline.neon

@@ -144,6 +144,12 @@ parameters:
 			count: 1
 			path: src/DependencyInjection/Compiler/PingDBALConnectionsCompilerPass.php
 
+		-
+			message: '#^Method BabDev\\WebSocketBundle\\DependencyInjection\\Factory\\Authentication\\AuthenticationProviderFactory\:\:addConfiguration\(\) has parameter \$builder with generic class Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition but does not specify its types\: TParent$#'
+			identifier: missingType.generics
+			count: 1
+			path: src/DependencyInjection/Factory/Authentication/AuthenticationProviderFactory.php
+
 		-
 			message: '#^Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition\:\:children\(\)\.$#'
 			identifier: method.notFound
@@ -192,14 +198,20 @@ parameters:
 			count: 1
 			path: src/DependencyInjection/Factory/Authentication/SessionAuthenticationProviderFactory.php
 
+		-
+			message: '#^Method BabDev\\WebSocketBundle\\DependencyInjection\\Factory\\Authentication\\SessionAuthenticationProviderFactory\:\:addConfiguration\(\) has parameter \$builder with generic class Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition but does not specify its types\: TParent$#'
+			identifier: missingType.generics
+			count: 1
+			path: src/DependencyInjection/Factory/Authentication/SessionAuthenticationProviderFactory.php
+
 		-
 			message: '#^Parameter \#1 \$class of function class_exists expects string, mixed given\.$#'
 			identifier: argument.type
 			count: 1
 			path: src/Routing/Loader/AttributeLoader.php
 
 		-
-			message: '#^Parameter \#1 \$path of method Symfony\\Component\\Routing\\Loader\\AttributeClassLoader\:\:createRoute\(\) expects string, mixed given\.$#'
+			message: '#^Parameter \#1 \$path of method Symfony\\Component\\Routing\\Loader\\AttributeClassLoader\:\:createRoute\(\) expects string, string\|null given\.$#'
 			identifier: argument.type
 			count: 1
 			path: src/Routing/Loader/AttributeLoader.php
@@ -222,12 +234,6 @@ parameters:
 			count: 1
 			path: src/Routing/Loader/AttributeLoader.php
 
-		-
-			message: '#^Parameter \#3 \.\.\.\$values of function sprintf expects bool\|float\|int\|string\|null, mixed given\.$#'
-			identifier: argument.type
-			count: 1
-			path: src/Routing/Loader/AttributeLoader.php
-
 		-
 			message: '#^Cannot use array destructuring on \(list\<\(BabDev\\WebSocket\\Server\\WAMP\\WAMPConnection&PHPUnit\\Framework\\MockObject\\MockObject\)\|string\>\)\|null\.$#'
 			identifier: offsetAccess.nonArray

phpstan.neon

@@ -6,6 +6,8 @@ parameters:
   paths:
     - %currentWorkingDirectory%/src
     - %currentWorkingDirectory%/tests
+  excludePaths:
+    - %currentWorkingDirectory%/src/DependencyInjection/Configuration.php # PHPStan's Symfony extension doesn't know how to work with the generics added in 7.4
   treatPhpDocTypesAsCertain: false
   ignoreErrors:
     -

src/DependencyInjection/Configuration.php

@@ -19,8 +19,12 @@
      */
     public function __construct(private array $authenticationProviderFactories) {}
 
+    /**
+     * @return TreeBuilder<'array'>
+     */
     public function getConfigTreeBuilder(): TreeBuilder
     {
+        /** @var TreeBuilder<'array'> $treeBuilder */
         $treeBuilder = new TreeBuilder('babdev_websocket');
 
         $rootNode = $treeBuilder->getRootNode();
@@ -31,6 +35,9 @@ public function getConfigTreeBuilder(): TreeBuilder
         return $treeBuilder;
     }
 
+    /**
+     * @param ArrayNodeDefinition<TreeBuilder<'array'>> $rootNode
+     */
     private function addAuthenticationSection(ArrayNodeDefinition $rootNode): void
     {
         $authenticationNode = $rootNode->children()
@@ -40,6 +47,9 @@ private function addAuthenticationSection(ArrayNodeDefinition $rootNode): void
         $this->addAuthenticationProvidersSection($authenticationNode);
     }
 
+    /**
+     * @param ArrayNodeDefinition<TreeBuilder<'array'>> $authenticationNode
+     */
     private function addAuthenticationProvidersSection(ArrayNodeDefinition $authenticationNode): void
     {
         $providerNodeBuilder = $authenticationNode
@@ -56,6 +66,9 @@ private function addAuthenticationProvidersSection(ArrayNodeDefinition $authenti
         }
     }
 
+    /**
+     * @param ArrayNodeDefinition<TreeBuilder<'array'>> $rootNode
+     */
     private function addServerSection(ArrayNodeDefinition $rootNode): void
     {
         $rootNode->children()