fix: ignore policy-only E2E warnings (#4736)

* fix: ignore policy-only E2E warnings

* fix: cover all E2E warning handlers

Author: rbtr

.pipelines/singletenancy/aks/e2e-job-template.yaml

@@ -119,11 +119,17 @@ stages:
               hybridWin: true
               service: true
               hostport: true
+          # Auto-injected policy tasks can mark an otherwise healthy job as
+          # SucceededWithIssues. This output proves all product test steps ran.
+          - bash: echo "##vso[task.setvariable variable=completed;isOutput=true]true"
+            name: markE2ECompleted
+            displayName: Mark E2E completed
 
       # can only succeed with issues in linux
       - template: ../../templates/warning-handler-job-template.yaml
         parameters:
           dependsOnToEmitWarning: ${{ parameters.name }}
+          completionOutput: markE2ECompleted.completed
           clusterName: ${{ parameters.clusterName }}-$(commitID)
           fileSearchPattern: "azure-vnet*.log"
           # continue on error only in linux case to workaround known cniv1 issue where we leak an ip

.pipelines/singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-job-template.yaml

@@ -118,11 +118,17 @@ stages:
               hostport: true
               service: true
               hybridWin: true
+          # Auto-injected policy tasks can mark an otherwise healthy job as
+          # SucceededWithIssues. This output proves all product test steps ran.
+          - bash: echo "##vso[task.setvariable variable=completed;isOutput=true]true"
+            name: markE2ECompleted
+            displayName: Mark E2E completed
 
       # can only succeed with issues in windows
       - template: ../../templates/warning-handler-job-template.yaml
         parameters:
           dependsOnToEmitWarning: ${{ parameters.name }}_windows
+          completionOutput: markE2ECompleted.completed
           clusterName: ${{ parameters.clusterName }}-$(commitID)
           fileSearchPattern: "azure-vnet*.log"
           # known windows issues that occur only in testing:

.pipelines/singletenancy/azure-cni-overlay/azure-cni-overlay-e2e-job-template.yaml

@@ -138,12 +138,18 @@ stages:
               hostport: true
               service: true
               hybridWin: ${{ eq(parameters.os, 'windows') }}
+          # Auto-injected policy tasks can mark an otherwise healthy job as
+          # SucceededWithIssues. This output proves all product test steps ran.
+          - bash: echo "##vso[task.setvariable variable=completed;isOutput=true]true"
+            name: markE2ECompleted
+            displayName: Mark E2E completed
 
       # can only succeed with issues in windows
       - ${{ if eq(parameters.os, 'windows') }}:
         - template: ../../templates/warning-handler-job-template.yaml
           parameters:
             dependsOnToEmitWarning: ${{ parameters.name }}_${{ parameters.os }}
+            completionOutput: markE2ECompleted.completed
             clusterName: ${{ parameters.clusterName }}-$(commitID)
             fileSearchPattern: "azure-vnet*.log"
             # known windows issues that occur only in testing:

.pipelines/singletenancy/dualstack-overlay/dualstackoverlay-e2e-job-template.yaml

@@ -136,12 +136,18 @@ stages:
               service: ${{ eq(parameters.os, 'linux') }} # RUN IN LINUX NOT WINDOWS Currently broken for scenario and blocking releases, HNS is investigating.
               hostport: true
               hybridWin: ${{ eq(parameters.os, 'windows') }}
+          # Auto-injected policy tasks can mark an otherwise healthy job as
+          # SucceededWithIssues. This output proves all product test steps ran.
+          - bash: echo "##vso[task.setvariable variable=completed;isOutput=true]true"
+            name: markE2ECompleted
+            displayName: Mark E2E completed
 
       # can only succeed with issues in windows
       - ${{ if eq(parameters.os, 'windows') }}:
         - template: ../../templates/warning-handler-job-template.yaml
           parameters:
             dependsOnToEmitWarning: ${{ parameters.name }}_${{ parameters.os }}
+            completionOutput: markE2ECompleted.completed
             clusterName: ${{ parameters.clusterName }}-$(commitID)
             fileSearchPattern: "azure-vnet*.log"
             # known windows issues that occur only in testing:
@@ -169,4 +175,3 @@ stages:
           os: ${{ parameters.os }}
           cni: cniv2
           dependsOnJob: failedE2ELogs_${{ parameters.os }}
-

.pipelines/templates/warning-handler-job-template.yaml

@@ -5,12 +5,20 @@ parameters:
   searchPattern: ""
   cni: ""
   os: ""
+  completionOutput: ""
 
 jobs:
   - job: warningHandler
     displayName: "Handle E2E Warning"
     dependsOn: ${{ parameters.dependsOnToEmitWarning }}
-    condition: eq(dependencies.${{ parameters.dependsOnToEmitWarning }}.result, 'SucceededWithIssues')
+    condition: |
+      and(
+        eq(dependencies.${{ parameters.dependsOnToEmitWarning }}.result, 'SucceededWithIssues'),
+        or(
+          eq('${{ parameters.completionOutput }}', ''),
+          ne(dependencies.${{ parameters.dependsOnToEmitWarning }}.outputs['${{ parameters.completionOutput }}'], 'true')
+        )
+      )
     pool:
       name: $(BUILD_POOL_NAME_DEFAULT)
       demands: