-
-
Notifications
You must be signed in to change notification settings - Fork 154
Open
Description
I see that ts-for-gir is being used to generate types for Typescript but I have noticed some discrepancies in types for various different Astal services. Some notable culprits are:
- AstalNetwork.Wifi - can be
nullbut isn't typed accordingly. Which leads to startup errors if bindings are relying on a null value or if a property of a null Wifi (imagine no wifi adapter exists) is getting accessed. - AstalBluetooth.Adapter - same as above
- AstalNetwork.Wired - same as above
Culprit example:
bind(networkService.wifi, 'iconName')
This will fail and prevent the component from rendering if networkService.wifi is null. However, the type definition doesn't indicate that this can be null in the absence of a wifi adapter.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels