fix: image binaries multiparts was not able to be streamed due to default body limit malfunctioning

Author: ElhamAryanpur

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "lua-astra"
-version = "0.18.1"
+version = "0.18.2"
 authors = ["Elham Aryanpur <elhamaryanpur5@gmail.com>"]
 description = "🔥 Blazingly Fast 🔥 web server runtime for Lua"
 documentation = "https://astra.arkforge.net/docs/latest"

Cargo.toml

@@ -85,6 +85,7 @@ impl UserData for RequestLua {
                 .collect::<HashMap<String, String>>())
         });
         methods.add_async_method("get_cookie", |_, this, name: String| async move {
+            // ! Move this to a dedicated Cookie Userdata
             match this
                 .cookie
                 .get(name.as_str())
@@ -108,38 +109,35 @@ impl UserData for RequestLua {
 pub struct LuaMultipart {
     pub multipart: Multipart,
 }
-impl LuaMultipart {
-    async fn save_file(&mut self, file_path: Option<String>) -> mlua::Result<()> {
-        let mut file_path = if let Some(file_path) = file_path {
-            Some(tokio::fs::File::create(file_path).await?)
-        } else {
-            None
-        };
+impl UserData for LuaMultipart {
+    fn add_methods<M: mlua::UserDataMethods<Self>>(methods: &mut M) {
+        methods.add_async_method_mut(
+            "save_file",
+            |_, mut this, file_path: Option<String>| async move {
+                let mut file_path = if let Some(file_path) = file_path {
+                    Some(tokio::fs::File::create(file_path).await?)
+                } else {
+                    None
+                };
 
-        while let Ok(Some(field)) = self.multipart.next_field().await {
-            if file_path.is_none() {
-                if let Some(filename) = field.file_name() {
-                    file_path = Some(tokio::fs::File::create(filename).await?);
-                }
-            }
+                while let Ok(Some(field)) = this.multipart.next_field().await {
+                    if file_path.is_none() {
+                        if let Some(filename) = field.file_name() {
+                            file_path = Some(tokio::fs::File::create(filename).await?);
+                        }
+                    }
 
-            if let Some(ref mut file) = file_path {
-                if let Ok(bytes) = field.bytes().await {
-                    if let Err(err) = file.write(&bytes).await {
-                        return Err(mlua::Error::runtime(err));
+                    if let Some(ref mut file) = file_path {
+                        if let Ok(bytes) = field.bytes().await {
+                            if let Err(err) = file.write(&bytes).await {
+                                return Err(mlua::Error::runtime(err));
+                            }
+                        }
                     }
                 }
-            }
-        }
 
-        Ok(())
-    }
-}
-impl UserData for LuaMultipart {
-    fn add_methods<M: mlua::UserDataMethods<Self>>(methods: &mut M) {
-        methods.add_async_method_mut(
-            "save_file",
-            |_, mut this, file_path: Option<String>| async move { this.save_file(file_path).await },
+                Ok(())
+            },
         );
     }
 }

src/components/http/requests.rs

@@ -1,5 +1,6 @@
 use axum::http::{HeaderMap, HeaderName, HeaderValue, StatusCode};
 
+// ! Support more cookie types like signed and private
 #[derive(Debug, Clone)]
 pub enum CookieOperation {
     Add { key: String, value: String },
@@ -80,6 +81,7 @@ impl mlua::UserData for ResponseLua {
         });
 
         methods.add_method_mut("set_cookie", |_, this, (key, value): (String, String)| {
+            // ! More operations needs to be added per cookie, such as lifetime, ...
             this.cookie_operations
                 .push(CookieOperation::Add { key, value });
 

src/components/http/responses.rs

@@ -9,7 +9,6 @@ use crate::{
 use axum::{
     Router,
     body::Body,
-    extract::DefaultBodyLimit,
     http::Request,
     response::IntoResponse,
     routing::{delete, get, options, patch, post, put, trace},
@@ -176,6 +175,10 @@ pub fn load_routes() -> Router {
     }
 
     if let Ok(settings) = lua.globals().get::<mlua::Table>("Astra") {
+        // if let Ok(default_body_limit) = settings.get::<usize>("default_body_limit") {
+        //     router = router.layer(DefaultBodyLimit::max(default_body_limit));
+        // };
+
         if let Ok(should_compress) = settings.get::<bool>("compression") {
             if should_compress {
                 router = router.layer(
@@ -185,10 +188,6 @@ pub fn load_routes() -> Router {
                 );
             }
         };
-
-        if let Ok(default_body_limit) = settings.get::<usize>("default_body_limit") {
-            router = router.layer(DefaultBodyLimit::max(default_body_limit));
-        };
     }
 
     router