FIX: Only consider the file exists if size > 0. Only condider donwload complete if size > 0

Author: amilcarlucas

ardupilot_methodic_configurator/backend_filesystem.py

@@ -292,12 +292,11 @@ def vehicle_configuration_file_exists(self, filename: str) -> bool:
           filename (str): The name of the file to check.
 
         Returns:
-          bool: True if the file exists and is a file (not a directory), False otherwise.
+          bool: True if the file exists and is a file (not a directory) and is not empty, False otherwise.
 
         """
-        return os_path.exists(os_path.join(self.vehicle_dir, filename)) and os_path.isfile(
-            os_path.join(self.vehicle_dir, filename)
-        )
+        file_path = os_path.join(self.vehicle_dir, filename)
+        return os_path.exists(file_path) and os_path.isfile(file_path) and os_path.getsize(file_path) > 0
 
     def __all_intermediate_parameter_file_comments(self) -> dict[str, str]:
         """

ardupilot_methodic_configurator/backend_internet.py

@@ -76,7 +76,7 @@ def download_file_from_url(
 
         if progress_callback:
             progress_callback(100.0, _("Download complete"))
-        return True
+        return bool(downloaded > 0)
 
     except requests_Timeout:
         logging_error(_("Download timed out"))