fix(params): process all forced parameters instead of stopping at first error

compute_parameters() returned immediately on the first forced parameter
error, skipping all remaining forced parameters in the step. This meant
a single bad expression (e.g., missing fc_parameters, math domain error,
or missing doc metadata) would silently prevent valid forced parameters
from being computed.

Collect all errors and continue processing, so every valid forced
parameter in the step is still evaluated. All errors are joined and
returned together, giving the user a complete picture of what failed.

Derived parameters already used continue on error — this makes forced
parameters consistent with that behavior.

Signed-off-by: Yash Goel <yashhzd@users.noreply.github.com>

Author: yashhzd

ardupilot_methodic_configurator/backend_filesystem_configuration_steps.py

@@ -160,7 +160,7 @@ def __validate_parameters_in_configuration_steps(self, filename: str, file_info:
                         parameter,
                     )
 
-    def compute_parameters(  # pylint: disable=too-many-branches, too-many-arguments, too-many-positional-arguments
+    def compute_parameters(  # noqa: PLR0915 # pylint: disable=too-many-branches, too-many-arguments, too-many-positional-arguments, too-many-statements, too-many-locals
         self,
         filename: str,
         file_info: dict,
@@ -177,6 +177,7 @@ def compute_parameters(  # pylint: disable=too-many-branches, too-many-arguments
         if parameter_type + "_parameters" not in file_info or not variables:
             return ""
         destination = self.forced_parameters if parameter_type == "forced" else self.derived_parameters
+        errors: list[str] = []
         for parameter, parameter_info in file_info[parameter_type + "_parameters"].items():
             try:
                 if ("fc_parameters" in str(parameter_info["New Value"])) and (
@@ -189,8 +190,8 @@ def compute_parameters(  # pylint: disable=too-many-branches, too-many-arguments
                     error_msg = error_msg.format(**locals())
                     if parameter_type == "forced":
                         logging_error(error_msg)
-                        return error_msg
-                    if not ignore_fc_derived_param_warnings:
+                        errors.append(error_msg)
+                    elif not ignore_fc_derived_param_warnings:
                         logging_warning(error_msg)
                     continue
 
@@ -207,8 +208,8 @@ def compute_parameters(  # pylint: disable=too-many-branches, too-many-arguments
                     error_msg = error_msg.format(**locals())
                     if parameter_type == "forced":
                         logging_error(error_msg)
-                        return error_msg
-                    if not ignore_fc_derived_param_warnings:
+                        errors.append(error_msg)
+                    elif not ignore_fc_derived_param_warnings:
                         logging_warning(error_msg)
                     continue
 
@@ -230,8 +231,9 @@ def compute_parameters(  # pylint: disable=too-many-branches, too-many-arguments
                         error_msg = error_msg.format(**locals())
                         if parameter_type == "forced":
                             logging_error(error_msg)
-                            return error_msg
-                        logging_warning(error_msg)
+                            errors.append(error_msg)
+                        else:
+                            logging_warning(error_msg)
                         continue
 
                 if filename not in destination:
@@ -246,9 +248,10 @@ def compute_parameters(  # pylint: disable=too-many-branches, too-many-arguments
                 error_msg = error_msg.format(**locals())
                 if parameter_type == "forced":
                     logging_error(error_msg)
-                    return error_msg
-                logging_warning(error_msg)
-        return ""
+                    errors.append(error_msg)
+                else:
+                    logging_warning(error_msg)
+        return "\n".join(errors)
 
     def auto_changed_by(self, selected_file: str) -> str:
         if selected_file in self.configuration_steps: