fix(ui): center FC init progress bar on active screen on Windows

On Windows, a withdrawn tk.Tk() root can report winfo_width() > 1,
causing ProgressWindow to use parent-relative centering instead of
screen centering. This placed the "Initializing Flight Controller"
progress bar in the top-left corner instead of screen center.

Added winfo_viewable() check alongside the existing winfo_width()
check to reliably detect withdrawn parent windows on all platforms.

Added test to verify screen centering is used when parent is withdrawn.

Signed-off-by: Yash Goel <yashhzd@users.noreply.github.com>

Author: yashhzd

ardupilot_methodic_configurator/frontend_tkinter_progress_window.py

@@ -63,8 +63,8 @@ def __init__(  # pylint: disable=too-many-arguments, too-many-positional-argumen
             self.progress_window.deiconify()  # needs to be done before centering, but it does flicker :(
 
         # Center the progress window on screen or on parent
-        # Use screen centering if parent is a minimal temp root (like in FlightControllerConnectionProgress)
-        if isinstance(self.parent, tk.Tk) and self.parent.winfo_width() <= 1:
+        # Use screen centering if parent is not viewable (e.g., withdrawn temp root on Windows can report winfo_width() > 1)
+        if isinstance(self.parent, tk.Tk) and (self.parent.winfo_width() <= 1 or not self.parent.winfo_viewable()):
             BaseWindow.center_window_on_screen(self.progress_window)
         else:
             BaseWindow.center_window(self.progress_window, self.parent)
@@ -100,8 +100,8 @@ def update_progress_bar(self, current_value: int, max_value: int) -> None:
             if self.only_show_when_update_progress_called and not self._shown:
                 self.progress_window.deiconify()
                 # Re-center the window when it's first shown
-                # Use screen centering if parent is a minimal temp root
-                if isinstance(self.parent, tk.Tk) and self.parent.winfo_width() <= 1:
+                # On Windows, withdrawn parents can report winfo_width() > 1, so also check winfo_viewable()
+                if isinstance(self.parent, tk.Tk) and (self.parent.winfo_width() <= 1 or not self.parent.winfo_viewable()):
                     BaseWindow.center_window_on_screen(self.progress_window)
                 else:
                     BaseWindow.center_window(self.progress_window, self.parent)

tests/test_frontend_tkinter_progress_window.py

@@ -251,3 +251,37 @@ def test_user_sees_progress_window_handle_lazy_window_relift(self, progress_wind
 
         # Should be lifted again
         progress_window.progress_window.lift.assert_called_once()
+
+    def test_user_sees_fc_init_progress_centered_on_screen_with_withdrawn_parent(self, tk_root) -> None:
+        """
+        User sees FC init progress window centered on screen when parent is withdrawn.
+
+        GIVEN: A progress window created with a withdrawn parent (like FC connection progress)
+        WHEN: The window is first shown via update_progress_bar
+        THEN: Screen centering is used instead of parent-relative centering
+        """
+        tk_root.withdraw()
+
+        with (
+            patch(
+                "ardupilot_methodic_configurator.frontend_tkinter_base_window.BaseWindow.center_window_on_screen"
+            ) as mock_center_screen,
+            patch(
+                "ardupilot_methodic_configurator.frontend_tkinter_base_window.BaseWindow.center_window"
+            ) as mock_center_parent,
+        ):
+            window = ProgressWindow(
+                tk_root,
+                title="FC Init",
+                message="Init: {}/{}",
+                only_show_when_update_progress_called=True,
+            )
+
+            window.update_progress_bar(10, 100)
+
+            # Screen centering should be used, not parent-relative
+            assert mock_center_screen.call_count >= 1
+            mock_center_parent.assert_not_called()
+
+            with contextlib.suppress(Exception):
+                window.destroy()