Save after each level?

[prurigro]

I've never actually had pixel dungeon crash, but I have had my OS crash while playing pixel dungeon, and you lose all progress since you last exited the game (or died). I hadn't given it much thought, but I've been following some of the other forks, and this commit seems like a simple and decent solution to the issue, what do you think?

[watabou]

@prurigro That's exactly how it worked before ~1.6.0. Later I have removed it and probably I had reasons for that, but I don't remember them:) Please give me some time to consider it

[watabou]

I think it was related to my attempts to fight savescumming. It's virtually impossible on desktop, so probably it makes sense to bring the procedure back.

[prurigro]

Anyone with a backup manager on Android can use it to make a backup of the running game, which freezes the app's state and triggers a save while essentially only minimizing the gameplay, then a copy of that save is backed up as the player resumes gameplay. With a method that easy, I can't picture anyone taking the level-change-save route. On a side note; I should set the record straight and say that I found this method after losing data a few times due to phone reboots, and have no interest in cheating as that kind of defeats the whole fun-factor :).

In my opinion, as long as it takes a bit of working around to cheat the save system, and it isn't so easy that it's hard not to do, I'd say you've done plenty. Increasing the risk of data loss hitting legit players to save a few cheaters from ruining the game for themselves doesn't seem worth it, not that you haven't already agreed :).

If no one else gets to it, I can put together a pull request once it's clear whether @Arcnor is going to pull the 1.7.2a merge I did (or if those translations he's been doing mean it'd be easier for him to just re-do it from the upstream sources himself.)

Cheers!

Cheers