Default validator validates on string with wrong decimal symbol

[aheintz]

I'm using a decimal format with space as grouping char and comma as decimal char. But, a value such as 123,32 is determined to be invalid. The validator uses a good regex, but the value it validates is not the input string though. When using the setValue() method, the value is set to String noExponent = BigDecimal.valueOf(newValue.doubleValue()).toPlainString(); instead of using the format info in NumberField.

Since the default validator in many cases get a erroneous result, I think it should be disabled by default.

[aheintz]

I've made two pull requests, one with a mavenization of the project and one with quite a lot of changes to validation, formatting and parsing. It's possible that I've gone too far. Please review my pull requests and let me know if I need to rollback/change anything.

[Ansku]

There are quite a few changes to lines that haven't actually changed in any relevant way, and it's making it a bit hard to spot the actual changes. I try to use Vaadin Coding Conventions (except for the parts that refer to Java 6) in all my projects, so if you have time to reformat the changes according to those it would hopefully speed things up from my end a bit. The Vaadin core's extra workspace preferences would be a bonus, I'm not sure if I've remembered to add those to that particular workspace yet.

It's been a bit of a hectic week for me, sorry for the delay :(

[aheintz]

Sorry I haven't responded yet, but it's been a few extremely focused weeks and since I got the numberfield working for our case... Don't worry about its taking time.

I tried to import the vaadin coding conventions eclipse file at https://github.com/vaadin/vaadin/blob/master/eclipse/VaadinJavaConventions.xml but either IntelliJ couldn't interpret it correctly or it's just wrong. For example is the indentatino 8 spaces(?). I've tried to fix my code formatter so it matches as closely as possible and it seems to match mostly except for javadoc indents. I also updated the javadoc along the way so it may look like more changes than there actually is. The code changes in the "mavenize" pull request was due to my screwing up and using plain mv instead of git mv.

[alkhimistta]

Another solution may be to modify the method

private boolean validateValue(String value) {
        if (value == null || "".equals(value)) {
            return !isRequiredIndicatorVisible();
        }

        final boolean isValid;
        if (isDecimalAllowed()) {
            isValid = NumberValidator.isValidDecimal(getValueAsFormattedDecimalNumber(),
                    getState(), false);
        } else {
            isValid = NumberValidator.isValidInteger(getValueAsFormattedDecimalNumber(),
                    getState(), false);
        }

        return isValid;
    }

by

private boolean validateValue(String value) {
        if (value == null || "".equals(value)) {
            return !isRequiredIndicatorVisible();
        }

        final boolean isValid;
        if (isDecimalAllowed()) {
            isValid = NumberValidator.isValidDecimal(getValueAsFormattedDecimalNumber(),
                    getState(), true);
        } else {
            isValid = NumberValidator.isValidInteger(getValueAsFormattedDecimalNumber(),
                    getState(), true);
        }

        return isValid;
    }

[igorbljahhin]

Same issue here.