SlicerRadiomics unavailable for macOS since Slicer Preview 5.3.0 as of 2023-03-31

[jamesobutler]

The SlicerRadiomics extension has had build errors since March 31st, 2023 that has made it unavailable on macOS
https://slicer.cdash.org/viewBuildError.php?buildid=2985286

It is unable to build a macOS whl of pyradiomics. Around the time when this extension started to fail,

• The Slicer factory macOS machine was updated from macOS 10.13 (High Sierra) to macOS 13.0 (Ventura). See https://discourse.slicer.org/t/transition-of-macos-preview-build-from-host-10-13-high-sierra-to-13-ventura/28668.
• Also the minimum required macOS deployment was changed to macOS 11.0 in Slicer/Slicer@592ee0b.

cc: @JoostJM @fedorov

[jamesobutler]

Building of the wheel is continuing to fail.

Is the master branch necessary or could pyradiomics be installed using the latest whl from a couple weeks ago (https://pypi.org/project/pyradiomics/3.1.0/#files)?

SlicerRadiomics/SuperBuild/External_python-pyradiomics.cmake

Lines 32 to 35 in aa418a5

	ExternalProject_SetIfNotDefined(
	${CMAKE_PROJECT_NAME}_${proj}_GIT_TAG
	"origin/master"
	QUIET

[fedorov]

@jamesobutler I was never involved in any whl-related topics, and unfortunately cannot be of much help.

@hugoaerts is the lead of the lab maintaining pyradiomics, so perhaps he can help point to any other folks involved in the maintenance, since I am not sure Joost is actively working on pyradiomics anymore.

[jamesobutler]

It appears @JoostJM has been actively pushing updates to pyradiomics and generating a new release (https://github.com/AIM-Harvard/pyradiomics/commits/master). Just wondering who might be providing the maintenance here in the SlicerRadiomics extension. Is that @hugoaerts?

[fedorov]

It is unable to build a macOS whl of pyradiomics.

If pyradiomics whl fails to build, it is something that should be fixed in pyradiomics, I would expect. I do not now how whl build in pyradiomics works. The reality is this extension was developed with a funding from a grant that is long over. I am not sure there is anyone funded to provide maintenance of this extension. If anyone it would be Hugo and his team.

[JoostJM]

Hi,
As @fedorov mentioned, the grant covering PyRadiomics has ended and I'm not actively developing PyRadiomics. Still, I did find some spare time to update PyRadiomics CI, so I could make a new release (with support for more recent Python versions).

Currently, SlicerRadiomics builds PyRadiomics from the master branch, keeping it more up-to-date with the PyRadiomics repository (instead of just the latest release). I'll try to find some spare time to update SlicerRadiomics to use the latest release of PyRadiomics. For the forseable future, this should fix the error.

Finally, I reviewed the build log. The build step is failing to compile the C-extensions as CMAKE apparently cannot find stdlib.h anymore. On windows, I sometimes got this error when trying to build PyRadiomics inside a virtualenv, but I'm not sure why this error occurs in macOS now.
A quick google search yielded this thread on stackoverflow. It's possible this is related to the error for SlicerRadiomics.

[jcfr]

@JoostJM It should be fairly straightforward to transition this project to use scikit-build ¹ and cibuildwheel²

In the context of the development of scikit-build-core (the new backend for sckit-build), we have funding to transition few projects.

Considering all pyradiomics dependency are available as wheels, updating pyradiomics would be a good candidate.

Dependencies

dependency	wheels available	PyPI
numpy	✔️	https://pypi.org/project/numpy/#files
SimpleITK	✔️	https://pypi.org/project/SimpleITK/#files
PyWavelets	✔️	https://pypi.org/project/PyWavelets/#files
pykwalify	✔️	https://pypi.org/project/pykwalify/#files
six	✔️	https://pypi.org/project/six/#files

Proposed Plan

• Transition CI to GitHub Actions
  • Remove Appveyor, CircleCI
  • Remove scikit-ci integration and leverage https://github.com/pypa/gh-action-pypi-publish
• Add CMakeLists.txt

@JoostJM In the next week or two, I should be able to tackle this. In the meantime, could you grant me owner access. This would greatly streamline the process. 🙏

Footnotes

1. https://github.com/scikit-build/scikit-build/ ↩

2. https://cibuildwheel.readthedocs.io ↩

[jcfr]

is the master branch necessary or could pyradiomics be installed using the latest whl

We should install from wheels, back in 2018 I added support for building from source because:

• Slicer python integration was different. Since we then, we support install wheels
• some dependencies of pyradiomics where not available as wheels

[fedorov]

@jcfr I've just added you as a maintainer. Will this be sufficient or you need the owner rights?

[jcfr]

Thanks @fedorov . For SlicerRadiomics, since we are not setting up CI and alike that will work well.

[fedorov]

Thank you for your help JC!

[fedorov]

See related discussion in https://discourse.slicer.org/t/radiomics-module-not-working/33382/16

[fedorov]

@jamesobutler @jcfr is this as simple as removing pyradiomics from CMake and installing it with slicer.util.pip_install('pyradiomics') as part of the module initialization?

[jcfr]

If all dependencies are distributed as wheels, answer would be yes.

I can help with that during the project week.