Add AtomsBase v0.5 compatibility#298
Merged
cortner merged 2 commits intoACEsuit:atomsbase-compatfrom Sep 26, 2025
Merged
Conversation
Collaborator
|
Thanks! I've approved CI to run, let's see if tests pass. |
Member
|
thanks for having an attempt at this. I'll try to review and see if I can help. If it's more complicated then we could move your branch to ACEsuit so we can collaborate on it. |
Member
|
merged into a local branch, will give Alex write access, but will try to take a look at this today or asap. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AtomsBase v0.5 changes
bounding_box→cell_vectorsbut doesn't seem to make any other breaking changes that would affect how ACEpotentials.jl functions.Dependency versions resolve but still need to make sure all tests pass too.
Fixes #297 (in theory).