Skip to content

Error display text in other language not english.  #213

Description

@dienht

Bug Description

When using a non-English locale, the impersonation banner shows raw translation keys instead of the translated text:

Current display:
filament-impersonate::banner.impersonating Nguyễn Khánh Thu filament-impersonate::banner.leave

Expected display:
Đang giả lập người dùng Nguyễn Khánh Thu Kết thúc giả lập

Steps to Reproduce

  1. Set application locale to non-English (e.g. Vietnamese 'vi')
  2. Implement impersonation feature
  3. Start impersonating a user
  4. Observe the banner text

Current Workaround Attempts

  • Created translation files in various locations:
    • lang/vendor/filament-impersonate/vi/translations.php
    • lang/vendor/filament-impersonate/vi/banner.php
    • lang/vi/filament-impersonate.php
  • None of above solutions worked, still showing raw translation keys

Suggested Solutions

  1. Add proper documentation for translation structure
  2. Provide publishable language files:
    php artisan vendor:publish --tag=filament-impersonate-translations
  3. Include example translation files in the package

Environment

  • Laravel version: 11.x
  • Filament v3
  • PHP version: 8.2
  • Package version: latest
  • Locale: vi

Screenshots attached:
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions